Summary:	ASTERISK-15249: [patch] Only the last setvar is effective for a given channel
Reporter:	raarts (raarts)	Labels:
Date Opened:	2009-12-01 03:53:25.000-0600	Date Closed:	2010-02-09 08:15:57.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_dahdi
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) dahdi-setvars.diff ( 1) dahdi-vars.diff
Description:	Other setvar's are forgotten. This is because the code in mkintf() assumes that the vars pointer only points to one variable strust, where in fact it can point to a whole list of them. One line patch attached.
Comments:	By: Leif Madsen (lmadsen) 2009-12-01 10:02:45.000-0600 Assigned to Tilghman only because this seems like the kind of thing he'd be interested in. If no interest, just set this back to "Confirmed". Thanks! By: raarts (raarts) 2009-12-04 00:42:36.000-0600 License is approved by legal By: Nico Kooijman (syspert) 2010-01-19 09:52:30.000-0600 Tested on trunk rev 241226 with a positive result By: Leif Madsen (lmadsen) 2010-01-19 10:54:16.000-0600 Moving to "Ready for Review" after a positive test case. Additional testers are always welcome! By: Tilghman Lesher (tilghman) 2010-01-19 15:41:41.000-0600 After setting variables on more than one channel, try running 'dahdi restart'.  I suspect you'll get a crash. If you want the variable list on more than one channel, you'll need to duplicate the entire list, not remove the duplication code. By: raarts (raarts) 2010-01-19 16:22:58.000-0600 You're probably right, we never do 'channel => 2-5', but alway declare each channel separately. I'll look into it, and adjust the patch. By: raarts (raarts) 2010-01-20 02:53:30.000-0600 This version creates a copy of the entire list. By: Digium Subversion (svnbot) 2010-02-03 12:34:31.000-0600 Repository: asterisk Revision: 244505 U   trunk/channels/chan_dahdi.c ------------------------------------------------------------------------ r244505 | tilghman | 2010-02-03 12:34:30 -0600 (Wed, 03 Feb 2010) | 8 lines The chanvar= setting should inherit the entire list of variables, not just the first one. (closes issue ASTERISK-15249) Reported by: raarts Patches:       dahdi-setvars.diff uploaded by raarts (license 937) Tested by: raarts ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=244505 By: Digium Subversion (svnbot) 2010-02-03 12:40:51.000-0600 Repository: asterisk Revision: 244506 _U  branches/1.6.0/ U   branches/1.6.0/channels/chan_dahdi.c ------------------------------------------------------------------------ r244506 | tilghman | 2010-02-03 12:40:50 -0600 (Wed, 03 Feb 2010) | 15 lines Merged revisions 244505 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r244505 | tilghman | 2010-02-03 12:34:29 -0600 (Wed, 03 Feb 2010) | 8 lines    The chanvar= setting should inherit the entire list of variables, not just the first one.    (closes issue ASTERISK-15249)   Reported by: raarts   Patches:         dahdi-setvars.diff uploaded by raarts (license 937)   Tested by: raarts ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=244506 By: Digium Subversion (svnbot) 2010-02-03 12:43:38.000-0600 Repository: asterisk Revision: 244507 _U  branches/1.6.1/ U   branches/1.6.1/channels/chan_dahdi.c ------------------------------------------------------------------------ r244507 | tilghman | 2010-02-03 12:43:38 -0600 (Wed, 03 Feb 2010) | 15 lines Merged revisions 244505 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r244505 | tilghman | 2010-02-03 12:34:29 -0600 (Wed, 03 Feb 2010) | 8 lines    The chanvar= setting should inherit the entire list of variables, not just the first one.    (closes issue ASTERISK-15249)   Reported by: raarts   Patches:         dahdi-setvars.diff uploaded by raarts (license 937)   Tested by: raarts ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=244507 By: Digium Subversion (svnbot) 2010-02-03 12:47:49.000-0600 Repository: asterisk Revision: 244508 _U  branches/1.6.2/ U   branches/1.6.2/channels/chan_dahdi.c U   branches/1.6.2/main/ast_expr2f.c ------------------------------------------------------------------------ r244508 | tilghman | 2010-02-03 12:47:49 -0600 (Wed, 03 Feb 2010) | 15 lines Merged revisions 244505 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r244505 | tilghman | 2010-02-03 12:34:29 -0600 (Wed, 03 Feb 2010) | 8 lines    The chanvar= setting should inherit the entire list of variables, not just the first one.    (closes issue ASTERISK-15249)   Reported by: raarts   Patches:         dahdi-setvars.diff uploaded by raarts (license 937)   Tested by: raarts ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=244508