Summary:	ASTERISK-15231: [patch] Fix bootstrap.sh on OpenSolaris
Reporter:	Ben Klang (bklang)	Labels:
Date Opened:	2009-11-28 16:53:14.000-0600	Date Closed:	2010-05-11 11:45:02
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) opensolaris_bootstrap.sh
Description:	The attached patch modifies bootstrap.sh to function properly on OpenSolaris 2009.06.
Comments:	By: Tilghman Lesher (tilghman) 2009-11-29 23:21:49.000-0600 I don't think these changes really pass muster.  The problem is that your changes will affect all versions of Solaris, not just the OpenSolaris release named.  So an older version of Solaris that had autoconf 2.4 would execute, even though that version is insufficient to perform the required tasks.  I think you need to carefully consider the versions available and recheck your patch. By: Ben Klang (bklang) 2009-12-04 15:49:15.000-0600 At the moment I do not have an older version of Solaris on which to test this, though I am working on it.  I suspect the bootstrap.sh that exists today would not work properly on older versions of Solaris at all since there are no explicit checks for Solaris.  If you know otherwise and can correct me, I'll be happy to rework the patch to address your concerns. However, I hope that, in the case I am correct, you will consider applying this patch as-is because it improves the bootstrap.sh to at least work correctly with OpenSolaris.  If and when additional tests for other versions of Solaris can be identified, those improvements can be added as well. By: Digium Subversion (svnbot) 2010-05-11 11:43:07 Repository: asterisk Revision: 262299 U   trunk/bootstrap.sh ------------------------------------------------------------------------ r262299 | qwell | 2010-05-11 11:43:07 -0500 (Tue, 11 May 2010) | 12 lines Allow bootstrap script to work on Solaris. As usual, the way they do things is different, so we need to account for that. automake is versioned ala BSD/Linux, but autoconf is not.  We don't actually need to specify a version there, since AC_PREREQ will cover it for us.  Things will fail pretty loudly if AC_PREREQ isn't met. (closes issue ASTERISK-15231) Reported by: bklang Patches:      opensolaris_bootstrap.sh uploaded by bklang (license 919) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=262299 By: Digium Subversion (svnbot) 2010-05-11 11:45:01 Repository: asterisk Revision: 262300 _U  branches/1.6.2/ ------------------------------------------------------------------------ r262300 | qwell | 2010-05-11 11:45:01 -0500 (Tue, 11 May 2010) | 18 lines Blocked revisions 262299 via svnmerge ........  r262299 | qwell | 2010-05-11 11:43:07 -0500 (Tue, 11 May 2010) | 12 lines    Allow bootstrap script to work on Solaris.    As usual, the way they do things is different, so we need to account for that.  automake is versioned ala BSD/Linux, but autoconf is not.  We don't actually  need to specify a version there, since AC_PREREQ will cover it for us.  Things  will fail pretty loudly if AC_PREREQ isn't met.    (closes issue ASTERISK-15231)  Reported by: bklang  Patches:        opensolaris_bootstrap.sh uploaded by bklang (license 919) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=262300