[Home]

Summary:ASTERISK-15222: [patch] A blind transfer results in a call with empty accountcode in a specific circumstance
Reporter:Michael Gaudette (bluefox)Labels:
Date Opened:2009-11-26 13:01:20.000-0600Date Closed:2010-03-22 14:57:12
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_transfer
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) peer-cdr-accountcode-fix1.diff
Description:When a phone that originated a call does a blind transfer of that call, the resulting call has no accountcode.



****** ADDITIONAL INFORMATION ******

Using asterisk 1.4.26.1.
Comments:By: Leif Madsen (lmadsen) 2009-11-30 14:52:22.000-0600

I'm marking this as related to issue ASTERISK-14945, but it is really only possibly related, as it looks similar, but I don't know enough about the original issue to know how true that is.
By: Leif Madsen (lmadsen) 2009-11-30 14:54:35.000-0600

If someone could verify if the issues are related, that would be useful.
By: Leif Madsen (lmadsen) 2009-11-30 14:55:00.000-0600

Could you also provide some console output demonstrating the issue?
By: Michael Gaudette (bluefox) 2009-12-03 08:21:00.000-0600

I do not know if the issue is related, but it might very well be. I would say this current issue is probably a more basic problem, and the other issue the consequence of this one.

Here is a relevant console output.  Call is from 705 to 799, then blind transfer (using a Polycom 650) back to 705 (works in all circumstances where I blind transfer a call that I originated)

    -- Executing [705@internal-transfer:1] Set("SIP/test-2-0e066f60", "direct_reception=0") in new stack
   -- Executing [705@internal-transfer:2] Goto("SIP/test-2-0e066f60", "generic-extensions-db|705|1") in new stack
   -- Goto (generic-extensions-db,705,1)
   -- Executing [705@generic-extensions-db:1] Set("SIP/test-2-0e066f60", "i=0") in new stack
   -- Executing [705@generic-extensions-db:2] Verbose("SIP/test-2-0e066f60", "1|Extension 705 called for account ") in new stack
Extension 705 called for account


Last "Verbose" command is like this in my dialplan file:

exten => 705,n,Verbose(1|Extension ${EXTEN} called for account ${CDR(accountcode)})

So the accountcode is empty/NULL.  Later in my dialplan, alot of logic depends on that value so things don't work out, but this is where you see a value being empty that should have something in it.
By: Matthew Nicholson (mnicholson) 2010-01-18 15:02:09.000-0600

Which version of asterisk are you able to reproduce this with?
By: Michael Gaudette (bluefox) 2010-01-18 15:12:53.000-0600

100% with 1.4.26.1.
By: Michael Gaudette (bluefox) 2010-01-18 15:28:01.000-0600

Is testing latest 1.4 relevant? Or am I forced to upgrade to 1.6 for this?
By: Leif Madsen (lmadsen) 2010-01-18 16:11:13.000-0600

I believe he was asking which version in the 1.4 series -- you should never have to upgrade to another version (i.e. 1.4 -> 1.6.0, or 1.6.0 -> 1.6.1, etc...) to resolve an issue, unless of course it is because of a feature that has been added to a future version.
By: Michael Gaudette (bluefox) 2010-01-18 21:36:03.000-0600

I just upgraded to 1.4.29, and the issue is still there.
By: Matthew Nicholson (mnicholson) 2010-01-19 13:58:04.000-0600

This is sort of the expected behavior (not that it is the correct behavior).  If the called party does the transfer, Asterisk will use the account code of the called party for the CDR record (if my analysis is correct).

It seems you are expecting the account code of the calling party to always be stored regardless of whether or not the called or calling party does the transfer.

You may want to try working around this by setting an inherited channel variable and setting that as the account code in your dialplan.
By: Michael Gaudette (bluefox) 2010-01-19 15:40:01.000-0600

Not really.  What I am expecting is that the CDR value on the resulting transfer call is the one from the party that was transfered (since it's a blind transfer). t's just that I am either bridging somebody who calls me (accountcode set inbound to x) to somebody else or transfering somebody I called to someone else (accountcode set to x on the outgoing call).

Subjective opinions like that aside, should any call to and from a PBX really be without any accountcode whatsoever?
By: Matthew Nicholson (mnicholson) 2010-01-20 10:13:08.000-0600

Test with the patch I uploaded and see if it fixes your problem.  I won't be committing this patch to asterisk, but it may still be useful to you.
By: Michael Gaudette (bluefox) 2010-01-25 09:15:03.000-0600

Thanks, I will test it as soon as I have a free night, but it's of limited use since it will handcuff me to version 1.4.29.

Not complaining of course, I appreciate.  But I'll be back to this when upgrading.

Would going to 1.6.x fix my problem?
By: Matthew Nicholson (mnicholson) 2010-01-25 11:52:24.000-0600

This patch should work with some older versions of 1.4 too.  1.6 probably has the same issue.
By: Digium Subversion (svnbot) 2010-02-18 13:38:09.000-0600

Repository: asterisk
Revision: 247651

U   branches/1.4/res/res_features.c

------------------------------------------------------------------------
r247651 | mnicholson | 2010-02-18 13:38:09 -0600 (Thu, 18 Feb 2010) | 6 lines

Copy the calling party's account code to the called party if they don't already have one.

(closes issue ASTERISK-15222)
Reported by: bluefox
Tested by: mnicholson

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=247651
By: Digium Subversion (svnbot) 2010-02-18 13:39:38.000-0600

Repository: asterisk
Revision: 247652

_U  trunk/
U   trunk/main/features.c

------------------------------------------------------------------------
r247652 | mnicholson | 2010-02-18 13:39:38 -0600 (Thu, 18 Feb 2010) | 13 lines

Merged revisions 247651 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r247651 | mnicholson | 2010-02-18 13:38:09 -0600 (Thu, 18 Feb 2010) | 6 lines
 
 Copy the calling party's account code to the called party if they don't already have one.
 
 (closes issue ASTERISK-15222)
 Reported by: bluefox
 Tested by: mnicholson
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=247652
By: Digium Subversion (svnbot) 2010-02-18 13:41:56.000-0600

Repository: asterisk
Revision: 247653

_U  branches/1.6.2/
U   branches/1.6.2/main/features.c

------------------------------------------------------------------------
r247653 | mnicholson | 2010-02-18 13:41:56 -0600 (Thu, 18 Feb 2010) | 20 lines

Merged revisions 247652 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r247652 | mnicholson | 2010-02-18 13:39:37 -0600 (Thu, 18 Feb 2010) | 13 lines
 
 Merged revisions 247651 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r247651 | mnicholson | 2010-02-18 13:38:09 -0600 (Thu, 18 Feb 2010) | 6 lines
   
   Copy the calling party's account code to the called party if they don't already have one.
   
   (closes issue ASTERISK-15222)
   Reported by: bluefox
   Tested by: mnicholson
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=247653
By: Digium Subversion (svnbot) 2010-02-18 13:45:24.000-0600

Repository: asterisk
Revision: 247654

_U  branches/1.6.1/
U   branches/1.6.1/main/features.c

------------------------------------------------------------------------
r247654 | mnicholson | 2010-02-18 13:45:24 -0600 (Thu, 18 Feb 2010) | 20 lines

Merged revisions 247652 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r247652 | mnicholson | 2010-02-18 13:39:37 -0600 (Thu, 18 Feb 2010) | 13 lines
 
 Merged revisions 247651 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r247651 | mnicholson | 2010-02-18 13:38:09 -0600 (Thu, 18 Feb 2010) | 6 lines
   
   Copy the calling party's account code to the called party if they don't already have one.
   
   (closes issue ASTERISK-15222)
   Reported by: bluefox
   Tested by: mnicholson
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=247654
By: Digium Subversion (svnbot) 2010-02-18 13:45:45.000-0600

Repository: asterisk
Revision: 247655

_U  branches/1.6.0/
U   branches/1.6.0/main/features.c

------------------------------------------------------------------------
r247655 | mnicholson | 2010-02-18 13:45:45 -0600 (Thu, 18 Feb 2010) | 20 lines

Merged revisions 247652 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r247652 | mnicholson | 2010-02-18 13:39:37 -0600 (Thu, 18 Feb 2010) | 13 lines
 
 Merged revisions 247651 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r247651 | mnicholson | 2010-02-18 13:38:09 -0600 (Thu, 18 Feb 2010) | 6 lines
   
   Copy the calling party's account code to the called party if they don't already have one.
   
   (closes issue ASTERISK-15222)
   Reported by: bluefox
   Tested by: mnicholson
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=247655
By: Digium Subversion (svnbot) 2010-03-22 14:50:01

Repository: asterisk
Revision: 253799

U   branches/1.4/res/res_features.c

------------------------------------------------------------------------
r253799 | mnicholson | 2010-03-22 14:50:00 -0500 (Mon, 22 Mar 2010) | 4 lines

Unconditionally copy the caller's account code to the called party.

(related to issue ASTERISK-15222)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=253799
By: Digium Subversion (svnbot) 2010-03-22 14:52:53

Repository: asterisk
Revision: 253800

_U  trunk/
U   trunk/main/features.c

------------------------------------------------------------------------
r253800 | mnicholson | 2010-03-22 14:52:52 -0500 (Mon, 22 Mar 2010) | 11 lines

Merged revisions 253799 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r253799 | mnicholson | 2010-03-22 14:50:00 -0500 (Mon, 22 Mar 2010) | 4 lines
 
 Unconditionally copy the caller's account code to the called party.
 
 (related to issue ASTERISK-15222)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=253800
By: Digium Subversion (svnbot) 2010-03-22 14:55:09

Repository: asterisk
Revision: 253801

_U  branches/1.6.2/
U   branches/1.6.2/main/features.c

------------------------------------------------------------------------
r253801 | mnicholson | 2010-03-22 14:55:08 -0500 (Mon, 22 Mar 2010) | 18 lines

Merged revisions 253800 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r253800 | mnicholson | 2010-03-22 14:52:52 -0500 (Mon, 22 Mar 2010) | 11 lines
 
 Merged revisions 253799 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r253799 | mnicholson | 2010-03-22 14:50:00 -0500 (Mon, 22 Mar 2010) | 4 lines
   
   Unconditionally copy the caller's account code to the called party.
   
   (related to issue ASTERISK-15222)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=253801
By: Digium Subversion (svnbot) 2010-03-22 14:56:37

Repository: asterisk
Revision: 253802

_U  branches/1.6.1/
U   branches/1.6.1/main/features.c

------------------------------------------------------------------------
r253802 | mnicholson | 2010-03-22 14:56:37 -0500 (Mon, 22 Mar 2010) | 18 lines

Merged revisions 253800 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r253800 | mnicholson | 2010-03-22 14:52:52 -0500 (Mon, 22 Mar 2010) | 11 lines
 
 Merged revisions 253799 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r253799 | mnicholson | 2010-03-22 14:50:00 -0500 (Mon, 22 Mar 2010) | 4 lines
   
   Unconditionally copy the caller's account code to the called party.
   
   (related to issue ASTERISK-15222)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=253802
By: Digium Subversion (svnbot) 2010-03-22 14:57:12

Repository: asterisk
Revision: 253803

_U  branches/1.6.0/
U   branches/1.6.0/main/features.c

------------------------------------------------------------------------
r253803 | mnicholson | 2010-03-22 14:57:11 -0500 (Mon, 22 Mar 2010) | 18 lines

Merged revisions 253800 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r253800 | mnicholson | 2010-03-22 14:52:52 -0500 (Mon, 22 Mar 2010) | 11 lines
 
 Merged revisions 253799 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r253799 | mnicholson | 2010-03-22 14:50:00 -0500 (Mon, 22 Mar 2010) | 4 lines
   
   Unconditionally copy the caller's account code to the called party.
   
   (related to issue ASTERISK-15222)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=253803