Summary:	ASTERISK-15215: [patch] confusing description in configs/sip.conf.sample
Reporter:	klaus3000 (klaus3000)	Labels:
Date Opened:	2009-11-25 16:14:00.000-0600	Date Closed:	2010-07-12 11:04:15
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) sip.conf.sample-patch.txt
Description:	Hi! There is a confusing text in sip.conf when describing the NAT options: externip/externhost/stunaddr ;   Note that at the moment all these mechanism work only for the SIP socket. ;   The IP address discovered with externip/externhost/STUN is reused for ;   media sessions as well, but the port numbers are not remapped so you ;   may still experience problems. ; ; NOTE 1: in some cases, NAT boxes will use different port numbers in ; the internal<->external mapping. In these cases, the "externip" and ; "externhost" might not help you configure addresses properly, and you ; really need to use STUN. ; ; NOTE 2: when using "externip" or "externhost", the address part is ; also used as the external address for media sessions. ; If you use "stunaddr", STUN queries will be sent to the same server ; also from media sockets, and this should permit a correct mapping of ; the port numbers as well. The first paragraph is contradictory to NOTE 2. Note 2 tells that "stunaddr" also uses STUN on the media port to announce the proper socket in the SDP, but the first paragraph says that ALL mechanisms do only take care of SIP. ****** ADDITIONAL INFORMATION ****** Depending on if "stunaddr" also sets the SDP socket info correct either the first paragraph or the NOTE 2 should be fixed.
Comments:	By: Leif Madsen (lmadsen) 2009-12-01 12:47:49.000-0600 Hey Olle, do you have a suggestion for some better wording here? If so, I can tweak it a bit and make the commit. Anyone else who has a suggestion for the text is welcome to submit it. I don't quite understand the text enough (and I'm a bit sick right now) to feel comfortable tweaking it on my own :) By: Leif Madsen (lmadsen) 2010-01-13 08:35:35.000-0600 Hey klaus3000, thanks for the report. As I'm not entirely sure what to reword here and oej has no comments, I'm going to direct you to the mailing list to see if you can get some comments from the community to see if we can get a better wording here and then I can commit it. Thanks! By: klaus3000 (klaus3000) 2010-06-02 04:59:17 Hi! I justed tested Asterisk trunk to find out how stun really works in chan_sip. It seems that Note2 is wrong: I did not saw any STUN requests from the RTP ports - there are only STUN requests from the SIP port. It seems like there is code in res_rtp_asterisk.c to handle STUN, but the code is not triggered by chan_sip. Therefore, I suggest to delete Note2 completely. By: Paul Belanger (pabelanger) 2010-06-02 08:08:19 Are you able to provide a patch? By: klaus3000 (klaus3000) 2010-06-02 09:02:24 Patch is uploaded! Instead of removing the second note I changed the text to be more explicit about the lack of STUN for media ports. By: Leif Madsen (lmadsen) 2010-06-08 10:21:20 Based on the note, does this mean another issue should be opened which actually fixes the issue with the SDP information being wrong? Or is there nothing that can be done there? By: Digium Subversion (svnbot) 2010-06-08 10:23:21 Repository: asterisk Revision: 268988 U   trunk/configs/sip.conf.sample ------------------------------------------------------------------------ r268988 | lmadsen | 2010-06-08 10:23:20 -0500 (Tue, 08 Jun 2010) | 8 lines Update note in sip.conf.sample. Update note in sip.conf.sample about externip and externhost with STUN. (closes issue ASTERISK-15215) Reported by: klaus3000 Patches:      sip.conf.sample-patch.txt uploaded by klaus3000 (license 65) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=268988 By: Digium Subversion (svnbot) 2010-06-08 10:23:49 Repository: asterisk Revision: 268990 _U  branches/1.6.2/ U   branches/1.6.2/configs/sip.conf.sample ------------------------------------------------------------------------ r268990 | lmadsen | 2010-06-08 10:23:48 -0500 (Tue, 08 Jun 2010) | 15 lines Merged revisions 268988 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r268988 | lmadsen | 2010-06-08 10:23:20 -0500 (Tue, 08 Jun 2010) | 8 lines    Update note in sip.conf.sample.  Update note in sip.conf.sample about externip and externhost with STUN.    (closes issue ASTERISK-15215)  Reported by: klaus3000  Patches:        sip.conf.sample-patch.txt uploaded by klaus3000 (license 65) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=268990