[Home]

Summary:ASTERISK-15194: [patch] Some warnings when parsing extensions.conf fail to include line numbers
Reporter:dant (dant)Labels:
Date Opened:2009-11-22 02:30:46.000-0600Date Closed:2010-05-11 15:11:40
Priority:MajorRegression?No
Status:Closed/CompleteComponents:PBX/pbx_config
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast-pbx_config.c-add_lineno_to_warnings-20091122.patch
( 1) issue16303.patch.v2
Description:When parsing extensions.conf in pbx_config.c some warnings that refer to specific lines don't include a line number in the warning that would assist in locating the problem line in the configuration.
Comments:By: dant (dant) 2009-11-22 02:34:43.000-0600

Patch attached to add line number to 8 warning messages and 1 error message.
By: Leif Madsen (lmadsen) 2009-11-23 19:28:07.000-0600

Thanks for the submission!
By: Paul Belanger (pabelanger) 2010-05-05 16:09:32

.v2 reapplied against trunk. Thanks again.
By: Leif Madsen (lmadsen) 2010-05-10 11:05:13

This looks good to me! What is the next step?
By: Digium Subversion (svnbot) 2010-05-11 14:40:37

Repository: asterisk
Revision: 262419

U   trunk/pbx/pbx_config.c

------------------------------------------------------------------------
r262419 | pabelanger | 2010-05-11 14:40:37 -0500 (Tue, 11 May 2010) | 8 lines

Improve logging by displaying line number

(closes issue ASTERISK-15194)
Reported by: dant
Patches:
     issue16303.patch.v2 uploaded by pabelanger (license 224)
Tested by: dant, lmadsen, pabelanger

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262419
By: Digium Subversion (svnbot) 2010-05-11 14:41:44

Repository: asterisk
Revision: 262420

_U  branches/1.6.2/
U   branches/1.6.2/pbx/pbx_config.c

------------------------------------------------------------------------
r262420 | pabelanger | 2010-05-11 14:41:43 -0500 (Tue, 11 May 2010) | 15 lines

Merged revisions 262419 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262419 | pabelanger | 2010-05-11 15:40:37 -0400 (Tue, 11 May 2010) | 8 lines
 
 Improve logging by displaying line number
 
 (closes issue ASTERISK-15194)
 Reported by: dant
 Patches:
       issue16303.patch.v2 uploaded by pabelanger (license 224)
 Tested by: dant, lmadsen, pabelanger
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262420
By: Digium Subversion (svnbot) 2010-05-11 15:02:32

Repository: asterisk
Revision: 262426

_U  branches/1.6.1/
U   branches/1.6.1/pbx/pbx_config.c

------------------------------------------------------------------------
r262426 | pabelanger | 2010-05-11 15:02:32 -0500 (Tue, 11 May 2010) | 15 lines

Merged revisions 262419 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262419 | pabelanger | 2010-05-11 15:40:37 -0400 (Tue, 11 May 2010) | 8 lines
 
 Improve logging by displaying line number
 
 (closes issue ASTERISK-15194)
 Reported by: dant
 Patches:
       issue16303.patch.v2 uploaded by pabelanger (license 224)
 Tested by: dant, lmadsen, pabelanger
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262426
By: Digium Subversion (svnbot) 2010-05-11 15:11:39

Repository: asterisk
Revision: 262427

_U  branches/1.6.0/
U   branches/1.6.0/pbx/pbx_config.c

------------------------------------------------------------------------
r262427 | pabelanger | 2010-05-11 15:11:39 -0500 (Tue, 11 May 2010) | 15 lines

Merged revisions 262419 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262419 | pabelanger | 2010-05-11 15:40:37 -0400 (Tue, 11 May 2010) | 8 lines
 
 Improve logging by displaying line number
 
 (closes issue ASTERISK-15194)
 Reported by: dant
 Patches:
       issue16303.patch.v2 uploaded by pabelanger (license 224)
 Tested by: dant, lmadsen, pabelanger
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262427