[Home]

Summary:ASTERISK-15179: [patch] core show function CDR reports wrong disposition values
Reporter:Walter Doekes (wdoekes)Labels:
Date Opened:2009-11-20 04:40:31.000-0600Date Closed:2010-01-06 15:48:50.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Functions/func_cdr
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast14-cdr-docs.diff
( 1) ast16-cdr-docs.diff
Description:When running:

exten => s,1,Answer()
exten => s,n,NoOp(exten => _X.,n,NoOp(QUEUE_ANS: ${CDR(disposition)} / ${CDR(disposition,u)})

I get:

voip-test*CLI>
<...snip...>
   -- Executing [s@pi_incoming_queue:2] NoOp("SIP/1.2.3.4-0241c1e0", "QUEUE_ANS: ANSWERED / 8") in new stack
<...snip...>


When checking the function description, I get:

voip-test*CLI> core show function CDR
<...snip...>
  raw values for disposition:
      1 = NO ANSWER
      2 = BUSY
      3 = FAILED
      4 = ANSWERED
<...snip...>


This means that the raw disposition values in the documentation are wrong, right?

According to svn blame it has always been like this in include/asterisk/cdr.h:
#define AST_CDR_FAILED                          (1 << 0)
#define AST_CDR_BUSY                            (1 << 1)
#define AST_CDR_NOANSWER                        (1 << 2)
#define AST_CDR_ANSWERED                        (1 << 3)


Patch for 1.4:

<inline patch removed by lmadsen>

Patch for 1.6-svn:

<inline patch removed by lmadsen>



Regards,
Walter Doekes
OSSO B.V.
Comments:By: Leif Madsen (lmadsen) 2009-11-20 08:30:43.000-0600

Unfortunately we can't accept inline patches as that circumvents the licensing system we have in place.

Would you mind signing the electronic license (if you haven't already)? There is a link in the main header of this page that will allow you to submit it online.

Once you've done that, could you upload your patch as an attachment to this issue?

Thanks for the contribution!
By: Walter Doekes (wdoekes) 2009-11-20 08:38:23.000-0600

LOL, okay, sure thing :)
By: Digium Subversion (svnbot) 2010-01-06 15:41:55.000-0600

Repository: asterisk
Revision: 238230

U   branches/1.4/funcs/func_cdr.c

------------------------------------------------------------------------
r238230 | tilghman | 2010-01-06 15:41:55 -0600 (Wed, 06 Jan 2010) | 4 lines

Revise documentation on disposition values to the actual values used.
(closes issue ASTERISK-15179)
Reported by: wdoekes

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238230
By: Digium Subversion (svnbot) 2010-01-06 15:45:18.000-0600

Repository: asterisk
Revision: 238231

_U  trunk/
U   trunk/funcs/func_cdr.c

------------------------------------------------------------------------
r238231 | tilghman | 2010-01-06 15:45:18 -0600 (Wed, 06 Jan 2010) | 11 lines

Merged revisions 238230 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r238230 | tilghman | 2010-01-06 15:41:55 -0600 (Wed, 06 Jan 2010) | 4 lines
 
 Revise documentation on disposition values to the actual values used.
 (closes issue ASTERISK-15179)
  Reported by: wdoekes
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238231
By: Digium Subversion (svnbot) 2010-01-06 15:48:33.000-0600

Repository: asterisk
Revision: 238232

_U  branches/1.6.0/
U   branches/1.6.0/funcs/func_cdr.c

------------------------------------------------------------------------
r238232 | tilghman | 2010-01-06 15:48:32 -0600 (Wed, 06 Jan 2010) | 18 lines

Merged revisions 238231 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r238231 | tilghman | 2010-01-06 15:45:17 -0600 (Wed, 06 Jan 2010) | 11 lines
 
 Merged revisions 238230 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r238230 | tilghman | 2010-01-06 15:41:55 -0600 (Wed, 06 Jan 2010) | 4 lines
   
   Revise documentation on disposition values to the actual values used.
   (closes issue ASTERISK-15179)
    Reported by: wdoekes
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238232
By: Digium Subversion (svnbot) 2010-01-06 15:48:41.000-0600

Repository: asterisk
Revision: 238233

_U  branches/1.6.1/
U   branches/1.6.1/funcs/func_cdr.c

------------------------------------------------------------------------
r238233 | tilghman | 2010-01-06 15:48:41 -0600 (Wed, 06 Jan 2010) | 18 lines

Merged revisions 238231 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r238231 | tilghman | 2010-01-06 15:45:17 -0600 (Wed, 06 Jan 2010) | 11 lines
 
 Merged revisions 238230 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r238230 | tilghman | 2010-01-06 15:41:55 -0600 (Wed, 06 Jan 2010) | 4 lines
   
   Revise documentation on disposition values to the actual values used.
   (closes issue ASTERISK-15179)
    Reported by: wdoekes
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238233
By: Digium Subversion (svnbot) 2010-01-06 15:48:50.000-0600

Repository: asterisk
Revision: 238234

_U  branches/1.6.2/
U   branches/1.6.2/funcs/func_cdr.c

------------------------------------------------------------------------
r238234 | tilghman | 2010-01-06 15:48:49 -0600 (Wed, 06 Jan 2010) | 18 lines

Merged revisions 238231 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r238231 | tilghman | 2010-01-06 15:45:17 -0600 (Wed, 06 Jan 2010) | 11 lines
 
 Merged revisions 238230 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r238230 | tilghman | 2010-01-06 15:41:55 -0600 (Wed, 06 Jan 2010) | 4 lines
   
   Revise documentation on disposition values to the actual values used.
   (closes issue ASTERISK-15179)
    Reported by: wdoekes
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238234