|Summary:||ASTERISK-15176: Review of internal_timing code|
|Reporter:||Leif Madsen (lmadsen)||Labels:|
|Date Opened:||2009-11-19 09:23:49.000-0600||Date Closed:||2010-03-11 09:34:04.000-0600|
|Description:||Per Russell's comments on the mailing list in reference to a suggestion to make 'internal_timing' on by default:|
"I'm fine with this in general (even in 1.4). However, someone just
needs to do an audit of the related code to make sure that nothing bad
will happen if this is on and DAHDI is not available. That also
includes scary error messages telling someone the world is broken when
it's not really true."
****** ADDITIONAL INFORMATION ******
This issue is the child of the issue for turning internal_timing on by default. This must be done prior to making the change in the branches.
|Comments:||By: Jason Parker (jparker) 2010-02-05 14:22:10.000-0600|
Looking at the patch and the bug report that added this feature, I've concluded that it should be safe to proceed. In fact, I would argue that we should just *remove* the option entirely (in branches that use res_timing_, at least).
The patch is incredibly small. The option was apparently an afterthought which seemed like a good idea in case it broke things (it hasn't).
I'd like to do a bit of testing (which should perhaps be in the parent issue) before we do anything though.
By: Jason Parker (jparker) 2010-02-10 17:22:56.000-0600
I'm closing this per my previous comment. See parent issue.