| Summary: | ASTERISK-15163: [patch] Language code collisions for certan languages | ||
| Reporter: | Pavel Troller (patrol-cz) | Labels: | |
| Date Opened: | 2009-11-18 09:39:41.000-0600 | Date Closed: | 2009-12-03 15:11:29.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 20091203__issue16272.diff.txt | |
| Description: | Probably in all current Asterisk branches, there are collisions for at least two language codes: Czech (cs/cz) and Swedish (sv/se). For example, the Czech language code is "cz" in all the tonezone stuff and also in app_voicemail.c, while in say.c, request to use the correct code "cs" is printed when an obsolete "cz" code is used, but following it would break Czech voicemail syntax rules in app_voicemail.c.So, I feel necessary to unify the codes and start to use only one of them, probably "cs". ****** ADDITIONAL INFORMATION ****** This issue was first brought up on the asterisk-dev mailing list, and the archive can be found here: http://lists.digium.com/pipermail/asterisk-dev/2009-November/040643.html | ||
| Comments: | By: Tilghman Lesher (tilghman) 2009-12-03 13:39:37.000-0600 While I agree with the changes to voicemail (and any other places where prompts are used), there shouldn't be a change to tonezone, and here's why: We're dealing with two different sets of codes, and their purpose is slightly different. In the case of the language setting, these are ISO 639 codes. For country codes, we use ISO 3166. The differences are striking. For example, you can speak Spanish (lang=es) in a country which uses US tones (tonezone=us). So while in some situations, there is parity between the language and the tonezone; in other situations, they clearly need to be different. By: Digium Subversion (svnbot) 2009-12-03 14:18:00.000-0600 Repository: asterisk Revision: 232820 U branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r232820 | tilghman | 2009-12-03 14:18:00 -0600 (Thu, 03 Dec 2009) | 8 lines Deprecate "cz" in favor of "cs". Also, change the use of language codes so that language registers as a prefix, rather than an exact match. (closes issue ASTERISK-15163) Reported by: patrol-cz Patches: 20091203__issue16272.diff.txt uploaded by tilghman (license 14) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=232820 By: Digium Subversion (svnbot) 2009-12-03 14:54:48.000-0600 Repository: asterisk Revision: 232854 _U trunk/ U trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r232854 | tilghman | 2009-12-03 14:54:48 -0600 (Thu, 03 Dec 2009) | 15 lines Merged revisions 232820 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r232820 | tilghman | 2009-12-03 14:10:19 -0600 (Thu, 03 Dec 2009) | 8 lines Deprecate "cz" in favor of "cs". Also, change the use of language codes so that language registers as a prefix, rather than an exact match. (closes issue ASTERISK-15163) Reported by: patrol-cz Patches: 20091203__issue16272.diff.txt uploaded by tilghman (license 14) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=232854 By: Digium Subversion (svnbot) 2009-12-03 15:11:11.000-0600 Repository: asterisk Revision: 232864 _U branches/1.6.0/ U branches/1.6.0/apps/app_voicemail.c ------------------------------------------------------------------------ r232864 | tilghman | 2009-12-03 15:11:10 -0600 (Thu, 03 Dec 2009) | 22 lines Merged revisions 232854 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r232854 | tilghman | 2009-12-03 14:47:07 -0600 (Thu, 03 Dec 2009) | 15 lines Merged revisions 232820 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r232820 | tilghman | 2009-12-03 14:10:19 -0600 (Thu, 03 Dec 2009) | 8 lines Deprecate "cz" in favor of "cs". Also, change the use of language codes so that language registers as a prefix, rather than an exact match. (closes issue ASTERISK-15163) Reported by: patrol-cz Patches: 20091203__issue16272.diff.txt uploaded by tilghman (license 14) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=232864 By: Digium Subversion (svnbot) 2009-12-03 15:11:20.000-0600 Repository: asterisk Revision: 232865 _U branches/1.6.1/ U branches/1.6.1/apps/app_voicemail.c ------------------------------------------------------------------------ r232865 | tilghman | 2009-12-03 15:11:19 -0600 (Thu, 03 Dec 2009) | 22 lines Merged revisions 232854 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r232854 | tilghman | 2009-12-03 14:47:07 -0600 (Thu, 03 Dec 2009) | 15 lines Merged revisions 232820 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r232820 | tilghman | 2009-12-03 14:10:19 -0600 (Thu, 03 Dec 2009) | 8 lines Deprecate "cz" in favor of "cs". Also, change the use of language codes so that language registers as a prefix, rather than an exact match. (closes issue ASTERISK-15163) Reported by: patrol-cz Patches: 20091203__issue16272.diff.txt uploaded by tilghman (license 14) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=232865 By: Digium Subversion (svnbot) 2009-12-03 15:11:29.000-0600 Repository: asterisk Revision: 232866 _U branches/1.6.2/ U branches/1.6.2/apps/app_voicemail.c ------------------------------------------------------------------------ r232866 | tilghman | 2009-12-03 15:11:28 -0600 (Thu, 03 Dec 2009) | 22 lines Merged revisions 232854 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r232854 | tilghman | 2009-12-03 14:47:07 -0600 (Thu, 03 Dec 2009) | 15 lines Merged revisions 232820 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r232820 | tilghman | 2009-12-03 14:10:19 -0600 (Thu, 03 Dec 2009) | 8 lines Deprecate "cz" in favor of "cs". Also, change the use of language codes so that language registers as a prefix, rather than an exact match. (closes issue ASTERISK-15163) Reported by: patrol-cz Patches: 20091203__issue16272.diff.txt uploaded by tilghman (license 14) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=232866 | ||