[Home]

Summary:ASTERISK-15159: [patch] Last line of SDP is not being parsed
Reporter:Santiago Gimeno (sgimeno)Labels:
Date Opened:2009-11-18 03:59:11.000-0600Date Closed:2009-11-30 13:41:44.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) debug.log
( 1) sdp.patch
Description:I observed this behavior when I put a call in hold and no musiconhold was played. The last line of the SDP of the "hold" re-INVITE was a=sendonly.
By checking the logs it can be seen that the last line of the SDP is not processed in the process_sdp function.
I made a simple modification in the chan_sip.c (see attached patch) in order to parse the last line and the issue was solved.

****** ADDITIONAL INFORMATION ******

OS Version: Debian 'Lenny':
Linux (none) 2.6.26-2-686 #1 SMP Wed Aug 19 06:06:52 UTC 2009 i686 GNU/Linux
Comments:By: Leif Madsen (lmadsen) 2009-11-18 09:53:12.000-0600

Thanks for the contribution!
By: Digium Subversion (svnbot) 2009-11-23 08:20:51.000-0600

Repository: asterisk
Revision: 230772

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r230772 | kpfleming | 2009-11-23 08:20:50 -0600 (Mon, 23 Nov 2009) | 5 lines

Ensure that SDP parsing does not ignore the last line of the SDP.

(closes issue ASTERISK-15159)
Reported by: sgimeno

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230772
By: Digium Subversion (svnbot) 2009-11-23 08:22:42.000-0600

Repository: asterisk
Revision: 230773

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r230773 | kpfleming | 2009-11-23 08:22:42 -0600 (Mon, 23 Nov 2009) | 12 lines

Merged revisions 230772 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r230772 | kpfleming | 2009-11-23 08:13:56 -0600 (Mon, 23 Nov 2009) | 5 lines
 
 Ensure that SDP parsing does not ignore the last line of the SDP.
 
 (closes issue ASTERISK-15159)
 Reported by: sgimeno
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230773
By: Digium Subversion (svnbot) 2009-11-23 08:25:55.000-0600

Repository: asterisk
Revision: 230782

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r230782 | kpfleming | 2009-11-23 08:25:55 -0600 (Mon, 23 Nov 2009) | 19 lines

Merged revisions 230773 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r230773 | kpfleming | 2009-11-23 08:15:48 -0600 (Mon, 23 Nov 2009) | 12 lines
 
 Merged revisions 230772 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r230772 | kpfleming | 2009-11-23 08:13:56 -0600 (Mon, 23 Nov 2009) | 5 lines
   
   Ensure that SDP parsing does not ignore the last line of the SDP.
   
   (closes issue ASTERISK-15159)
   Reported by: sgimeno
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230782
By: Digium Subversion (svnbot) 2009-11-23 08:27:36.000-0600

Repository: asterisk
Revision: 230790

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r230790 | kpfleming | 2009-11-23 08:27:36 -0600 (Mon, 23 Nov 2009) | 19 lines

Merged revisions 230773 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r230773 | kpfleming | 2009-11-23 08:15:48 -0600 (Mon, 23 Nov 2009) | 12 lines
 
 Merged revisions 230772 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r230772 | kpfleming | 2009-11-23 08:13:56 -0600 (Mon, 23 Nov 2009) | 5 lines
   
   Ensure that SDP parsing does not ignore the last line of the SDP.
   
   (closes issue ASTERISK-15159)
   Reported by: sgimeno
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230790
By: Digium Subversion (svnbot) 2009-11-23 08:28:39.000-0600

Repository: asterisk
Revision: 230796

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r230796 | kpfleming | 2009-11-23 08:28:38 -0600 (Mon, 23 Nov 2009) | 19 lines

Merged revisions 230773 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r230773 | kpfleming | 2009-11-23 08:15:48 -0600 (Mon, 23 Nov 2009) | 12 lines
 
 Merged revisions 230772 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r230772 | kpfleming | 2009-11-23 08:13:56 -0600 (Mon, 23 Nov 2009) | 5 lines
   
   Ensure that SDP parsing does not ignore the last line of the SDP.
   
   (closes issue ASTERISK-15159)
   Reported by: sgimeno
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230796
By: Digium Subversion (svnbot) 2009-11-23 09:16:18.000-0600

Repository: asterisk
Revision: 230839

_U  branches/1.4/channels/busy_tone.h
U   branches/1.4/channels/chan_sip.c
_U  branches/1.4/channels/ring_tone.h
_U  branches/1.4/main/editline/makelist.in

------------------------------------------------------------------------
r230839 | kpfleming | 2009-11-23 09:16:17 -0600 (Mon, 23 Nov 2009) | 1 line

Correct fix for issue ASTERISK-15159... the reporter's original patch was very close to correct.
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230839
By: Digium Subversion (svnbot) 2009-11-23 09:37:56.000-0600

Repository: asterisk
Revision: 230875

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r230875 | kpfleming | 2009-11-23 09:37:56 -0600 (Mon, 23 Nov 2009) | 7 lines

When 'sip set debug' is enabled, and the last line of an incoming SIP message
is not properly newline terminated, ensure that that line is included in the
debug output.

(part of issue ASTERISK-15159)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230875
By: Digium Subversion (svnbot) 2009-11-23 09:39:56.000-0600

Repository: asterisk
Revision: 230876

_U  trunk/

------------------------------------------------------------------------
r230876 | kpfleming | 2009-11-23 09:39:55 -0600 (Mon, 23 Nov 2009) | 12 lines

Blocked revisions 230875 via svnmerge

........
 r230875 | kpfleming | 2009-11-23 09:31:02 -0600 (Mon, 23 Nov 2009) | 7 lines
 
 When 'sip set debug' is enabled, and the last line of an incoming SIP message
 is not properly newline terminated, ensure that that line is included in the
 debug output.
 
 (part of issue ASTERISK-15159)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230876
By: Digium Subversion (svnbot) 2009-11-23 09:41:10.000-0600

Repository: asterisk
Revision: 230877

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r230877 | kpfleming | 2009-11-23 09:41:09 -0600 (Mon, 23 Nov 2009) | 9 lines

Merged revisions 230839 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r230839 | kpfleming | 2009-11-23 09:09:24 -0600 (Mon, 23 Nov 2009) | 1 line
 
 Correct fix for issue ASTERISK-15159... the reporter's original patch was very close to correct.
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230877
By: Digium Subversion (svnbot) 2009-11-23 09:42:13.000-0600

Repository: asterisk
Revision: 230878

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r230878 | kpfleming | 2009-11-23 09:42:13 -0600 (Mon, 23 Nov 2009) | 16 lines

Merged revisions 230877 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r230877 | kpfleming | 2009-11-23 09:34:16 -0600 (Mon, 23 Nov 2009) | 9 lines
 
 Merged revisions 230839 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r230839 | kpfleming | 2009-11-23 09:09:24 -0600 (Mon, 23 Nov 2009) | 1 line
   
   Correct fix for issue ASTERISK-15159... the reporter's original patch was very close to correct.
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230878
By: Digium Subversion (svnbot) 2009-11-23 09:43:41.000-0600

Repository: asterisk
Revision: 230879

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r230879 | kpfleming | 2009-11-23 09:43:40 -0600 (Mon, 23 Nov 2009) | 16 lines

Merged revisions 230877 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r230877 | kpfleming | 2009-11-23 09:34:16 -0600 (Mon, 23 Nov 2009) | 9 lines
 
 Merged revisions 230839 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r230839 | kpfleming | 2009-11-23 09:09:24 -0600 (Mon, 23 Nov 2009) | 1 line
   
   Correct fix for issue ASTERISK-15159... the reporter's original patch was very close to correct.
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230879
By: Digium Subversion (svnbot) 2009-11-23 09:44:54.000-0600

Repository: asterisk
Revision: 230880

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r230880 | kpfleming | 2009-11-23 09:44:54 -0600 (Mon, 23 Nov 2009) | 16 lines

Merged revisions 230877 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r230877 | kpfleming | 2009-11-23 09:34:16 -0600 (Mon, 23 Nov 2009) | 9 lines
 
 Merged revisions 230839 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r230839 | kpfleming | 2009-11-23 09:09:24 -0600 (Mon, 23 Nov 2009) | 1 line
   
   Correct fix for issue ASTERISK-15159... the reporter's original patch was very close to correct.
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230880
By: Digium Subversion (svnbot) 2009-11-30 12:25:37.000-0600

Repository: asterisk
Revision: 231527

U   tags/1.4.27.1/channels/chan_sip.c

------------------------------------------------------------------------
r231527 | dvossel | 2009-11-30 12:25:36 -0600 (Mon, 30 Nov 2009) | 8 lines

SDP regression fix

Ensure that SDP parsing does not ignore the last line of the SDP.

(closes issue ASTERISK-15159)
Reported by: sgimeno


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231527
By: Digium Subversion (svnbot) 2009-11-30 12:26:34.000-0600

Repository: asterisk
Revision: 231533

U   tags/1.6.0.19/channels/chan_sip.c

------------------------------------------------------------------------
r231533 | dvossel | 2009-11-30 12:26:34 -0600 (Mon, 30 Nov 2009) | 8 lines

SDP regression fix

Ensure that SDP parsing does not ignore the last line of the SDP.

(closes issue ASTERISK-15159)
Reported by: sgimeno


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231533
By: Digium Subversion (svnbot) 2009-11-30 12:26:58.000-0600

Repository: asterisk
Revision: 231535

U   tags/1.6.1.11/channels/chan_sip.c

------------------------------------------------------------------------
r231535 | dvossel | 2009-11-30 12:26:58 -0600 (Mon, 30 Nov 2009) | 8 lines

SDP regression fix

Ensure that SDP parsing does not ignore the last line of the SDP.

(closes issue ASTERISK-15159)
Reported by: sgimeno


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231535