| Summary: | ASTERISK-15139: [patch] Muted user remains talking forever | ||
| Reporter: | Dmitry Andrianov (dimas) | Labels: | |
| Date Opened: | 2009-11-14 10:17:20.000-0600 | Date Closed: | 2009-12-11 17:37:59.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_meetme |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) v3-16247.patch | |
| Description: | 1. Enter meetme conference with 'T' (talker detection) option 2. start talking 3. Asterisk sends MeetmeTalking AMI event with status set to 'on' 4. Issue 'meetme mute' command 5. Asterisk sends MeetmeMute AMI event and the member is muted Technically you are not talking anymore because you are muted. However the application listening for events never received MeetmeTalking event with status set to 'off'. Also 'meetme list' continues listing you as "(talking)". The patch sends MeetmeTalking/off event right before MeetmeMute event if member was talking at the moment he was muted. The patch also re-structures code a little because otherwise I would be adding one more piece of copy&paste. | ||
| Comments: | By: Dmitry Andrianov (dimas) 2009-11-14 10:45:47.000-0600 Oops, uploadedd meetme-talking.patch too soon. Please disregard it - the v2 patch is the correct one. By: Dmitry Andrianov (dimas) 2009-11-16 04:31:49.000-0600 v2 also had a bug :( fixed in v3 By: Digium Subversion (svnbot) 2009-12-11 16:37:22.000-0600 Repository: asterisk Revision: 234379 U branches/1.4/apps/app_meetme.c ------------------------------------------------------------------------ r234379 | jpeeler | 2009-12-11 16:37:21 -0600 (Fri, 11 Dec 2009) | 11 lines Fix talking detection status after conference user is muted. This patch ensures that when a conference user is muted that the accompanying AMI Meetme talking off event is sent. Also, the meetme list output is updated to show the muted user as unmonitored. (closes issue ASTERISK-15139) Reported by: dimas Patches: v3-16247.patch uploaded by dimas (license 88) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=234379 By: Digium Subversion (svnbot) 2009-12-11 17:17:11.000-0600 Repository: asterisk Revision: 234380 _U trunk/ U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r234380 | jpeeler | 2009-12-11 17:17:10 -0600 (Fri, 11 Dec 2009) | 18 lines Merged revisions 234379 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r234379 | jpeeler | 2009-12-11 16:37:21 -0600 (Fri, 11 Dec 2009) | 11 lines Fix talking detection status after conference user is muted. This patch ensures that when a conference user is muted that the accompanying AMI Meetme talking off event is sent. Also, the meetme list output is updated to show the muted user as unmonitored. (closes issue ASTERISK-15139) Reported by: dimas Patches: v3-16247.patch uploaded by dimas (license 88) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=234380 By: Digium Subversion (svnbot) 2009-12-11 17:23:12.000-0600 Repository: asterisk Revision: 234404 _U branches/1.6.0/ U branches/1.6.0/apps/app_meetme.c ------------------------------------------------------------------------ r234404 | jpeeler | 2009-12-11 17:23:12 -0600 (Fri, 11 Dec 2009) | 25 lines Merged revisions 234380 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r234380 | jpeeler | 2009-12-11 17:17:09 -0600 (Fri, 11 Dec 2009) | 18 lines Merged revisions 234379 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r234379 | jpeeler | 2009-12-11 16:37:21 -0600 (Fri, 11 Dec 2009) | 11 lines Fix talking detection status after conference user is muted. This patch ensures that when a conference user is muted that the accompanying AMI Meetme talking off event is sent. Also, the meetme list output is updated to show the muted user as unmonitored. (closes issue ASTERISK-15139) Reported by: dimas Patches: v3-16247.patch uploaded by dimas (license 88) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=234404 By: Digium Subversion (svnbot) 2009-12-11 17:27:44.000-0600 Repository: asterisk Revision: 234426 U branches/1.6.1/apps/app_meetme.c ------------------------------------------------------------------------ r234426 | jpeeler | 2009-12-11 17:27:44 -0600 (Fri, 11 Dec 2009) | 25 lines Merged revisions 234380 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r234380 | jpeeler | 2009-12-11 17:17:09 -0600 (Fri, 11 Dec 2009) | 18 lines Merged revisions 234379 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r234379 | jpeeler | 2009-12-11 16:37:21 -0600 (Fri, 11 Dec 2009) | 11 lines Fix talking detection status after conference user is muted. This patch ensures that when a conference user is muted that the accompanying AMI Meetme talking off event is sent. Also, the meetme list output is updated to show the muted user as unmonitored. (closes issue ASTERISK-15139) Reported by: dimas Patches: v3-16247.patch uploaded by dimas (license 88) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=234426 By: Digium Subversion (svnbot) 2009-12-11 17:37:58.000-0600 Repository: asterisk Revision: 234452 _U branches/1.6.2/ U branches/1.6.2/apps/app_meetme.c ------------------------------------------------------------------------ r234452 | jpeeler | 2009-12-11 17:37:58 -0600 (Fri, 11 Dec 2009) | 25 lines Merged revisions 234380 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r234380 | jpeeler | 2009-12-11 17:17:09 -0600 (Fri, 11 Dec 2009) | 18 lines Merged revisions 234379 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r234379 | jpeeler | 2009-12-11 16:37:21 -0600 (Fri, 11 Dec 2009) | 11 lines Fix talking detection status after conference user is muted. This patch ensures that when a conference user is muted that the accompanying AMI Meetme talking off event is sent. Also, the meetme list output is updated to show the muted user as unmonitored. (closes issue ASTERISK-15139) Reported by: dimas Patches: v3-16247.patch uploaded by dimas (license 88) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=234452 | ||