[Home]

Summary:ASTERISK-15118: [patch] CDR always set disposition as NO ANSWER with .call files
Reporter:Rodrigo P. Telles (telles)Labels:
Date Opened:2009-11-11 08:38:03.000-0600Date Closed:2010-04-23 14:46:21
Priority:MinorRegression?No
Status:Closed/CompleteComponents:CDR/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) channel.patch
Description:CDR always set disposition as NO ANSWER with .call files.
If you set "unanswered=no" at cdr.conf you won't get any CDR record.

It works fine with any 1.4.X asterisk version.
All 1.6 releases has the same problem.

****** STEPS TO REPRODUCE ******

Create a simple .call file like this one:

Channel: SIP/1000
Context: local-users
Extension: out
Priority: 1
MaxRetries: 1
WaitTime: 10
RetryTime: 45
CallerID: CALLFILE <2010>

and add something like that at extensions.conf:

[local-users]
exten => out,1,Answer
exten => out,n,Playback(beep)
exten => out,n,Echo
exten => out,n,Hangup

****** ADDITIONAL INFORMATION ******

I applied the same patch used here https://issues.asterisk.org/view.php?id=14167# and the problem is gone.
Comments:By: Leif Madsen (lmadsen) 2009-11-11 08:54:19.000-0600

Assigned to mnicholson for review and comment as to why this was only applied to 1.4. Once commented, please set to an appropriate status such as Acknowledged. Thanks!
By: Leif Madsen (lmadsen) 2010-02-11 11:21:48.000-0600

Hopefully the fix here will also fix ASTERISK-15599
By: Matthew Nicholson (mnicholson) 2010-04-22 16:43:36

Setting unanswered=no should not result in CDRs for unanswered calls.  But there is a bug here.
By: Digium Subversion (svnbot) 2010-04-22 16:58:04

Repository: asterisk
Revision: 258671

_U  trunk/
U   trunk/main/cdr.c
U   trunk/main/channel.c
U   trunk/main/features.c

------------------------------------------------------------------------
r258671 | mnicholson | 2010-04-22 16:57:59 -0500 (Thu, 22 Apr 2010) | 32 lines

Merged revisions 193391,258670 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r193391 | mnicholson | 2009-05-08 16:01:25 -0500 (Fri, 08 May 2009) | 8 lines
 
 Set the proper disposition on originated calls.
 
 (closes issue ASTERISK-13296)
 Reported by: jpt
 Patches:
       call-file-missing-cdr2.diff uploaded by mnicholson (license 96)
 Tested by: dlotina, rmartinez, mnicholson
........
 r258670 | mnicholson | 2010-04-22 16:49:07 -0500 (Thu, 22 Apr 2010) | 11 lines
 
 Fix broken CDR behavior.
 
 This change allows a CDR record previously marked with disposition ANSWERED to be set as BUSY or NO ANSWER.
 
 Additionally this change partially reverts r235635 and does not set the AST_CDR_FLAG_ORIGINATED flag on CDRs generated from ast_call().  To preserve proper CDR behavior, the AST_CDR_FLAG_DIALED flag is now cleared from all brige CDRs in ast_bridge_call().
 
 (closes issue ASTERISK-15599)
 Reported by: VarnishedOtter
 Tested by: mnicholson
........

(closes issue ASTERISK-15118)
Reported by: telles
Tested by: mnicholson


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=258671
By: Digium Subversion (svnbot) 2010-04-22 17:16:00

Repository: asterisk
Revision: 258676

_U  branches/1.6.2/
U   branches/1.6.2/main/cdr.c
U   branches/1.6.2/main/channel.c
U   branches/1.6.2/main/features.c

------------------------------------------------------------------------
r258676 | mnicholson | 2010-04-22 17:15:56 -0500 (Thu, 22 Apr 2010) | 42 lines

Merged revisions 258671,258675 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r258671 | mnicholson | 2010-04-22 16:57:59 -0500 (Thu, 22 Apr 2010) | 32 lines
 
 Merged revisions 193391,258670 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r193391 | mnicholson | 2009-05-08 16:01:25 -0500 (Fri, 08 May 2009) | 8 lines
   
   Set the proper disposition on originated calls.
   
   (closes issue ASTERISK-13296)
   Reported by: jpt
   Patches:
         call-file-missing-cdr2.diff uploaded by mnicholson (license 96)
   Tested by: dlotina, rmartinez, mnicholson
 ........
   r258670 | mnicholson | 2010-04-22 16:49:07 -0500 (Thu, 22 Apr 2010) | 11 lines
   
   Fix broken CDR behavior.
   
   This change allows a CDR record previously marked with disposition ANSWERED to be set as BUSY or NO ANSWER.
   
   Additionally this change partially reverts r235635 and does not set the AST_CDR_FLAG_ORIGINATED flag on CDRs generated from ast_call().  To preserve proper CDR behavior, the AST_CDR_FLAG_DIALED flag is now cleared from all brige CDRs in ast_bridge_call().
   
   (closes issue ASTERISK-15599)
   Reported by: VarnishedOtter
   Tested by: mnicholson
 ........
 
 (closes issue ASTERISK-15118)
 Reported by: telles
 Tested by: mnicholson
................
 r258675 | mnicholson | 2010-04-22 17:11:23 -0500 (Thu, 22 Apr 2010) | 2 lines
 
 Fix previous commit.
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=258676
By: Digium Subversion (svnbot) 2010-04-22 17:24:14

Repository: asterisk
Revision: 258705

_U  branches/1.6.1/
U   branches/1.6.1/main/cdr.c
U   branches/1.6.1/main/channel.c
U   branches/1.6.1/main/features.c

------------------------------------------------------------------------
r258705 | mnicholson | 2010-04-22 17:24:10 -0500 (Thu, 22 Apr 2010) | 42 lines

Merged revisions 258671,258675 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r258671 | mnicholson | 2010-04-22 16:57:59 -0500 (Thu, 22 Apr 2010) | 32 lines
 
 Merged revisions 193391,258670 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r193391 | mnicholson | 2009-05-08 16:01:25 -0500 (Fri, 08 May 2009) | 8 lines
   
   Set the proper disposition on originated calls.
   
   (closes issue ASTERISK-13296)
   Reported by: jpt
   Patches:
         call-file-missing-cdr2.diff uploaded by mnicholson (license 96)
   Tested by: dlotina, rmartinez, mnicholson
 ........
   r258670 | mnicholson | 2010-04-22 16:49:07 -0500 (Thu, 22 Apr 2010) | 11 lines
   
   Fix broken CDR behavior.
   
   This change allows a CDR record previously marked with disposition ANSWERED to be set as BUSY or NO ANSWER.
   
   Additionally this change partially reverts r235635 and does not set the AST_CDR_FLAG_ORIGINATED flag on CDRs generated from ast_call().  To preserve proper CDR behavior, the AST_CDR_FLAG_DIALED flag is now cleared from all brige CDRs in ast_bridge_call().
   
   (closes issue ASTERISK-15599)
   Reported by: VarnishedOtter
   Tested by: mnicholson
 ........
 
 (closes issue ASTERISK-15118)
 Reported by: telles
 Tested by: mnicholson
................
 r258675 | mnicholson | 2010-04-22 17:11:23 -0500 (Thu, 22 Apr 2010) | 2 lines
 
 Fix previous commit.
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=258705
By: Digium Subversion (svnbot) 2010-04-23 14:46:20

Repository: asterisk
Revision: 258711

_U  branches/1.6.0/
U   branches/1.6.0/main/cdr.c
U   branches/1.6.0/main/channel.c
U   branches/1.6.0/main/features.c

------------------------------------------------------------------------
r258711 | mnicholson | 2010-04-23 14:46:15 -0500 (Fri, 23 Apr 2010) | 42 lines

Merged revisions 258671,258675 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r258671 | mnicholson | 2010-04-22 16:57:59 -0500 (Thu, 22 Apr 2010) | 32 lines
 
 Merged revisions 193391,258670 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r193391 | mnicholson | 2009-05-08 16:01:25 -0500 (Fri, 08 May 2009) | 8 lines
   
   Set the proper disposition on originated calls.
   
   (closes issue ASTERISK-13296)
   Reported by: jpt
   Patches:
         call-file-missing-cdr2.diff uploaded by mnicholson (license 96)
   Tested by: dlotina, rmartinez, mnicholson
 ........
   r258670 | mnicholson | 2010-04-22 16:49:07 -0500 (Thu, 22 Apr 2010) | 11 lines
   
   Fix broken CDR behavior.
   
   This change allows a CDR record previously marked with disposition ANSWERED to be set as BUSY or NO ANSWER.
   
   Additionally this change partially reverts r235635 and does not set the AST_CDR_FLAG_ORIGINATED flag on CDRs generated from ast_call().  To preserve proper CDR behavior, the AST_CDR_FLAG_DIALED flag is now cleared from all brige CDRs in ast_bridge_call().
   
   (closes issue ASTERISK-15599)
   Reported by: VarnishedOtter
   Tested by: mnicholson
 ........
 
 (closes issue ASTERISK-15118)
 Reported by: telles
 Tested by: mnicholson
................
 r258675 | mnicholson | 2010-04-22 17:11:23 -0500 (Thu, 22 Apr 2010) | 2 lines
 
 Fix previous commit.
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=258711