[Home]

Summary:ASTERISK-15104: [patch] When using ooh323h it is impossible to call when number have more than 3 number...
Reporter:Nevenchannyy Alexander (nevenchannyy)Labels:
Date Opened:2009-11-09 06:43:26.000-0600Date Closed:2010-01-08 09:22:13.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Addons/chan_ooh323
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ooh323-dial.patch
Description:When using ooh323h  it is impossible to call when number have more than 3 number...



****** ADDITIONAL INFORMATION ******

behaviorism files # cat ooh323-dial.patch

<inline patch removed by lmadsen>
Comments:By: Leif Madsen (lmadsen) 2009-11-09 08:42:49.000-0600

Please provide patches as attachments to issues and not inline as we cannot accept them that way. Thanks!
By: Leif Madsen (lmadsen) 2009-11-09 11:15:48.000-0600

Thanks for the submission!
By: Leif Madsen (lmadsen) 2009-12-22 11:26:25.000-0600

Assigned to may213 as he is now maintaining the chan_ooh323 driver.
By: Alexander Anikin (may213) 2009-12-30 16:21:40.000-0600

nevenchannyy, i think it will more correct
to change ast_copy_string(tmp, data, strlen(data)+1);
to ast_copy_string(tmp, data, sizeof(tmp));

anyway we can't copy data from one buffer to another and limit data length  based on source not destination buffer size.
please provide another patch.

this bug is fixed on trunk with "reworked" version of chan_ooh323 but patch is required for older which included in 1.4 and 1.6.


By: Digium Subversion (svnbot) 2010-01-07 15:15:49.000-0600

Repository: asterisk-addons
Revision: 1087

U   branches/1.6.2/channels/chan_ooh323.c

------------------------------------------------------------------------
r1087 | dvossel | 2010-01-07 15:15:49 -0600 (Thu, 07 Jan 2010) | 8 lines


fixes copying string using wrong length

(closes issue ASTERISK-15104)
Reported by: nevenchannyy
Patches:
     ooh323-dial.patch uploaded by nevenchannyy (license 918)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1087