Summary:	ASTERISK-15067: [patch] temporary greetings can't be erased in 1.4
Reporter:	Francesco Romano (francesco_r)	Labels:
Date Opened:	2009-11-03 04:12:37.000-0600	Date Closed:	2010-02-24 17:00:42.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail/IMAP
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) temporary_greeting_delete.patch
Description:	I know that the same bug was closed some days ago for 1.6.X (#0014949) but why was not merged in 1.4? I know that IMAP greetings are not supported in 1.4 and are stored as regular files on the filesystem, but i find absurd that temporary messages using IMAP cannot be deleted, and for me this is a bug. If you don't agree, perhaps is better to disable the temp message when using IMAP (and also ODBC), because the name itself is a contradiction. However i adapted the patch vm_tempgreeting_removal.patch available in #0014949 for my 1.4 installation and works great, so i hope you change idea :) Thank you
Comments:	By: Leif Madsen (lmadsen) 2009-11-03 08:32:25.000-0600 Assigned to jpeeler so he can determine and discuss why this wasn't merged to 1.4. By: Leif Madsen (lmadsen) 2009-11-03 08:46:06.000-0600 This is a separate issue from that which was fixed, because temporary greetings are not stored in IMAP in 1.4; they are stored on the file system. It's not that something wasn't merged down to 1.4, it was that it didn't apply there. This issue is now Ready for Testing. Please round up some people to test and confirm this patch works for them, and then we can move it to Ready for Review. By: Leif Madsen (lmadsen) 2009-11-03 08:48:13.000-0600 Could you actually supply the patch/changes you made so they can be evaluated? I set this to Ready for Testing because the comment you made suggested you had, but I see now there is no patch here. By: Jeff Peeler (jpeeler) 2009-11-03 08:50:30.000-0600 When I closed 16109, it was because I was assuming the problem didn't exist in 1.4. Now that it is known a similar problem exists there it should certainly be fixed. By: Francesco Romano (francesco_r) 2010-01-25 10:42:42.000-0600 Any news on this? By: Simon P. Ditner (spditner) 2010-02-22 15:04:45.000-0600 I ran into this too; backported patch from 14949 attached. By: Digium Subversion (svnbot) 2010-02-24 16:58:56.000-0600 Repository: asterisk Revision: 248668 U   branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r248668 | jpeeler | 2010-02-24 16:58:55 -0600 (Wed, 24 Feb 2010) | 8 lines Make deletion of temporary greetings work properly with IMAP_STORAGE This same patch was merged in 220833, but was skipped in this branch erroneously. (closes issue ASTERISK-15067) Reported by: francesco_r ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=248668 By: Digium Subversion (svnbot) 2010-02-24 17:00:41.000-0600 Repository: asterisk Revision: 248671 _U  trunk/ ------------------------------------------------------------------------ r248671 | jpeeler | 2010-02-24 17:00:40 -0600 (Wed, 24 Feb 2010) | 14 lines Blocked revisions 248668 via svnmerge ........  r248668 | jpeeler | 2010-02-24 16:58:54 -0600 (Wed, 24 Feb 2010) | 8 lines    Make deletion of temporary greetings work properly with IMAP_STORAGE    This same patch was merged in 220833, but was skipped in this branch  erroneously.    (closes issue ASTERISK-15067)  Reported by: francesco_r ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=248671