[Home]

Summary:ASTERISK-15065: Chaspy always active Option ´o´
Reporter:Bereterbide Marcelo (marhbere)Labels:
Date Opened:2009-11-02 15:45:42.000-0600Date Closed:2009-11-05 15:33:03.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_chanspy
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:In Revision: 224179 were try aply the option o, but in the IF always take the true : So only heard the outbound audio.

if (ast_test_flag(chan, OPTION_READONLY)) {
/* Option 'o' was set, so don't mix channel audio */
f = ast_audiohook_read_frame(&csth->spy_audiohook, samples, AST_AUDIOHOOK_DIRECTION_READ, AST_FORMAT_SLINEAR);
} else {
f = ast_audiohook_read_frame(&csth->spy_audiohook, samples, AST_AUDIOHOOK_DIRECTION_BOTH, AST_FORMAT_SLINEAR);
}
Comments:By: Digium Subversion (svnbot) 2009-11-05 15:28:39.000-0600

Repository: asterisk
Revision: 228189

U   trunk/apps/app_chanspy.c

------------------------------------------------------------------------
r228189 | jpeeler | 2009-11-05 15:28:38 -0600 (Thu, 05 Nov 2009) | 11 lines

Fix the fix for chanspy option o

In 224178, I assumed the uploaded patch was correct as it had received positive
feedback. The flags were being checked in the incorrect location. Upon testing
the fix this time it was also found that the flags from the dialplan weren't
being copied to the chanspy_translation_helper.

(closes issue ASTERISK-15065)
Reported by: marhbere


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=228189
By: Digium Subversion (svnbot) 2009-11-05 15:29:42.000-0600

Repository: asterisk
Revision: 228190

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_chanspy.c

------------------------------------------------------------------------
r228190 | jpeeler | 2009-11-05 15:29:42 -0600 (Thu, 05 Nov 2009) | 17 lines

Merged revisions 228189 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r228189 | jpeeler | 2009-11-05 15:23:06 -0600 (Thu, 05 Nov 2009) | 11 lines
 
 Fix the fix for chanspy option o
 
 In 224178, I assumed the uploaded patch was correct as it had received positive
 feedback. The flags were being checked in the incorrect location. Upon testing
 the fix this time it was also found that the flags from the dialplan weren't
 being copied to the chanspy_translation_helper.
 
 (closes issue ASTERISK-15065)
 Reported by: marhbere
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=228190
By: Digium Subversion (svnbot) 2009-11-05 15:30:06.000-0600

Repository: asterisk
Revision: 228192

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_chanspy.c

------------------------------------------------------------------------
r228192 | jpeeler | 2009-11-05 15:30:06 -0600 (Thu, 05 Nov 2009) | 17 lines

Merged revisions 228189 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r228189 | jpeeler | 2009-11-05 15:23:06 -0600 (Thu, 05 Nov 2009) | 11 lines
 
 Fix the fix for chanspy option o
 
 In 224178, I assumed the uploaded patch was correct as it had received positive
 feedback. The flags were being checked in the incorrect location. Upon testing
 the fix this time it was also found that the flags from the dialplan weren't
 being copied to the chanspy_translation_helper.
 
 (closes issue ASTERISK-15065)
 Reported by: marhbere
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=228192
By: Digium Subversion (svnbot) 2009-11-05 15:33:03.000-0600

Repository: asterisk
Revision: 228195

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_chanspy.c

------------------------------------------------------------------------
r228195 | jpeeler | 2009-11-05 15:33:02 -0600 (Thu, 05 Nov 2009) | 17 lines

Merged revisions 228189 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r228189 | jpeeler | 2009-11-05 15:23:06 -0600 (Thu, 05 Nov 2009) | 11 lines
 
 Fix the fix for chanspy option o
 
 In 224178, I assumed the uploaded patch was correct as it had received positive
 feedback. The flags were being checked in the incorrect location. Upon testing
 the fix this time it was also found that the flags from the dialplan weren't
 being copied to the chanspy_translation_helper.
 
 (closes issue ASTERISK-15065)
 Reported by: marhbere
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=228195