[Home]

Summary:ASTERISK-15064: [patch] Setting dialplan hint and using a global variable gives incorrect warning.
Reporter:Richard Mudgett (rmudgett)Labels:
Date Opened:2009-11-02 11:36:28.000-0600Date Closed:2009-12-04 15:15:02.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:PBX/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20091115__issue16166.diff.txt
( 1) patch_16166_v2.txt
( 2) patch_16166.txt
Description:The dialplan line:

exten => 400,hint,DAHDI/i2/${GLOBAL(PH_1)}

incorrectly complains about missing '}'.
WARNING[7876]: pbx.c:3791 pbx_substitute_variables_helper_full: Error in extension logic (missing '}')

****** ADDITIONAL INFORMATION ******

It looks like the brackets variable is not incremented when the '$' and '{' are checked together.  Searching the code for "Error in extension logic" finds two files and six locations.  Some locations increment the brackets variable and others do not.
Comments:By: Matthias Nick (mnick) 2009-11-12 11:00:51.000-0600

added a patch - ready for testing!
By: Matthias Nick (mnick) 2009-11-16 09:21:25.000-0600

talked to Richard and added a better patch _v2
By: Tilghman Lesher (tilghman) 2009-11-24 10:23:56.000-0600

In case it was not noticed, I also added a patch.
By: Digium Subversion (svnbot) 2009-12-04 11:07:06.000-0600

Repository: asterisk
Revision: 233091

U   branches/1.4/pbx/pbx_config.c

------------------------------------------------------------------------
r233091 | mnick | 2009-12-04 11:07:05 -0600 (Fri, 04 Dec 2009) | 8 lines

Parse global variables or expressions in hint extensions

Parse global variables or expressions in hint extensions. Like: exten => 400,hint,DAHDI/i2/${GLOBAL(var)}

(closes issue ASTERISK-15064)
Reported by: rmudgett
Tested by: mnick, rmudgett

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233091
By: Digium Subversion (svnbot) 2009-12-04 11:23:32.000-0600

Repository: asterisk
Revision: 233093

U   trunk/pbx/pbx_config.c

------------------------------------------------------------------------
r233093 | mnick | 2009-12-04 11:23:32 -0600 (Fri, 04 Dec 2009) | 8 lines

Parse global variables or expressions in hint extensions

Parse global variables or expressions in hint extensions. Like: exten => 400,hint,DAHDI/i2/${GLOBAL(var)}

(closes issue ASTERISK-15064)
Reported by: rmudgett
Tested by: mnick, rmudgett

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233093
By: Digium Subversion (svnbot) 2009-12-04 14:37:16.000-0600

Repository: asterisk
Revision: 233236

_U  branches/1.6.0/
U   branches/1.6.0/pbx/pbx_config.c

------------------------------------------------------------------------
r233236 | mnick | 2009-12-04 14:37:15 -0600 (Fri, 04 Dec 2009) | 15 lines

Merged revisions 233093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r233093 | mnick | 2009-12-04 11:15:47 -0600 (Fri, 04 Dec 2009) | 8 lines
 
 Parse global variables or expressions in hint extensions
 
 Parse global variables or expressions in hint extensions. Like: exten => 400,hint,DAHDI/i2/${GLOBAL(var)}
 
 (closes issue ASTERISK-15064)
 Reported by: rmudgett
 Tested by: mnick, rmudgett
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233236
By: Digium Subversion (svnbot) 2009-12-04 15:08:31.000-0600

Repository: asterisk
Revision: 233238

_U  branches/1.6.1/
U   branches/1.6.1/pbx/pbx_config.c

------------------------------------------------------------------------
r233238 | mnick | 2009-12-04 15:08:31 -0600 (Fri, 04 Dec 2009) | 15 lines

Merged revisions 233093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r233093 | mnick | 2009-12-04 11:15:47 -0600 (Fri, 04 Dec 2009) | 8 lines
 
 Parse global variables or expressions in hint extensions
 
 Parse global variables or expressions in hint extensions. Like: exten => 400,hint,DAHDI/i2/${GLOBAL(var)}
 
 (closes issue ASTERISK-15064)
 Reported by: rmudgett
 Tested by: mnick, rmudgett
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233238
By: Digium Subversion (svnbot) 2009-12-04 15:15:01.000-0600

Repository: asterisk
Revision: 233240

_U  branches/1.6.2/
U   branches/1.6.2/pbx/pbx_config.c

------------------------------------------------------------------------
r233240 | mnick | 2009-12-04 15:15:01 -0600 (Fri, 04 Dec 2009) | 15 lines

Merged revisions 233093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r233093 | mnick | 2009-12-04 11:15:47 -0600 (Fri, 04 Dec 2009) | 8 lines
 
 Parse global variables or expressions in hint extensions
 
 Parse global variables or expressions in hint extensions. Like: exten => 400,hint,DAHDI/i2/${GLOBAL(var)}
 
 (closes issue ASTERISK-15064)
 Reported by: rmudgett
 Tested by: mnick, rmudgett
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233240