Summary:	ASTERISK-15048: [patch] ExternalIVR does not return event for file when file playing is interrupted
Reporter:	David Ruggles (thedavidfactor)	Labels:
Date Opened:	2009-10-28 14:46:52	Date Closed:	2010-01-18 11:41:49.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_externalivr
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_externalivr.patch ( 1) app_externalivr2.patch ( 2) patch_16147.txt
Description:	If the autoclear option is set ExternalIVR automatically interrupts and clears the playlist upon reception of DTMF input. According to the documentation a D event should be sent for each file that is dropped from the play list. If a file is currently playing it will not be in the playlist so it will not have a D event generated for it, however it is not yet finished so there will be no F event either. I added an additional list "playinglist" that contains entries in this "limbo" state. Upon the interruption and clearing of the playlist due to a DTMF event this list will be used to create a D event for any currently playing file.
Comments:	By: David Ruggles (thedavidfactor) 2009-10-28 15:52:10 This patch is buggy. I'm sorry, please let me do some more testing and development before considering this patch. By: David Ruggles (thedavidfactor) 2009-10-28 16:04:18 Ok, I fixed the problem; there might be a better way of clearing the list then what I did. By: David Ruggles (thedavidfactor) 2009-11-06 13:31:30.000-0600 mnick, please don't implement this yet. After discussing this with another major user of app_externalivr it would be better to implement by extending the T event instead of an additional D event. I'll work up a patch and attach it. By: Matthias Nick (mnick) 2009-11-06 13:38:59.000-0600 added a patch, without having a new List and changed from 'ast_fileexists(&input[2], NULL, u->chan->language) == -1' to 'ast_fileexists(&input[2], NULL, u->chan->language) == 0' By: David Ruggles (thedavidfactor) 2009-11-10 15:12:21.000-0600 mnick, do you mind if I take this issue? By: Matthias Nick (mnick) 2009-11-10 16:38:09.000-0600 sure, feel free to By: Digium Subversion (svnbot) 2010-01-18 11:41:46.000-0600 Repository: asterisk Revision: 240969 U   trunk/apps/app_externalivr.c ------------------------------------------------------------------------ r240969 | diruggles | 2010-01-18 11:41:45 -0600 (Mon, 18 Jan 2010) | 13 lines Add notification of interrupted file Add file information to data element of T event so the file information is sent to the client when it is interrupted. Previously only notification of pending files that were dropped was sent (closes issue ASTERISK-15048) Reported by: thedavidfactor Tested by: thedavidfactor Review: https://reviewboard.asterisk.org/r/449/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=240969