[Home]

Summary:ASTERISK-15034: flags not initalized in app_softhangup, causes undefined behavoir
Reporter:Mark Murawski (kobaz)Labels:
Date Opened:2009-10-25 21:06:31Date Closed:2009-11-11 12:41:58.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_softhangup
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:patch attached.

****** ADDITIONAL INFORMATION ******

*** asterisk-1.6.0.15/apps/app_softhangup.c     2007-11-19 13:52:04.000000000 -0500
--- asterisk-1.6.0.15-custom/apps/app_softhangup.c      2009-10-25 21:56:17.000000000 -0400
***************
*** 59,65 ****
       struct ast_channel *c = NULL;
       char *cut, *opts[0];
       char name[AST_CHANNEL_NAME] = "", *parse;
!       struct ast_flags flags;
       int lenmatch;
       AST_DECLARE_APP_ARGS(args,
               AST_APP_ARG(channel);
--- 59,65 ----
       struct ast_channel *c = NULL;
       char *cut, *opts[0];
       char name[AST_CHANNEL_NAME] = "", *parse;
!       struct ast_flags flags = {0};
       int lenmatch;
       AST_DECLARE_APP_ARGS(args,
               AST_APP_ARG(channel);
Comments:By: Leif Madsen (lmadsen) 2009-10-26 08:51:08

Ideally this should really be submitted as a patch in unified diff format, but since it is so trivial, I'll leave the inline patch for now.
By: Digium Subversion (svnbot) 2009-11-11 12:19:57.000-0600

Repository: asterisk
Revision: 229460

U   trunk/apps/app_softhangup.c

------------------------------------------------------------------------
r229460 | dbrooks | 2009-11-11 12:19:56 -0600 (Wed, 11 Nov 2009) | 7 lines

Flags not initialized in app_softhangup.c, causing undefined behavior

Trivial patch [kobaz] to initialize an ast_flags = {0}

(closes issue ASTERISK-15034)
Reported by: kobaz

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=229460
By: Digium Subversion (svnbot) 2009-11-11 12:26:21.000-0600

Repository: asterisk
Revision: 229475

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_softhangup.c

------------------------------------------------------------------------
r229475 | dbrooks | 2009-11-11 12:26:20 -0600 (Wed, 11 Nov 2009) | 14 lines

Merged revisions 229460 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r229460 | dbrooks | 2009-11-11 12:13:56 -0600 (Wed, 11 Nov 2009) | 7 lines
 
 Flags not initialized in app_softhangup.c, causing undefined behavior
 
 Trivial patch [kobaz] to initialize an ast_flags = {0}
 
 (closes issue ASTERISK-15034)
 Reported by: kobaz
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=229475
By: Digium Subversion (svnbot) 2009-11-11 12:32:11.000-0600

Repository: asterisk
Revision: 229491

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_softhangup.c

------------------------------------------------------------------------
r229491 | dbrooks | 2009-11-11 12:32:10 -0600 (Wed, 11 Nov 2009) | 14 lines

Merged revisions 229460 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r229460 | dbrooks | 2009-11-11 12:13:56 -0600 (Wed, 11 Nov 2009) | 7 lines
 
 Flags not initialized in app_softhangup.c, causing undefined behavior
 
 Trivial patch [kobaz] to initialize an ast_flags = {0}
 
 (closes issue ASTERISK-15034)
 Reported by: kobaz
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=229491
By: Digium Subversion (svnbot) 2009-11-11 12:41:58.000-0600

Repository: asterisk
Revision: 229492

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_softhangup.c

------------------------------------------------------------------------
r229492 | dbrooks | 2009-11-11 12:41:57 -0600 (Wed, 11 Nov 2009) | 14 lines

Merged revisions 229460 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r229460 | dbrooks | 2009-11-11 12:13:56 -0600 (Wed, 11 Nov 2009) | 7 lines
 
 Flags not initialized in app_softhangup.c, causing undefined behavior
 
 Trivial patch [kobaz] to initialize an ast_flags = {0}
 
 (closes issue ASTERISK-15034)
 Reported by: kobaz
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=229492