[Home]

Summary:ASTERISK-15003: [patch] Add couple of useful extensions as examples
Reporter:Philip Prindeville (pprindeville)Labels:
Date Opened:2009-10-17 17:34:32Date Closed:2010-01-13 13:32:11.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/Configuration
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) extensions.conf-bug16090.patch
( 1) extensions.conf-bug16090.patch#2
( 2) extensions.conf-bugid16090.patch#3
( 3) extensions.conf-time.patch
Description:Add more examples to extensions.conf showing how to use various functionality and provide commonly useful features.
Comments:By: Tzafrir Cohen (tzafrir) 2009-10-19 11:27:10

I don't understand this dialplan.

If you have in a context:

 include => time
 include => ani

what will this context eventually have in its 's' extension?
By: Philip Prindeville (pprindeville) 2009-10-22 15:50:35

Amended as per comment above.
By: Philip Prindeville (pprindeville) 2009-11-03 13:57:44.000-0600

Updated.  Uses _X. hack (like stdexten), so no points for style awarded...
By: Leif Madsen (lmadsen) 2009-11-03 14:11:39.000-0600

Hmmm... I'm not sure how big of a fan I am of that priority number hack... I might work on that and update this patch (and the extensions.conf.sample file in general) to be a bit different.

I can see issues coming up if you don't do it quite properly...
By: Philip Prindeville (pprindeville) 2009-11-15 20:49:30.000-0600

What do you need to do to make peace with this "priority number hack"?

It's used elsewhere, so you may need to get yourself on the same page with the persons using it elsewhere (i.e. Tilgham in stdexten, etc).
By: Leif Madsen (lmadsen) 2009-11-16 10:08:21.000-0600

I just need to review it and see what I can do about updating all these hacks to something else. This has just become a lower priority as it is just documentation, and I'll get to it as soon as I can.
By: Philip Prindeville (pprindeville) 2009-11-21 16:54:59.000-0600

What about changing [stdexten] to [matchall] and allowing things like the "time" and "ani" functionality to define themselves as [matchall](+) ? (i.e. append themselves onto the end... that way they can just use 'n' as the priority, and not use actual numeric values.)
By: Leif Madsen (lmadsen) 2009-11-23 20:07:29.000-0600

Let me think about that when I'm not quite so tired, but it sounds promising.
By: Philip Prindeville (pprindeville) 2009-12-02 16:04:21.000-0600

I tried to bang on this a bit, but there are a couple of problems.

First, you need to do everything within the same extension, so the sequence (for example) of:

exten => _X.,n,Goto(stdexten-${DIALSTATUS},1)           ; Jump based on status (NOANSWER,BUSY,CHANUNAVAIL,CONGESTION,ANSWER)

exten => stdexten-NOANSWER,1,Voicemail(${mbx},u)        ; If unavailable, send to voicemail w/ unavail announce
exten => stdexten-NOANSWER,n,NoOp(Finish stdexten NOANSWER)
exten => stdexten-NOANSWER,n,Return()                   ; If they press #, return to start


would need to become:


exten => _X.,n,Goto(stdexten-${DIALSTATUS})             ; Jump based on status (NOANSWER,BUSY,CHANUNAVAIL,CONGESTION,ANSWER)

exten => _X.,n(stdexten-NOANSWER),Voicemail(${mbx},u)   ; If unavailable, send to voicemail w/ unavail announce
exten => _X.,n,NoOp(Finish stdexten NOANSWER)
exten => _X.,n,Return()                   ; If they press #, return to start

or you wouldn't be able to append to it later since the extension _X. would be interrupted by the stdexten-NOANSWER (et al) extensions.

Some might not find that palatable, so I'm not pushing this any further for now.
By: Leif Madsen (lmadsen) 2009-12-10 10:35:27.000-0600

Which of the current patches do you find most ideal? I don't think I'm going to take this further than absolutely necessary for now. What I really need to do is just go through extensions.conf.sample entirely and update it, so for now, lets stick with the same formatting and usage as what is used throughout.
By: Leif Madsen (lmadsen) 2010-01-13 12:44:14.000-0600

+exten => _X.,n,SayDigits(${CALLERID(ani)})
+exten => _X.,n,Wait(1.25)
+exten => _X.,n,SayDigits(${CALLERID(ani)})
+exten => _X.,n,Return()



Why do we say the ANI twice here?
By: Philip Prindeville (pprindeville) 2010-01-13 13:02:00.000-0600

Just in case there's noise on the line, or you need to write it down, and miss a digit.  I always repeat phone numbers so people have a chance to write them.
By: Digium Subversion (svnbot) 2010-01-13 13:31:14.000-0600

Repository: asterisk
Revision: 239834

U   trunk/configs/extensions.conf.sample

------------------------------------------------------------------------
r239834 | lmadsen | 2010-01-13 13:31:13 -0600 (Wed, 13 Jan 2010) | 8 lines

Add more examples to extensions.conf showing how to use various
functionality and provide commonly useful features.

(closes issue ASTERISK-15003)
Reported by: pprindeville
Patches:
     extensions.conf-bugid16090.patch#3 uploaded by pprindeville (license 347)
Tested by: tzafrir, pprindeville, lmadsen
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=239834
By: Digium Subversion (svnbot) 2010-01-13 13:31:37.000-0600

Repository: asterisk
Revision: 239835

_U  branches/1.6.0/
U   branches/1.6.0/configs/extensions.conf.sample

------------------------------------------------------------------------
r239835 | lmadsen | 2010-01-13 13:31:36 -0600 (Wed, 13 Jan 2010) | 16 lines

Merged revisions 239834 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r239834 | lmadsen | 2010-01-13 13:31:13 -0600 (Wed, 13 Jan 2010) | 8 lines
 
 Add more examples to extensions.conf showing how to use various
 functionality and provide commonly useful features.
 
 (closes issue ASTERISK-15003)
 Reported by: pprindeville
 Patches:
       extensions.conf-bugid16090.patch#3 uploaded by pprindeville (license 347)
 Tested by: tzafrir, pprindeville, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=239835
By: Digium Subversion (svnbot) 2010-01-13 13:31:53.000-0600

Repository: asterisk
Revision: 239836

_U  branches/1.6.1/
U   branches/1.6.1/configs/extensions.conf.sample

------------------------------------------------------------------------
r239836 | lmadsen | 2010-01-13 13:31:52 -0600 (Wed, 13 Jan 2010) | 16 lines

Merged revisions 239834 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r239834 | lmadsen | 2010-01-13 13:31:13 -0600 (Wed, 13 Jan 2010) | 8 lines
 
 Add more examples to extensions.conf showing how to use various
 functionality and provide commonly useful features.
 
 (closes issue ASTERISK-15003)
 Reported by: pprindeville
 Patches:
       extensions.conf-bugid16090.patch#3 uploaded by pprindeville (license 347)
 Tested by: tzafrir, pprindeville, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=239836
By: Digium Subversion (svnbot) 2010-01-13 13:32:10.000-0600

Repository: asterisk
Revision: 239837

_U  branches/1.6.2/
U   branches/1.6.2/configs/extensions.conf.sample

------------------------------------------------------------------------
r239837 | lmadsen | 2010-01-13 13:32:10 -0600 (Wed, 13 Jan 2010) | 16 lines

Merged revisions 239834 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r239834 | lmadsen | 2010-01-13 13:31:13 -0600 (Wed, 13 Jan 2010) | 8 lines
 
 Add more examples to extensions.conf showing how to use various
 functionality and provide commonly useful features.
 
 (closes issue ASTERISK-15003)
 Reported by: pprindeville
 Patches:
       extensions.conf-bugid16090.patch#3 uploaded by pprindeville (license 347)
 Tested by: tzafrir, pprindeville, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=239837