Summary:	ASTERISK-14966: [patch] ast_transfer will stall until hangup if called with a channel that doesn't support transfers.
Reporter:	David Woolley (davidw)	Labels:
Date Opened:	2009-12-10 11:25:15.000-0600	Date Closed:	2010-01-08 09:23:44.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) Issue_16424_trunk_234134.patch
Description:	ast_transfer sets res to 0 if there is no technology transfer function, but then tests for it to be negative before deciding to do an early exit.  As a result, it will will wait for an AST_CONTROL_TRANSFER message that will never come. ****** ADDITIONAL INFORMATION ****** The Transfer application has already checked for this condition, so this will only happen if some defensive programming is triggered.
Comments:	By: Leif Madsen (lmadsen) 2009-12-10 14:37:23.000-0600 Hey davidw, just curious if you hang out on IRC or the -dev list at all? I'm wondering if it would make more sense to eventually get you some commit access to fix these kinds of bugs on your own? Hit up russellb or myself (DocAwesome) on IRC in #asterisk-dev or #asterisk-bugs if you have a chance (or perhaps you go by something else on the asterisk-dev list?) By: Digium Subversion (svnbot) 2010-01-07 14:42:28.000-0600 Repository: asterisk Revision: 238492 U   trunk/main/channel.c ------------------------------------------------------------------------ r238492 | dvossel | 2010-01-07 14:42:28 -0600 (Thu, 07 Jan 2010) | 14 lines fixes ast_transfer stall until hangup if called with a channel that doesn't support transfers ast_transfer sets res to 0 if there is no technology transfer function, but then tests for it to be negative before deciding to do an early exit. As a result, it will will wait for an AST_CONTROL_TRANSFER message that will never come. (closes issue ASTERISK-14966) Reported by: davidw Patches:      Issue_16424_trunk_234134.patch uploaded by davidw (license 780) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=238492 By: Digium Subversion (svnbot) 2010-01-07 14:44:30.000-0600 Repository: asterisk Revision: 238493 _U  branches/1.6.2/ ------------------------------------------------------------------------ r238493 | dvossel | 2010-01-07 14:44:30 -0600 (Thu, 07 Jan 2010) | 19 lines Blocked revisions 238492 via svnmerge ........  r238492 | dvossel | 2010-01-07 14:42:27 -0600 (Thu, 07 Jan 2010) | 14 lines      fixes ast_transfer stall until hangup if called with a channel that doesn't support transfers    ast_transfer sets res to 0 if there is no technology transfer function,  but then tests for it to be negative before deciding to do an early exit.  As a result, it will will wait for an AST_CONTROL_TRANSFER message that  will never come.    (closes issue ASTERISK-14966)  Reported by: davidw  Patches:        Issue_16424_trunk_234134.patch uploaded by davidw (license 780) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=238493