Summary:	ASTERISK-14963: [patch] crash when spying - was working fine in beta2
Reporter:	Mitch Sharp (bluecrow76)	Labels:
Date Opened:	2009-10-08 11:37:14	Date Closed:	2009-11-09 11:08:58.000-0600
Priority:	Blocker	Regression?	Yes
Status:	Closed/Complete	Components:	Applications/app_chanspy
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk_1.6.2.0-rc3_app_chanspy_2009_Oct_8.txt ( 1) issue16045.diff
Description:	Didn't think this matched any of the previous app_chanspy bug reports... I just updated to rc3 last night.  In the course of the morning I discovered that running ChanSpy on another SIP extension that was bridged to an IAX2 channel will result in a crash EVERY time. If I run ChanSpy against a SIP channel that is bridged with another SIP channel there is no crash. If I run ChanSpy against an IAX2 channel that is bridged with another IAX2 channel there is no crash. This behavior was not present in beta2, which was the version I was previously running. ****** ADDITIONAL INFORMATION ****** After it started crashing, I recompiled with DONT OPTIMIZE enabled.
Comments:	By: Mitch Sharp (bluecrow76) 2009-10-08 11:38:16 Attached backtrace as "asterisk 1.6.2.0-rc3 app_chanspy 2009 Oct 8.txt" By: Leif Madsen (lmadsen) 2009-10-21 09:53:30 Marking this as a Blocker for 1.6.2.0 since it is a regression from 1.6.2.0-beta2. Thanks! By: David Vossel (dvossel) 2009-11-06 17:02:57.000-0600 I uploaded a patch.  Can you test to see if that fixes it? By: Mitch Sharp (bluecrow76) 2009-11-06 17:20:35.000-0600 Installed the patch and tested SIP<->SIP and SIP<->IAX2 chanspy from a SIP phone and experienced no crashes. More karma for you... thanks! By: Mitch Sharp (bluecrow76) 2009-11-06 17:30:25.000-0600 I don't know how I missed rc4... just noticed it.  The patch was installed against rc3. By: Chris Stone (habile) 2009-11-07 06:27:36.000-0600 This patch prevents the crash I contributed to 0015842, however I'm only getting audio from one channel, not sure why - need to check further. By: Chris Stone (habile) 2009-11-07 08:18:56.000-0600 Re-tested in 228693 - all OK. :) me happy... By: Leif Madsen (lmadsen) 2009-11-07 14:05:32.000-0600 bluecrow76: you probably missed it because I only released it on Friday afternoon (November 6th, 2009) By: Digium Subversion (svnbot) 2009-11-09 10:39:45.000-0600 Repository: asterisk Revision: 228692 U   branches/1.4/main/channel.c ------------------------------------------------------------------------ r228692 | dvossel | 2009-11-06 16:33:27 -0600 (Fri, 06 Nov 2009) | 15 lines fixes audiohook write crash occuring in chan_spy whisper mode. After writing to the audiohook list in ast_write(), frames were being freed incorrectly.  Under certain conditions this resulted in a double free crash. (closes issue ASTERISK-15037) Reported by: wetwired (closes issue ASTERISK-14963) Reported by: bluecrow76 Patches:      issue16045.diff uploaded by dvossel (license 671) Tested by: bluecrow76, dvossel, habile ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=228692 By: Digium Subversion (svnbot) 2009-11-09 11:08:57.000-0600 Repository: asterisk Revision: 228693 _U  trunk/ U   trunk/main/channel.c ------------------------------------------------------------------------ r228693 | dvossel | 2009-11-06 16:35:44 -0600 (Fri, 06 Nov 2009) | 22 lines Merged revisions 228692 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r228692 | dvossel | 2009-11-06 16:33:27 -0600 (Fri, 06 Nov 2009) | 9 lines    fixes audiohook write crash occuring in chan_spy whisper mode.    After writing to the audiohook list in ast_write(), frames  were being freed incorrectly.  Under certain conditions this  resulted in a double free crash.    (closes issue ASTERISK-15037)  Reported by: wetwired  (closes issue ASTERISK-14963)  Reported by: bluecrow76  Patches:        issue16045.diff uploaded by dvossel (license 671)  Tested by: bluecrow76, dvossel, habile ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=228693