Summary:	ASTERISK-14924: [patch] Call does not drop when caller hangs up
Reporter:	Private Name (falves11)	Labels:
Date Opened:	2009-10-01 09:02:56	Date Closed:	2009-11-25 12:01:17.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_dial
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) dial-announce-hangup-fix1.diff
Description:	The patch created by Nicholson for issue 15936 goes only half way, I mean, it is not enough. It records the moment when the callee picks up the phone, and that is wonderful, but if the caller, the originator, drops the call, the call continues on for the callee, even if the caller is long gone several minutes ago. If the callee drops the call, then the call correctly stops and gets billed. The correct way to solve this is to stop the call if either leg sends BYE, and stop the billing right there. If you need to see a live example please contact me via the information in Digium's ticket system for ticket FDI-431113
Comments:	By: Matthew Nicholson (mnicholson) 2009-10-01 09:09:49 I have verified that this is a bug. By: Matthew Nicholson (mnicholson) 2009-10-16 15:46:44 The patch I just uploaded (dial-announce-hangup-fix1.diff) should fix the issue.  The code still needs a review and there are some things I need to change before the code is ready to commit. Test it in combination with the patch from ASTERISK-14282 for best results. By: Private Name (falves11) 2009-10-17 00:32:10 I tested both patches together and they do work perfectly. The call drops as soon as one of the parties disconnect. By: Private Name (falves11) 2009-10-28 09:01:42 when are we going to commit these patches to SVN? By: Matthew Nicholson (mnicholson) 2009-10-28 09:04:23 I am waiting for some feedback on my implementation.  The patches should be committed soon. By: Digium Subversion (svnbot) 2009-11-04 14:57:56.000-0600 Repository: asterisk Revision: 227827 U   branches/1.4/apps/app_dial.c ------------------------------------------------------------------------ r227827 | mnicholson | 2009-11-04 14:57:55 -0600 (Wed, 04 Nov 2009) | 10 lines This patch modifies the Dial application to monitor the calling channel for hangups while playing back announcements. (closes issue ASTERISK-14924) Reported by: falves11 Patches:      dial-announce-hangup-fix1.diff uploaded by mnicholson (license 96) Tested by: mnicholson, falves11 Review: https://reviewboard.asterisk.org/r/407/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=227827 By: Digium Subversion (svnbot) 2009-11-04 15:09:00.000-0600 Repository: asterisk Revision: 227829 _U  trunk/ U   trunk/apps/app_dial.c ------------------------------------------------------------------------ r227829 | mnicholson | 2009-11-04 15:09:00 -0600 (Wed, 04 Nov 2009) | 17 lines Merged revisions 227827 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r227827 | mnicholson | 2009-11-04 14:52:27 -0600 (Wed, 04 Nov 2009) | 10 lines    This patch modifies the Dial application to monitor the calling channel for hangups while playing back announcements.    (closes issue ASTERISK-14924)  Reported by: falves11  Patches:        dial-announce-hangup-fix1.diff uploaded by mnicholson (license 96)  Tested by: mnicholson, falves11    Review: https://reviewboard.asterisk.org/r/407/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=227829 By: Digium Subversion (svnbot) 2009-11-04 15:14:42.000-0600 Repository: asterisk Revision: 227831 _U  branches/1.6.2/ U   branches/1.6.2/apps/app_dial.c ------------------------------------------------------------------------ r227831 | mnicholson | 2009-11-04 15:14:41 -0600 (Wed, 04 Nov 2009) | 24 lines Merged revisions 227829 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r227829 | mnicholson | 2009-11-04 15:03:33 -0600 (Wed, 04 Nov 2009) | 17 lines    Merged revisions 227827 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r227827 | mnicholson | 2009-11-04 14:52:27 -0600 (Wed, 04 Nov 2009) | 10 lines        This patch modifies the Dial application to monitor the calling channel for hangups while playing back announcements.        (closes issue ASTERISK-14924)    Reported by: falves11    Patches:          dial-announce-hangup-fix1.diff uploaded by mnicholson (license 96)    Tested by: mnicholson, falves11        Review: https://reviewboard.asterisk.org/r/407/  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=227831 By: Digium Subversion (svnbot) 2009-11-04 15:21:14.000-0600 Repository: asterisk Revision: 227832 _U  branches/1.6.1/ U   branches/1.6.1/apps/app_dial.c ------------------------------------------------------------------------ r227832 | mnicholson | 2009-11-04 15:21:14 -0600 (Wed, 04 Nov 2009) | 24 lines Merged revisions 227829 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r227829 | mnicholson | 2009-11-04 15:03:33 -0600 (Wed, 04 Nov 2009) | 17 lines    Merged revisions 227827 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r227827 | mnicholson | 2009-11-04 14:52:27 -0600 (Wed, 04 Nov 2009) | 10 lines        This patch modifies the Dial application to monitor the calling channel for hangups while playing back announcements.        (closes issue ASTERISK-14924)    Reported by: falves11    Patches:          dial-announce-hangup-fix1.diff uploaded by mnicholson (license 96)    Tested by: mnicholson, falves11        Review: https://reviewboard.asterisk.org/r/407/  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=227832 By: Digium Subversion (svnbot) 2009-11-04 15:21:17.000-0600 Repository: asterisk Revision: 227833 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_dial.c ------------------------------------------------------------------------ r227833 | mnicholson | 2009-11-04 15:21:17 -0600 (Wed, 04 Nov 2009) | 24 lines Merged revisions 227829 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r227829 | mnicholson | 2009-11-04 15:03:33 -0600 (Wed, 04 Nov 2009) | 17 lines    Merged revisions 227827 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r227827 | mnicholson | 2009-11-04 14:52:27 -0600 (Wed, 04 Nov 2009) | 10 lines        This patch modifies the Dial application to monitor the calling channel for hangups while playing back announcements.        (closes issue ASTERISK-14924)    Reported by: falves11    Patches:          dial-announce-hangup-fix1.diff uploaded by mnicholson (license 96)    Tested by: mnicholson, falves11        Review: https://reviewboard.asterisk.org/r/407/  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=227833 By: Private Name (falves11) 2009-11-18 09:53:43.000-0600 Just a question for Digium: When these changes will show in the business edition, or is there already a BE version that has them? By: Matthew Nicholson (mnicholson) 2009-11-25 12:01:17.000-0600 Digium support should be able to answer that question for you.  Please contact them.