[Home]

Summary:ASTERISK-14915: [patch] change the order for ACF registration for SMDI
Reporter:Clod Patry (junky)Labels:
Date Opened:2009-09-30 21:54:37Date Closed:2010-06-04 16:21:11
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_smdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sdmi_wait.diff
Description:
Right now, we're doing the registration for the ACF, then check the validity of the SDMI.
This results in confusion for users:

Like:
before the patch:
shooter*CLI> module load res_smdi.so
Unable to load module res_smdi.so
Command 'module load res_smdi.so' failed.
 == Registered custom function 'SMDI_MSG_RETRIEVE'
 == Registered custom function 'SMDI_MSG'
 == Parsing '/etc/asterisk/smdi.conf':   == Found
 == Unregistered custom function SMDI_MSG_RETRIEVE
 == Unregistered custom function SMDI_MSG
[Sep 30 15:44:56] NOTICE[27241]: res_smdi.c:1420 load_module: No SMDI interfaces are available to listen on, not starting SMDI listener.

Users are wondering: why do we register these 2 functions, then we are unregister them?

This patch solves that "confusion":
shooter*CLI> module load res_smdi.so
Unable to load module res_smdi.so
Command 'module load res_smdi.so' failed.
 == Parsing '/etc/asterisk/smdi.conf':   == Found
[Sep 30 15:50:56] NOTICE[29186]: res_smdi.c:1418 load_module: No SMDI interfaces are available to listen on, not starting SMDI listener.
Comments:By: Digium Subversion (svnbot) 2010-06-01 13:02:24

Repository: asterisk
Revision: 266735

U   trunk/res/res_smdi.c

------------------------------------------------------------------------
r266735 | tilghman | 2010-06-01 13:02:23 -0500 (Tue, 01 Jun 2010) | 7 lines

Don't register functions until the last possible point, so they're not unloaded unnecessarily.

(closes issue ASTERISK-14915)
Reported by: junky
Patches:
      sdmi_wait.diff uploaded by junky (license 177)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=266735
By: Digium Subversion (svnbot) 2010-06-04 16:21:10

Repository: asterisk
Revision: 268147

_U  branches/1.6.2/
U   branches/1.6.2/res/res_smdi.c

------------------------------------------------------------------------
r268147 | russell | 2010-06-04 16:21:10 -0500 (Fri, 04 Jun 2010) | 14 lines

Merged revisions 266735 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r266735 | tilghman | 2010-06-01 13:02:24 -0500 (Tue, 01 Jun 2010) | 7 lines
 
 Don't register functions until the last possible point, so they're not unloaded unnecessarily.
 
 (closes issue ASTERISK-14915)
  Reported by: junky
  Patches:
        sdmi_wait.diff uploaded by junky (license 177)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=268147