[Home]

Summary:ASTERISK-14880: [patch] sqlite3 CDRs not working after a reload
Reporter:frawd (frawd)Labels:
Date Opened:2009-09-24 08:03:30Date Closed:2009-10-09 12:31:19
Priority:MajorRegression?No
Status:Closed/CompleteComponents:CDR/cdr_sqlite3_custom
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sqlite3_asterisk14_rev220097.diff
( 1) sqlite3_rev220097.diff
Description:A module reload calls free_config() which sqlite3_closes the db, preventing CDRs to be logged there until next full restart.

Unfortunately the sqlite3_open is only done on load.

Patch adds a reload option to free_config to prevent it from closing the sqlite3 db handler. I only tried it on my backport for 1.4, not on trunk.

****** ADDITIONAL INFORMATION ******

Additional patch for those interested in cdr_sqlite3_custom backported for asterisk 1.4 (rev 220097). Yes I know it will probably never be commited, but it's really useful to me so maybe it is for someone else.
Comments:By: frawd (frawd) 2009-10-07 17:24:14

Do I need to open a review board request?
By: frawd (frawd) 2009-10-08 08:47:40

I don't really agree in classifying this bug as a 'feature' by the way, it is really a bug for us poor sqlite3 users.

Maybe better switching this to 'minor', after all there is a workaround consisting in stopping and starting asterisk instead of reloading on configuration change (pain in the A).
By: Digium Subversion (svnbot) 2009-10-09 12:18:06

Repository: asterisk
Revision: 223136

U   trunk/cdr/cdr_sqlite3_custom.c

------------------------------------------------------------------------
r223136 | mnicholson | 2009-10-09 12:18:05 -0500 (Fri, 09 Oct 2009) | 8 lines

Don't close the sqlite database when reloading.  Only close the database when unloading.

(closes issue ASTERISK-14880)
Reported by: frawd
Patches:
     sqlite3_rev220097.diff uploaded by frawd (license 610)
Tested by: frawd

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=223136
By: Digium Subversion (svnbot) 2009-10-09 12:31:12

Repository: asterisk
Revision: 223171

_U  branches/1.6.1/
U   branches/1.6.1/cdr/cdr_sqlite3_custom.c

------------------------------------------------------------------------
r223171 | mnicholson | 2009-10-09 12:31:11 -0500 (Fri, 09 Oct 2009) | 15 lines

Merged revisions 223136 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r223136 | mnicholson | 2009-10-09 12:14:38 -0500 (Fri, 09 Oct 2009) | 8 lines
 
 Don't close the sqlite database when reloading.  Only close the database when unloading.
 
 (closes issue ASTERISK-14880)
 Reported by: frawd
 Patches:
       sqlite3_rev220097.diff uploaded by frawd (license 610)
 Tested by: frawd
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=223171
By: Digium Subversion (svnbot) 2009-10-09 12:31:15

Repository: asterisk
Revision: 223172

_U  branches/1.6.0/
U   branches/1.6.0/cdr/cdr_sqlite3_custom.c

------------------------------------------------------------------------
r223172 | mnicholson | 2009-10-09 12:31:15 -0500 (Fri, 09 Oct 2009) | 15 lines

Merged revisions 223136 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r223136 | mnicholson | 2009-10-09 12:14:38 -0500 (Fri, 09 Oct 2009) | 8 lines
 
 Don't close the sqlite database when reloading.  Only close the database when unloading.
 
 (closes issue ASTERISK-14880)
 Reported by: frawd
 Patches:
       sqlite3_rev220097.diff uploaded by frawd (license 610)
 Tested by: frawd
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=223172
By: Digium Subversion (svnbot) 2009-10-09 12:31:19

Repository: asterisk
Revision: 223173

_U  branches/1.6.2/
U   branches/1.6.2/cdr/cdr_sqlite3_custom.c

------------------------------------------------------------------------
r223173 | mnicholson | 2009-10-09 12:31:18 -0500 (Fri, 09 Oct 2009) | 15 lines

Merged revisions 223136 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r223136 | mnicholson | 2009-10-09 12:14:38 -0500 (Fri, 09 Oct 2009) | 8 lines
 
 Don't close the sqlite database when reloading.  Only close the database when unloading.
 
 (closes issue ASTERISK-14880)
 Reported by: frawd
 Patches:
       sqlite3_rev220097.diff uploaded by frawd (license 610)
 Tested by: frawd
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=223173