[Home]

Summary:ASTERISK-14861: [patch] Make internal_timing on by default
Reporter:Dmitry Andrianov (dimas)Labels:
Date Opened:2009-09-22 09:45:04Date Closed:2010-05-19 12:49:47
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100519__issue15932.diff.txt
Description:Are there any reason to not have internal_timing on by default?

As I already wrote in ASTERISK-14288,
"I never understood why internal_timing is not YES by default. Everybody I know turn it on as the first thing after Asterisk installation. And I see lots of "i have bad audio" topics on forums where people eventually get advice "turn internal timing on". From the other hand, I have not seen any problem which is solved by turning that timing off.. "

Since Leif suggested me to fill an issue about the subject so here we are...

****** ADDITIONAL INFORMATION ******

I'm setting product version to 1.4.26 but AFAIK it applies to all including trunk...
Comments:By: Mark Petersen (roadkill) 2009-11-18 16:21:11.000-0600

I vote yes
as not having a timer will cause problems


By: Marek Cervenka (cervajs) 2009-11-19 08:52:10.000-0600

depends internal_timing on zaptel timer?
many people are running virtual asterisks on hypervisors (xen,..) where proper zaptel support doesnt exist
By: Leif Madsen (lmadsen) 2009-11-19 09:25:16.000-0600

I have opened a new issue which requires the code review of internal_timing to be complete per the email on the mailing list from Russell. Once that issue has been satisfied to Russell's satisfaction, then this change can go in.
By: Leif Madsen (lmadsen) 2009-11-19 09:29:01.000-0600

Added relation to the original issue which provided us the internal_timing code.
By: Jason Parker (jparker) 2010-02-10 17:21:43.000-0600

I reviewed the code and did some testing..  I think I'm satisfied with the results.

The way I see it, there are 2 ways to go about this.

1) Change Makefile to enable internal_timing in the sample asterisk.conf.
2) Enable it in code, and allow internal_timing=no to disable it. (small Makefile mod to set the default commented out to be =no)

Either should be acceptable.

If you could provide a patch here that others could test, I think it could go in fairly easily.


For trunk...I'm of the opinion that we just remove the option entirely.
By: Leif Madsen (lmadsen) 2010-02-22 15:21:04.000-0600

I'd say go ahead and do what you feel is best. It appears most people (if not everyone) is of the opinion that this being off by default is unnecessary.
By: Tilghman Lesher (tilghman) 2010-05-19 12:08:09

The issue was this:  if you had DAHDI loaded but no driver to generate timing, then it was possible to get no audio at all.  Thanks to some recent changes in DAHDI, this is no longer possible:  DAHDI will automatically generate a timing source if it is loaded and a better timing source (from hardware) is not available.
By: Tilghman Lesher (tilghman) 2010-05-19 12:36:40

I'm going with a patch that verifies that we have a sufficient version of DAHDI installed that ensures that there will be no lack of a timer.
By: Digium Subversion (svnbot) 2010-05-19 12:41:30

Repository: asterisk
Revision: 264248

U   branches/1.4/configure
U   branches/1.4/configure.ac
U   branches/1.4/include/asterisk/options.h

------------------------------------------------------------------------
r264248 | tilghman | 2010-05-19 12:41:29 -0500 (Wed, 19 May 2010) | 17 lines

Internal timing is now on by default, if you're using DAHDI 2.3 or above.

The reason for ensuring DAHDI 2.3 or above is that this version ensures that
a timer is always available, whereas in previous versions, it was possible
for DAHDI to be loaded, but have no drivers to actually generate timing.  If
internal_timing was turned on in this circumstance, a complete lack of audio
would result.  This is the reason why internal_timing was not on by default.
However, now that DAHDI ensures the availability of a timer, there is no
reason for this setting to be off (and in fact, it solves a great many initial
user problems).

(closes issue ASTERISK-14861)
Reported by: dimas
Patches:
      20100519__issue15932.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=264248
By: Digium Subversion (svnbot) 2010-05-19 12:48:32

Repository: asterisk
Revision: 264249

_U  trunk/
U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in
U   trunk/include/asterisk/options.h

------------------------------------------------------------------------
r264249 | tilghman | 2010-05-19 12:48:31 -0500 (Wed, 19 May 2010) | 24 lines

Merged revisions 264248 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r264248 | tilghman | 2010-05-19 12:41:29 -0500 (Wed, 19 May 2010) | 17 lines
 
 Internal timing is now on by default, if you're using DAHDI 2.3 or above.
 
 The reason for ensuring DAHDI 2.3 or above is that this version ensures that
 a timer is always available, whereas in previous versions, it was possible
 for DAHDI to be loaded, but have no drivers to actually generate timing.  If
 internal_timing was turned on in this circumstance, a complete lack of audio
 would result.  This is the reason why internal_timing was not on by default.
 However, now that DAHDI ensures the availability of a timer, there is no
 reason for this setting to be off (and in fact, it solves a great many initial
 user problems).
 
 (closes issue ASTERISK-14861)
  Reported by: dimas
  Patches:
        20100519__issue15932.diff.txt uploaded by tilghman (license 14)
  Tested by: tilghman
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=264249
By: Digium Subversion (svnbot) 2010-05-19 12:49:45

Repository: asterisk
Revision: 264250

_U  branches/1.6.2/
U   branches/1.6.2/configure
U   branches/1.6.2/configure.ac
U   branches/1.6.2/include/asterisk/autoconfig.h.in
U   branches/1.6.2/include/asterisk/options.h

------------------------------------------------------------------------
r264250 | tilghman | 2010-05-19 12:49:44 -0500 (Wed, 19 May 2010) | 31 lines

Merged revisions 264249 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r264249 | tilghman | 2010-05-19 12:48:31 -0500 (Wed, 19 May 2010) | 24 lines
 
 Merged revisions 264248 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r264248 | tilghman | 2010-05-19 12:41:29 -0500 (Wed, 19 May 2010) | 17 lines
   
   Internal timing is now on by default, if you're using DAHDI 2.3 or above.
   
   The reason for ensuring DAHDI 2.3 or above is that this version ensures that
   a timer is always available, whereas in previous versions, it was possible
   for DAHDI to be loaded, but have no drivers to actually generate timing.  If
   internal_timing was turned on in this circumstance, a complete lack of audio
   would result.  This is the reason why internal_timing was not on by default.
   However, now that DAHDI ensures the availability of a timer, there is no
   reason for this setting to be off (and in fact, it solves a great many initial
   user problems).
   
   (closes issue ASTERISK-14861)
    Reported by: dimas
    Patches:
          20100519__issue15932.diff.txt uploaded by tilghman (license 14)
    Tested by: tilghman
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=264250