Summary: | ASTERISK-14811: [patch] Channels that was placed in "meetme" in dialing state do not leave application in CONGESTION case | ||
Reporter: | Volnikov Ivan (ivan) | Labels: | |
Date Opened: | 2009-09-10 07:47:52 | Date Closed: | 2010-07-06 15:07:07 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_meetme |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) meetme_congestion_trunk_v1.patch ( 1) meetme_congestion_trunk_v2.patch | |
Description: | In the case of outgoing call is not completed (CONGESTION or BUSY happens) the channel stay in "meeme" application (no HANGUP happens). In the 1.6.1.x and trunk is the same. ****** ADDITIONAL INFORMATION ****** I have attached patch for trunk that can solve this problem | ||
Comments: | By: Volnikov Ivan (ivan) 2009-09-17 03:55:01 For testing please use meetme_congestion_trunk_v2.patch. The misprint happens because of which has turned out takes place to be small memory leak. But the logic is corrected. By: Digium Subversion (svnbot) 2010-07-01 10:05:42 Repository: asterisk Revision: 273354 U branches/1.4/apps/app_meetme.c ------------------------------------------------------------------------ r273354 | jpeeler | 2010-07-01 10:05:42 -0500 (Thu, 01 Jul 2010) | 12 lines Ensure channel placed in meetme in ringing state is properly hung up. An outgoing channel placed in meetme while still ringing which was then hung up would not exit meetme and the channel was not properly destroyed. Specifically checking for this scenario by looking at the appropriate control frames resolves the issue. (closes issue ASTERISK-14811) Reported by: Ivan Patches: meetme_congestion_trunk_v2.patch uploaded by Ivan (license 229) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=273354 By: Digium Subversion (svnbot) 2010-07-01 10:12:31 Repository: asterisk Revision: 273355 _U trunk/ U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r273355 | jpeeler | 2010-07-01 10:12:30 -0500 (Thu, 01 Jul 2010) | 19 lines Merged revisions 273354 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r273354 | jpeeler | 2010-07-01 10:05:43 -0500 (Thu, 01 Jul 2010) | 12 lines Ensure channel placed in meetme in ringing state is properly hung up. An outgoing channel placed in meetme while still ringing which was then hung up would not exit meetme and the channel was not properly destroyed. Specifically checking for this scenario by looking at the appropriate control frames resolves the issue. (closes issue ASTERISK-14811) Reported by: Ivan Patches: meetme_congestion_trunk_v2.patch uploaded by Ivan (license 229) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=273355 By: Digium Subversion (svnbot) 2010-07-01 10:14:41 Repository: asterisk Revision: 273356 _U branches/1.6.2/ U branches/1.6.2/apps/app_meetme.c ------------------------------------------------------------------------ r273356 | jpeeler | 2010-07-01 10:14:40 -0500 (Thu, 01 Jul 2010) | 26 lines Merged revisions 273355 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r273355 | jpeeler | 2010-07-01 10:12:31 -0500 (Thu, 01 Jul 2010) | 19 lines Merged revisions 273354 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r273354 | jpeeler | 2010-07-01 10:05:43 -0500 (Thu, 01 Jul 2010) | 12 lines Ensure channel placed in meetme in ringing state is properly hung up. An outgoing channel placed in meetme while still ringing which was then hung up would not exit meetme and the channel was not properly destroyed. Specifically checking for this scenario by looking at the appropriate control frames resolves the issue. (closes issue ASTERISK-14811) Reported by: Ivan Patches: meetme_congestion_trunk_v2.patch uploaded by Ivan (license 229) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=273356 |