[Home]

Summary:ASTERISK-14789: [patch] MP3 audio playback is distorted after applying patch for issue 15109
Reporter:99gixxer (99gixxer)Labels:
Date Opened:2009-09-08 08:24:40Date Closed:2009-09-08 13:08:03
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Addons/format_mp3
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue15850.diff1.txt
Description:I'm running asterisk 1.4.26 with asterisk-addons 1.4.9 that I patched with the fix for issue 15109 since I was seeing some random aborts.  Once patched, I started noticing that any mp3 file played with MOH was distorted.

****** ADDITIONAL INFORMATION ******

I took a closer look at the fix for issue 15109 - and the change to using the macro AST_FRAME_SET_BUFFER causes an offset of AST_FRIENDLY_OFFSET into each data frame.  However, looking at the description of the patch, it seemed that since format_mp3 didn't use AST_FRIENDLY_OFFSET, that we probably should be setting the offset to 0.  I tested out having the offset set to 0 in the macro call and there was no longer any distortion, but I wasn't sure if that was the correct way to fix this or if there was a more involved change that should be made so that mp3 supports the AST_FRIENDLY_OFFSET.

Comments:By: Russell Bryant (russell) 2009-09-08 09:22:45

I'm sort of baffled that nobody noticed this when testing the changes to format_mp3, but give this a try.
By: 99gixxer (99gixxer) 2009-09-08 11:15:27

Just finished testing it out - your patch fixes the distortion.  Thanks.
By: Digium Subversion (svnbot) 2009-09-08 13:04:35

Repository: asterisk-addons
Revision: 1027

U   branches/1.4/formats/format_mp3.c

------------------------------------------------------------------------
r1027 | russell | 2009-09-08 13:04:34 -0500 (Tue, 08 Sep 2009) | 13 lines

Fix audio problems with format_mp3.

This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue ASTERISK-14789)
Reported by: 99gixxer
Patches:
     issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1027
By: Digium Subversion (svnbot) 2009-09-08 13:06:11

Repository: asterisk-addons
Revision: 1028

U   branches/1.6.0/formats/format_mp3.c

------------------------------------------------------------------------
r1028 | russell | 2009-09-08 13:06:10 -0500 (Tue, 08 Sep 2009) | 13 lines

Fix audio problems with format_mp3.

This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue ASTERISK-14789)
Reported by: 99gixxer
Patches:
     issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1028
By: Digium Subversion (svnbot) 2009-09-08 13:06:28

Repository: asterisk-addons
Revision: 1029

U   branches/1.6.1/formats/format_mp3.c

------------------------------------------------------------------------
r1029 | russell | 2009-09-08 13:06:27 -0500 (Tue, 08 Sep 2009) | 13 lines

Fix audio problems with format_mp3.

This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue ASTERISK-14789)
Reported by: 99gixxer
Patches:
     issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1029
By: Digium Subversion (svnbot) 2009-09-08 13:06:39

Repository: asterisk-addons
Revision: 1030

U   branches/1.6.2/formats/format_mp3.c

------------------------------------------------------------------------
r1030 | russell | 2009-09-08 13:06:39 -0500 (Tue, 08 Sep 2009) | 13 lines

Fix audio problems with format_mp3.

This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue ASTERISK-14789)
Reported by: 99gixxer
Patches:
     issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1030
By: Digium Subversion (svnbot) 2009-09-08 13:08:03

Repository: asterisk
Revision: 217113

U   trunk/addons/format_mp3.c

------------------------------------------------------------------------
r217113 | russell | 2009-09-08 13:08:03 -0500 (Tue, 08 Sep 2009) | 13 lines

Fix audio problems with format_mp3.

This problem was introduced when the AST_FRIENDLY_OFFSET patch was merged.
I'm surprised that nobody noticed any trouble when testing that patch, but this
fixes the code that fills in the buffer to start filling in after the offset
portion of the buffer.

(closes issue ASTERISK-14789)
Reported by: 99gixxer
Patches:
     issue15850.diff1.txt uploaded by russell (license 2)
Tested by: 99gixxer

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217113