Summary:	ASTERISK-14759: "keepstats" directive mistakenly(?) reverted?
Reporter:	Kenneth Shumard (kshumard)	Labels:
Date Opened:	2009-09-02 18:51:56	Date Closed:	2009-11-30 10:39:32.000-0600
Priority:	Minor	Regression?	Yes
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	The "keepstats" directive was removed in r175776. Was this intentional? If not, can it be restored? If it was intentional, can the documentation be updated to reflect that it was removed? ****** ADDITIONAL INFORMATION ****** http://lists.digium.com/pipermail/asterisk-commits/2009-February/030756.html includes the commit log where this change was introduced.
Comments:	By: Tilghman Lesher (tilghman) 2009-09-02 22:38:54 Revision 175776 has no relation to trunk, and the branch associated with that revision has not been merged back to trunk.  Should this have gone directly to the developer in charge of that branch (moy), instead of being filed on the issue tracker? By: Moises Silva (moy) 2009-09-02 23:11:06 revision 175663 is the one removing that setting from app_queue.c, the revision in mfcr2 branch simply merged that change from trunk. kshumard are you using mfcr2 branch at all? if so, you should not, that branch is outdated since is already merged in trunk. By: Kenneth Shumard (kshumard) 2009-09-02 23:19:18 Hrm, my svn-fu must not be that great. :/ I don't think this is an issue for moy; I think this applies to both the 1.6.2 branch and SVN trunk. The keepstats option exists in 1.6.0 and 1.6.1, but not in 1.6.2 or trunk. Is that expected? As near as I can tell, it's not just a rename of the option -- but even if it is, the docs for 1.6.2 and -trunk are still wrong. I can try to dig deeper to figure out when this changed if necessary, but perhaps I'd best leave that to the SVN experts. ;) emma:/usr/src/ast# ls -l total 6 drwxr-xr-x 26 root root 1624 2009-08-28 10:43 asterisk-1.6.0.14 drwxr-xr-x 26 root root 1624 2009-08-28 10:49 asterisk-1.6.1.5 drwxr-xr-x 27 root root 1552 2009-08-29 11:00 asterisk-1.6.2.0-rc1 drwxr-sr-x 30 root src  1576 2009-09-02 23:11 asterisk-trunk-r215802 emma:/usr/src/ast# grep keepstats */apps/app_queue.c asterisk-1.6.0.14/apps/app_queue.c:                     if ((general_val = ast_variable_retrieve(cfg, "general", "keepstats"))) asterisk-1.6.1.5/apps/app_queue.c:                      if ((general_val = ast_variable_retrieve(cfg, "general", "keepstats"))) emma:/usr/src/ast# grep keepstats */configs/queues.conf.sample asterisk-1.6.0.14/configs/queues.conf.sample:keepstats = no asterisk-1.6.1.5/configs/queues.conf.sample:keepstats = no asterisk-1.6.2.0-rc1/configs/queues.conf.sample:keepstats = no asterisk-trunk-r215802/configs/queues.conf.sample:keepstats = no emma:/usr/src/ast# By: Leif Madsen (lmadsen) 2009-09-22 09:03:43 Acknowledging this issue for now, however we're in a state that it appears some more information may be required. Thanks! By: Jason Parker (jparker) 2009-10-07 13:00:03 This option was intentionally removed, as stats are not reset on reload anymore.  There is a "queue reset stats" CLI command that was added. I'll remove the option from the sample config in trunk/1.6.2 if it still exists there. By: Digium Subversion (svnbot) 2009-10-07 13:08:14 Repository: asterisk Revision: 222548 U   trunk/configs/queues.conf.sample ------------------------------------------------------------------------ r222548 | qwell | 2009-10-07 13:08:14 -0500 (Wed, 07 Oct 2009) | 5 lines Remove 'keepstats' queue option from sample config, as it's no longer used. (closes issue ASTERISK-14759) Reported by: kshumard ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=222548 By: Digium Subversion (svnbot) 2009-10-07 13:09:49 Repository: asterisk Revision: 222549 _U  branches/1.6.2/ U   branches/1.6.2/configs/queues.conf.sample ------------------------------------------------------------------------ r222549 | qwell | 2009-10-07 13:09:49 -0500 (Wed, 07 Oct 2009) | 12 lines Merged revisions 222548 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r222548 | qwell | 2009-10-07 13:04:56 -0500 (Wed, 07 Oct 2009) | 5 lines    Remove 'keepstats' queue option from sample config, as it's no longer used.    (closes issue ASTERISK-14759)  Reported by: kshumard ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=222549 By: Digium Subversion (svnbot) 2009-10-07 17:43:46 Repository: asterisk Revision: 222548 U   trunk/configs/queues.conf.sample ------------------------------------------------------------------------ r222548 | qwell | 2009-10-07 13:04:56 -0500 (Wed, 07 Oct 2009) | 7 lines Remove 'keepstats' queue option from sample config, as it's no longer used. https://reviewboard.asterisk.org/r/115/ (closes issue ASTERISK-14759) Reported by: kshumard ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=222548 By: Digium Subversion (svnbot) 2009-10-07 17:44:09 Repository: asterisk Revision: 222549 _U  branches/1.6.2/ U   branches/1.6.2/configs/queues.conf.sample ------------------------------------------------------------------------ r222549 | qwell | 2009-10-07 13:06:31 -0500 (Wed, 07 Oct 2009) | 14 lines Merged revisions 222548 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r222548 | qwell | 2009-10-07 13:04:56 -0500 (Wed, 07 Oct 2009) | 5 lines    Remove 'keepstats' queue option from sample config, as it's no longer used.  https://reviewboard.asterisk.org/r/115/    (closes issue ASTERISK-14759)  Reported by: kshumard ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=222549 By: Leif Madsen (lmadsen) 2009-11-30 10:05:00.000-0600 Reopened per the mailing list. By: raarts (raarts) 2009-11-30 10:11:50.000-0600 I just tested the reload function in 1.6.2.rc6. I made some calls to queue agents, that were answered, and some that were not. After that I did a reload on the CLI. This in fact *did* reset all stats. In the code you can see that in the reload() function the mask is initialized to AST_FLAGS_ALL, which of course includes QUEUE_RESET_STATS. So, yes, there now is a "queue reset stats" CLI command, but, the default action after a CLI reload is still to reset all stats. I'll upload a patch tomorrow. By: Leif Madsen (lmadsen) 2009-11-30 10:39:19.000-0600 Honestly, this sounds like you should open a separate issue for this. I'm closing this back down, so please open a new issue describing what your patch does. Thanks!