| Summary: | ASTERISK-14748: Hold Time report (reportholdtime) issue | ||
| Reporter: | Nickilo ( ThinkroSystem) (nickilo) | Labels: | |
| Date Opened: | 2009-11-02 17:23:06.000-0600 | Date Closed: | 2010-01-05 17:10:18.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) patch-unified-1.6.4.1 ( 1) patch-unified-trunk-rev-222176 | |
| Description: | When reporting hold time, the number of second has to be modulo 60 otherwise the announce can be : 2 minutes 123 seconds instead of 2 minutes 3 seconds Additionnally the file queue-minute does not exist. I hope i'm clear enough. I propose to do the following changes to /apps/app_queue.c : at line 4187 : change holdtimesecs = abs((now - qe->start)); TO holdtimesecs = abs((now - qe->start)%60); at line 4190 : change play_file(peer, qe->parent->sound_minute); TO play_file(peer, qe->parent->sound_minutes); Thank You | ||
| Comments: | By: Leif Madsen (lmadsen) 2009-11-03 08:34:05.000-0600 Could you please supply a patch as a unified diff? We can't accept patches that are placed inline within bug notes. I'm going to remove the inline suggestions. Thanks! By: Nickilo ( ThinkroSystem) (nickilo) 2009-11-03 08:39:30.000-0600 lmadsen, thank you for your answer, On which version should the patch be ? (1.6.1.4, current ... ) By: Leif Madsen (lmadsen) 2009-11-03 09:11:15.000-0600 It should probably be against trunk, and then we can merge it back down to the other versions. If you can supply multiple versions that may be useful, but for now, the latest trunk (if applicable), and the version you're experiencing the issue on (if the patch is different from trunk) would be good. Thanks! By: Nickilo ( ThinkroSystem) (nickilo) 2009-11-03 14:57:28.000-0600 I just uploaded the two diff files you asked for. I hope i made no mistake ! By: Leif Madsen (lmadsen) 2009-11-04 09:19:17.000-0600 Actually, you need to create the patches as unified diffs. If you checked out from SVN, and made changes there, then you can just do: svn diff > patch-trunk.txt Or you can use: diff -u if using separate files. By: Nickilo ( ThinkroSystem) (nickilo) 2009-11-04 09:29:10.000-0600 I hope this time my diff files are ok. Thank you for helping me. By: Leif Madsen (lmadsen) 2009-11-04 09:30:50.000-0600 Thank you for your contribution and getting back so quickly. Could you round up a couple of testers on the asterisk-users and/or asterisk-dev mailing list(s)? By: Nickilo ( ThinkroSystem) (nickilo) 2009-11-04 09:33:13.000-0600 Ok, si i first have to register to thoose mailing list ! I'm gonna do it this afternoon. You'r quick to ! By: Gerald P. (wonderg) 2009-11-28 19:53:20.000-0600 I tested the patch for 2 weeks without any problem. Thank you nickilo. Good job. By: David Vossel (dvossel) 2009-12-23 16:48:32.000-0600 The patch looks great, I'm concerned about the fact that the minute sound is missing. I'm going to investigate this before merging your fix. Thanks for the contribution. By: Digium Subversion (svnbot) 2010-01-05 17:08:51.000-0600 Repository: asterisk Revision: 237920 U trunk/apps/app_queue.c ------------------------------------------------------------------------ r237920 | dvossel | 2010-01-05 17:08:51 -0600 (Tue, 05 Jan 2010) | 16 lines fixes holdtime playback issue in app_queue When reporting hold time, the number of seconds should be mod 60. Otherwise audio playback could be something like "2 minutes 123 seconds" rather than "2 minutes 3 seconds". Also, the "minute" sound file is missing, so for the moment until that file can be created the "minutes" file is used instead. (closes issue ASTERISK-14748) Reported by: nickilo Patches: patch-unified-trunk-rev-222176 uploaded by nickilo (license ) Tested by: nickilo, wonderg ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=237920 By: Digium Subversion (svnbot) 2010-01-05 17:09:26.000-0600 Repository: asterisk Revision: 237921 _U branches/1.6.2/ U branches/1.6.2/apps/app_queue.c ------------------------------------------------------------------------ r237921 | dvossel | 2010-01-05 17:09:25 -0600 (Tue, 05 Jan 2010) | 22 lines Merged revisions 237920 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r237920 | dvossel | 2010-01-05 17:08:50 -0600 (Tue, 05 Jan 2010) | 16 lines fixes holdtime playback issue in app_queue When reporting hold time, the number of seconds should be mod 60. Otherwise audio playback could be something like "2 minutes 123 seconds" rather than "2 minutes 3 seconds". Also, the "minute" sound file is missing, so for the moment until that file can be created the "minutes" file is used instead. (closes issue ASTERISK-14748) Reported by: nickilo Patches: patch-unified-trunk-rev-222176 uploaded by nickilo (license ) Tested by: nickilo, wonderg ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=237921 By: Digium Subversion (svnbot) 2010-01-05 17:09:56.000-0600 Repository: asterisk Revision: 237922 _U branches/1.6.1/ U branches/1.6.1/apps/app_queue.c ------------------------------------------------------------------------ r237922 | dvossel | 2010-01-05 17:09:56 -0600 (Tue, 05 Jan 2010) | 22 lines Merged revisions 237920 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r237920 | dvossel | 2010-01-05 17:08:50 -0600 (Tue, 05 Jan 2010) | 16 lines fixes holdtime playback issue in app_queue When reporting hold time, the number of seconds should be mod 60. Otherwise audio playback could be something like "2 minutes 123 seconds" rather than "2 minutes 3 seconds". Also, the "minute" sound file is missing, so for the moment until that file can be created the "minutes" file is used instead. (closes issue ASTERISK-14748) Reported by: nickilo Patches: patch-unified-trunk-rev-222176 uploaded by nickilo (license ) Tested by: nickilo, wonderg ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=237922 By: Digium Subversion (svnbot) 2010-01-05 17:10:18.000-0600 Repository: asterisk Revision: 237923 _U branches/1.6.0/ U branches/1.6.0/apps/app_queue.c ------------------------------------------------------------------------ r237923 | dvossel | 2010-01-05 17:10:17 -0600 (Tue, 05 Jan 2010) | 22 lines Merged revisions 237920 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r237920 | dvossel | 2010-01-05 17:08:50 -0600 (Tue, 05 Jan 2010) | 16 lines fixes holdtime playback issue in app_queue When reporting hold time, the number of seconds should be mod 60. Otherwise audio playback could be something like "2 minutes 123 seconds" rather than "2 minutes 3 seconds". Also, the "minute" sound file is missing, so for the moment until that file can be created the "minutes" file is used instead. (closes issue ASTERISK-14748) Reported by: nickilo Patches: patch-unified-trunk-rev-222176 uploaded by nickilo (license ) Tested by: nickilo, wonderg ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=237923 | ||