| Summary: | ASTERISK-14684: [patch] Core dump in ast_bridge_call features.c line 2772 | ||
| Reporter: | Atis Lezdins (atis) | Labels: | |
| Date Opened: | 2009-08-20 11:48:17 | Date Closed: | 2009-08-20 15:38:25 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | CDR/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) ast_bridge_call_peer_cdr.patch | |
| Description: | Code checks for non-empty peer_cdr but makes use of peer->cdr. changing peer->cdr to peer_cdr solves the crash. There are also more uses of peer->cdr and chan->cdr in the same function, and it seems that at least some of them might be wrong. ****** ADDITIONAL INFORMATION ****** # 0 0x080ecb91 in ast_bridge_call (chan=0x8df8f60, peer=0x8e2b118, config=0x46621c8) at features.c:2772 2772 if (peer_cdr && !ast_tvzero(peer_cdr->answer) && ast_tvcmp(peer->cdr->answer, bridge_cdr->start) >= 0) { bt # 0 0x080ecb91 in ast_bridge_call (chan=0x8df8f60, peer=0x8e2b118, config=0x46621c8) at features.c:2772 # 1 0x0419c0d3 in try_calling (qe=0x4662700, options=0x4662658 "", announceoverride=0x466265a "", url=0x4662659 "", tries=0x46628cc, noption=0x46628c8, agi=0x0, macro=0x0, gosub=0x0, ringing=1) at app_queue.c:4517 # 2 0x041a0afe in queue_exec (chan=0x8df8f60, data=0x4662d2f "22901,rt,,,10") at app_queue.c:5456 # 3 0x0812c3e4 in pbx_exec (c=0x8df8f60, app=0x8afed90, data=0x4662d2f "22901,rt,,,10") at pbx.c:1369 # 4 0x00531966 in handle_exec (chan=0x8df8f60, agi=0x46635dc, argc=3, argv=0x4662a98) at res_agi.c:2311 # 5 0x00534c78 in agi_handle_command (chan=0x8df8f60, agi=0x46635dc, buf=0x4662d24 "EXEC", dead=0) at res_agi.c:3172 # 6 0x005355f1 in run_agi (chan=0x8df8f60, request=0x4663590 "itn_ring_ivr.php", agi=0x46635dc, pid=23194, status=0x46635d0, dead=0, argc=1, argv=0x46635f4) at res_agi.c:3328 # 7 0x00536c18 in agi_exec_full (chan=0x8df8f60, data=0x4663960 "itn_ring_ivr.php", enhanced=0, dead=0) at res_agi.c:3615 # 8 0x00536d7b in agi_exec (chan=0x8df8f60, data=0x4663960 "itn_ring_ivr.php") at res_agi.c:3649 # 9 0x0812c3e4 in pbx_exec (c=0x8df8f60, app=0x8a42938, data=0x4663960 "itn_ring_ivr.php") at pbx.c:1369 # 10 0x0083379b in realtime_exec (chan=0x8df8f60, context=0x8df91d4 "db_dnis_routing", exten=0x8df9224 "d_2943", priority=4, callerid=0x8dfaff0 "112244", data=0x8d8d155 "db_dnis_routing") at pbx_realtime.c:253 # 11 0x081361c0 in pbx_extension_helper (c=0x8df8f60, con=0x0, context=0x8df91d4 "db_dnis_routing", exten=0x8df9224 "d_2943", priority=4, label=0x0, callerid=0x8dfaff0 "112244", action=E_SPAWN, found=0x46682ec, combined_find_spawn=1) at pbx.c:4041 # 12 0x0813771f in ast_spawn_extension (c=0x8df8f60, context=0x8df91d4 "db_dnis_routing", exten=0x8df9224 "d_2943", priority=4, callerid=0x8dfaff0 "112244", found=0x46682ec, combined_find_spawn=1) at pbx.c:4507 # 13 0x08137df9 in __ast_pbx_run (c=0x8df8f60, args=0x0) at pbx.c:4597 # 14 0x08139b30 in pbx_thread (data=0x8df8f60) at pbx.c:4884 # 15 0x0818f2c6 in dummy_start (data=0x8defd48) at utils.c:968 # 16 0x00d8b45b in start_thread () from /lib/libpthread.so.0 # 17 0x00cd523e in clone () from /lib/libc.so.6 | ||
| Comments: | By: Digium Subversion (svnbot) 2009-08-20 15:30:04 Repository: asterisk Revision: 213327 U trunk/main/features.c ------------------------------------------------------------------------ r213327 | mnicholson | 2009-08-20 15:30:04 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue ASTERISK-14684) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213327 By: Digium Subversion (svnbot) 2009-08-20 15:33:40 Repository: asterisk Revision: 213339 U branches/1.4/res/res_features.c ------------------------------------------------------------------------ r213339 | mnicholson | 2009-08-20 15:33:39 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue ASTERISK-14684) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213339 By: Digium Subversion (svnbot) 2009-08-20 15:34:31 Repository: asterisk Revision: 213340 _U trunk/ ------------------------------------------------------------------------ r213340 | mnicholson | 2009-08-20 15:34:31 -0500 (Thu, 20 Aug 2009) | 13 lines Blocked revisions 213339 via svnmerge ........ r213339 | mnicholson | 2009-08-20 15:33:07 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue ASTERISK-14684) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213340 By: Digium Subversion (svnbot) 2009-08-20 15:37:02 Repository: asterisk Revision: 213346 _U branches/1.6.0/ U branches/1.6.0/main/features.c ------------------------------------------------------------------------ r213346 | mnicholson | 2009-08-20 15:37:02 -0500 (Thu, 20 Aug 2009) | 14 lines Merged revisions 213327 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r213327 | mnicholson | 2009-08-20 15:29:32 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue ASTERISK-14684) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213346 By: Digium Subversion (svnbot) 2009-08-20 15:38:16 Repository: asterisk Revision: 213349 _U branches/1.6.1/ U branches/1.6.1/main/features.c ------------------------------------------------------------------------ r213349 | mnicholson | 2009-08-20 15:38:15 -0500 (Thu, 20 Aug 2009) | 14 lines Merged revisions 213327 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r213327 | mnicholson | 2009-08-20 15:29:32 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue ASTERISK-14684) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213349 By: Digium Subversion (svnbot) 2009-08-20 15:38:25 Repository: asterisk Revision: 213350 _U branches/1.6.2/ U branches/1.6.2/main/features.c ------------------------------------------------------------------------ r213350 | mnicholson | 2009-08-20 15:38:25 -0500 (Thu, 20 Aug 2009) | 14 lines Merged revisions 213327 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r213327 | mnicholson | 2009-08-20 15:29:32 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue ASTERISK-14684) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213350 | ||