Summary:	ASTERISK-14665: app_voicemail / vm_intro_de fails to play "digits/1" because it tries to say "digits/1F"
Reporter:	Andy Brodmann (macbrody)	Labels:
Date Opened:	2009-08-17 06:57:26	Date Closed:	2011-06-07 14:10:44
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	If there is one new message in your INBOX app_voicemail tries to say "digits/1F" instead of "digits/1". So it will not tell you the number of new messages at all. in apps/app_voicemail the function vm_intro_de starts with: --- /* GERMAN syntax */ static int vm_intro_de(struct ast_channel *chan,struct vm_state *vms) {    /* Introduce messages they have */    int res;    res = ast_play_and_wait(chan, "vm-youhave");    if (!res) {        if (vms->newmessages) {            if ((vms->newmessages == 1))                res = ast_play_and_wait(chan, "digits/1F"); --- The last line does not work for me. Asterisk tries to find a file called digits/1F. I run asterisk-1.6.2-Beta4 without dahdi drivers and no other add ons. The code works if the last line reads:   res = ast_play_and_wait(chan, "digits/1");
Comments:	By: Leif Madsen (lmadsen) 2009-08-17 07:54:05 I've assigned to Tilghman just to review to make sure there isn't some reason this is '1F'. I'm sure it's just a typo though. Feel free to reassign back to me as I can take care of this. Thanks! By: Tilghman Lesher (tilghman) 2009-08-17 14:33:32 It's not a typo.  The person contributing this wanted the female version of "1", hence "1F". By: Tilghman Lesher (tilghman) 2009-08-17 14:35:57 POLICY:  if you want to change any aspect of the language translation of Asterisk, you MUST make a translation file, either in the OpenOffice.org spreadsheet format (see doc/lang/) or in the textual format found in the asterisk-sounds distribution.  No exceptions. By: Andy Brodmann (macbrody) 2009-08-17 18:10:29 Concerning the policy: I don't want to change anything. I only wanted the default distribution to run out of the box. The way app_voicemail currently is, it won't work out of the box for the German language. It only works if you have voice files ending in F, right? Which isn't the case neither for German nor English. It hasn't been like this in earlier versions, there it worked out of the box with the same samples. btw. in the Spanish language I saw an M at the end. e.g. digits/1M Wouldn't it be better to have a rule concerning the default (M/F)? Otherwise we end up in a total mixture of M/F depending on the language. By: Andy Brodmann (macbrody) 2009-08-17 18:16:29 Another thought, please correct me if I am wrong. Having the Male/Female default hardcoded in the apps code does not seem a good idea. Imagine: app_voicemail for a channel in German has Female as default, app_xyz in German may have Male as default (hardcoded too, like app_voicemail), where will we end up? By: Tilghman Lesher (tilghman) 2009-08-17 18:40:32 Given that we do not distribute German voice files, how it works is up to someone who speaks German and has contributed the changes.  Based upon the sound file, it would be my understanding that German has certain words that are masculine and words that are feminine and the numbers have to match up correctly with the given phrases. By: Tilghman Lesher (tilghman) 2009-08-17 18:46:24 Here is the relevant bugnote, by a native German speaker: ~8591 By: Tilghman Lesher (tilghman) 2009-08-17 18:55:06 I think at this point, I'm going to go ahead and say "No change required", because the linked bugnote aptly demonstrates that the "1F" is intentional and relates to using the German language in a grammatically correct way.