| Summary: | ASTERISK-14661: [patch][regression] set talker detection (T) does not work unless set talker optimization (o) is enabled. | ||
| Reporter: | Shane Young (shanermn) | Labels: | |
| Date Opened: | 2009-08-15 20:32:41 | Date Closed: | 2010-01-08 09:20:40.000-0600 |
| Priority: | Minor | Regression? | Yes |
| Status: | Closed/Complete | Components: | Applications/app_meetme |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) v1-15725.patch | |
| Description: | It appears that the talker detection can not be enabled unless the talker optimization is also turned on. Using MeetMe(1,T) should allow me to do "meetme list 1" from the CLI, however I see all the particpants as (unmonitored). Using MeetMe(1,To) I am able to do "meetme list 1" from the CLI and I do get (talking) or (not talking), as I should for each user. It does work correctly in the 1.4 versions I have tried. | ||
| Comments: | By: Jason Parker (jparker) 2009-08-20 12:40:10 This is already fixed in svn and will be in the next scheduled release. By: Shane Young (shanermn) 2009-09-22 05:16:07 Tested in Asterisk 1.6.1.6. Enabling Talker Detection is re-enabling talker optimization when it shouldn't. Using the arugments pdXM seems to have the same result as opdXM By: Bereterbide Marcelo (marhbere) 2009-11-03 16:33:00.000-0600 is right say: the option ´T´ have the same functionality that option ´o´? then the option "o" is unnecesary. Talk about 1.6.0 SVN By: Shane Young (shanermn) 2009-11-23 15:04:52.000-0600 Tested on 1.6.1.10 today. Same results. Enabling Talker Detection is re-enabling talker optimization when it shouldn't. You should be able to have Talker Detection on without having the conference "optimized". By: Shane Young (shanermn) 2009-11-23 16:46:06.000-0600 Tested on Asterisk 1.6.2.0-rc6 with the same results: Enabling Talker Detection is re-enabling talker optimization when it shouldn't. By: Dmitry Andrianov (dimas) 2009-11-23 18:15:47.000-0600 I'm curious, how you check that T re-enables talker optimization? From the code of 1.6.1.10 I see that all checks involving these flags are pretty much the same as these in 1.4.26 where these flags definitely not turn each other on. Also note that you are referring two opposite problems in the original bug report and in folowwing comments. In the bug report you are basically saying that 'T' option does not work and you have to add 'o'. While in following notes you are saying that when you use 'T' it also turns on the 'o'. It is not clear what is the current problem you are having. By: Shane Young (shanermn) 2009-11-23 19:18:46.000-0600 talker optimization treats talkers who aren't speaking as being muted, meaning (a) No encode is done on transmission and (b) Received audio that is not registered as talking is omitted If the caller is speaking softly, the optimization will not hear the caller and therefore nobody else in the conference can hear the caller. When the optimiation is turned off, the caller can be heard even if they are whispering. When you enable the T option, the behavior of the 'o' options is there as well. The T option should only set talker detection (sent to manager interface and meetme list) It's also muting channels where it does not detect audio, which it should not do. By: Shane Young (shanermn) 2009-11-23 19:21:23.000-0600 qwell said that my original issue was fixed, but it really just changed the behavior as I've described. By: Dmitry Andrianov (dimas) 2009-11-24 04:00:43.000-0600 Try the patch attached. I have not tested (I do not have any 1.6 installations) but it looks like it is the right thing. By: Shane Young (shanermn) 2009-11-24 11:02:17.000-0600 Tested on Asterisk 1.6.1.10 and it works! By: Dmitry Andrianov (dimas) 2009-11-24 11:12:05.000-0600 Great. So this should be reassigned to Russell I believe. His commit 177158 introduced the wrong condition for the 'if'. By: Shane Young (shanermn) 2009-11-24 11:18:59.000-0600 Tested on Asterisk 1.6.2.0-rc6 and it also works. By: Digium Subversion (svnbot) 2010-01-06 14:37:19.000-0600 Repository: asterisk Revision: 238181 U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r238181 | jpeeler | 2010-01-06 14:37:19 -0600 (Wed, 06 Jan 2010) | 8 lines Fix misreverting from 177158. (closes issue ASTERISK-14661) Reported by: shanermn Patches: v1-15725.patch uploaded by dimas (license 88) Tested by: shanermn ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=238181 By: Digium Subversion (svnbot) 2010-01-06 14:38:29.000-0600 Repository: asterisk Revision: 238182 _U branches/1.6.0/ U branches/1.6.0/apps/app_meetme.c ------------------------------------------------------------------------ r238182 | jpeeler | 2010-01-06 14:38:29 -0600 (Wed, 06 Jan 2010) | 15 lines Merged revisions 238181 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r238181 | jpeeler | 2010-01-06 14:37:18 -0600 (Wed, 06 Jan 2010) | 8 lines Fix misreverting from 177158. (closes issue ASTERISK-14661) Reported by: shanermn Patches: v1-15725.patch uploaded by dimas (license 88) Tested by: shanermn ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=238182 By: Digium Subversion (svnbot) 2010-01-06 14:39:27.000-0600 Repository: asterisk Revision: 238183 U branches/1.6.1/apps/app_meetme.c ------------------------------------------------------------------------ r238183 | jpeeler | 2010-01-06 14:39:27 -0600 (Wed, 06 Jan 2010) | 15 lines Merged revisions 238181 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r238181 | jpeeler | 2010-01-06 14:37:18 -0600 (Wed, 06 Jan 2010) | 8 lines Fix misreverting from 177158. (closes issue ASTERISK-14661) Reported by: shanermn Patches: v1-15725.patch uploaded by dimas (license 88) Tested by: shanermn ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=238183 By: Digium Subversion (svnbot) 2010-01-06 14:40:35.000-0600 Repository: asterisk Revision: 238185 _U branches/1.6.2/ U branches/1.6.2/apps/app_meetme.c ------------------------------------------------------------------------ r238185 | jpeeler | 2010-01-06 14:40:35 -0600 (Wed, 06 Jan 2010) | 15 lines Merged revisions 238181 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r238181 | jpeeler | 2010-01-06 14:37:18 -0600 (Wed, 06 Jan 2010) | 8 lines Fix misreverting from 177158. (closes issue ASTERISK-14661) Reported by: shanermn Patches: v1-15725.patch uploaded by dimas (license 88) Tested by: shanermn ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=238185 | ||