| Summary: | ASTERISK-14651: [patch] Asterisk won't build with curl unless curl_config is present | ||
| Reporter: | Philip Prindeville (pprindeville) | Labels: | |
| Date Opened: | 2009-08-13 14:39:36 | Date Closed: | 2009-08-27 16:50:31 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/BuildSystem |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 20090813__issue15714.diff.txt | |
| Description: | If you invoke the top-level configure with --with-curl=... or with CURL_LIB, CURL_DIR, or CURL_INCLUDE, these values are ignored. Cross-compilation environments can't always rely on scripts to give their configuration, and builders must be allowed to "nail down" paths explicitly. ****** ADDITIONAL INFORMATION ****** The script seems to use curl_config, and ignore all else. This is not cross-compilation friendly. | ||
| Comments: | By: Leif Madsen (lmadsen) 2009-08-17 12:07:32 It appears Tilghman has attached a patch for testing. Changing status. Please report back once you've tested. Thanks! By: Philip Prindeville (pprindeville) 2009-08-17 14:18:22 Tested. Builds, though uses static library even when shared is available. Not sure if that's the proper behaviour or not. By: Tilghman Lesher (tilghman) 2009-08-17 15:37:52 If it _runs_ fine with the static library, then I'm inclined to say that it's acceptable. By: Philip Prindeville (pprindeville) 2009-08-17 16:47:50 Well, on most systems it might not be a concern, but on small embedded run-from-flash systems with 256MB of RAM, you really want to use shared libraries whenever possible. By: Philip Prindeville (pprindeville) 2009-08-20 15:07:16 Although the patch merges with the 1.6.1.x tree just fine, it doesn't work: checking for curl-config... no checking whether libcurl is usable... no checking for mandatory modules: CURL LTDL... fail configure: *** configure: *** The CURL installation appears to be missing or broken. configure: *** Either correct the installation, or run configure configure: *** including --without-curl. make: *** [/home/philipp/asterisk/build_i586/asterisk-1.6.1.4/.configured] Error 1 By: Tilghman Lesher (tilghman) 2009-08-20 15:52:59 At this point, you have two options. You can: a) figure out a way to fix this in the usual autoconfy way. b) resign that it won't work and abandon efforts. We don't have the resources to pursue this ourselves, and if option b is chosen, then this will be closed as a "won't fix". By: Philip Prindeville (pprindeville) 2009-08-26 15:12:53 Confirmed with 1.6.1.4. By: Tilghman Lesher (tilghman) 2009-08-26 18:02:32 Reporter does not seem to be interested in providing a fix. Talk to the libcurl developers, if you have an issue with their methods for configuring curl. By: Philip Prindeville (pprindeville) 2009-08-26 18:19:09 Reporter only opened this bug less than two weeks ago, and reporter has stated he was working on it... along with a few other things in parallel. If it's policy that bugs be closed out as quickly as possible, then there are others that have been open far longer. I took the fix you've attached and confirmed earlier today that it does indeed work with both 1.4.26.1 and 1.6.1.4. Don't know how you missed note ASTERISK-1051902. Anyway, don't be putting words in my mouth. By: Philip Prindeville (pprindeville) 2009-08-26 18:20:01 Please commit this fix to trunk. By: Tilghman Lesher (tilghman) 2009-08-27 07:59:37 Sorry, I thought you were confirming that it was still a problem in 1.6.1, not that this fixed it in 1.6.1. By: Digium Subversion (svnbot) 2009-08-27 16:46:14 Repository: asterisk Revision: 214517 A branches/1.4/autoconf/libcurl.m4 U branches/1.4/configure U branches/1.4/configure.ac U branches/1.4/include/asterisk/autoconfig.h.in ------------------------------------------------------------------------ r214517 | tilghman | 2009-08-27 16:46:13 -0500 (Thu, 27 Aug 2009) | 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue ASTERISK-14651) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214517 By: Digium Subversion (svnbot) 2009-08-27 16:47:25 Repository: asterisk Revision: 214518 _U trunk/ A trunk/autoconf/libcurl.m4 U trunk/configure U trunk/configure.ac U trunk/include/asterisk/autoconfig.h.in ------------------------------------------------------------------------ r214518 | tilghman | 2009-08-27 16:47:24 -0500 (Thu, 27 Aug 2009) | 14 lines Merged revisions 214517 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214517 | tilghman | 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) | 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue ASTERISK-14651) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214518 By: Digium Subversion (svnbot) 2009-08-27 16:48:28 Repository: asterisk Revision: 214519 _U branches/1.6.0/ A branches/1.6.0/autoconf/libcurl.m4 U branches/1.6.0/configure U branches/1.6.0/configure.ac U branches/1.6.0/include/asterisk/autoconfig.h.in ------------------------------------------------------------------------ r214519 | tilghman | 2009-08-27 16:48:28 -0500 (Thu, 27 Aug 2009) | 21 lines Merged revisions 214518 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214518 | tilghman | 2009-08-27 16:46:46 -0500 (Thu, 27 Aug 2009) | 14 lines Merged revisions 214517 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214517 | tilghman | 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) | 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue ASTERISK-14651) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214519 By: Digium Subversion (svnbot) 2009-08-27 16:49:31 Repository: asterisk Revision: 214520 _U branches/1.6.1/ A branches/1.6.1/autoconf/libcurl.m4 U branches/1.6.1/configure U branches/1.6.1/configure.ac U branches/1.6.1/include/asterisk/autoconfig.h.in ------------------------------------------------------------------------ r214520 | tilghman | 2009-08-27 16:49:30 -0500 (Thu, 27 Aug 2009) | 21 lines Merged revisions 214518 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214518 | tilghman | 2009-08-27 16:46:46 -0500 (Thu, 27 Aug 2009) | 14 lines Merged revisions 214517 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214517 | tilghman | 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) | 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue ASTERISK-14651) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214520 By: Digium Subversion (svnbot) 2009-08-27 16:50:30 Repository: asterisk Revision: 214521 _U branches/1.6.2/ A branches/1.6.2/autoconf/libcurl.m4 U branches/1.6.2/configure U branches/1.6.2/configure.ac U branches/1.6.2/include/asterisk/autoconfig.h.in ------------------------------------------------------------------------ r214521 | tilghman | 2009-08-27 16:50:30 -0500 (Thu, 27 Aug 2009) | 21 lines Merged revisions 214518 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214518 | tilghman | 2009-08-27 16:46:46 -0500 (Thu, 27 Aug 2009) | 14 lines Merged revisions 214517 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214517 | tilghman | 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) | 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue ASTERISK-14651) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214521 | ||