[Home]

Summary:ASTERISK-14648: [patch] Only deprecated "rtp debug ip <addr>" works, not "rtp set debug ip <addr>"
Reporter:David Woolley (davidw)Labels:
Date Opened:2009-08-13 07:34:51Date Closed:2010-06-09 09:49:15
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/RTP
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 2009082800-rtpdebug.diff.txt
Description:host*CLI> rtp set debug ip 10.10.10.10
Lookup failed for 'ip'
Command 'rtp set debug ip 10.10.10.10' failed.
host*CLI> rtp debug ip 10.10.10.10                                            
RTP Debugging Enabled for IP: 10.10.10.10
host*CLI>

The reason is that both call rtp_do_debug_ip(a), but that is hard coded to only look at the third parameter:

       arg = a->argv[3];


****** ADDITIONAL INFORMATION ******

Observed on 1.6.1.0, but there are no changes in this area in a diff between this and branches/1.6.1.

[root@centos code]# svn diff http://svn.digium.com/svn/asterisk/{tags/1.6.1.0,branches/1.6.1}/main/rtp.c | grep argv
[root@centos code]#
Comments:By: Michiel van Baak (mvanbaak) 2009-08-28 04:59:03

Can you test this patch ?
Tested on 1.6.0 and applies cleanly to 1.6.1

By: David Woolley (davidw) 2009-09-07 11:54:36

Applies offset 443 on 1.6.1.0 and works for both old and new syntaxes.
By: Digium Subversion (svnbot) 2009-09-12 08:09:41

Repository: asterisk
Revision: 218107

U   trunk/res/res_rtp_asterisk.c

------------------------------------------------------------------------
r218107 | mvanbaak | 2009-09-12 08:09:40 -0500 (Sat, 12 Sep 2009) | 8 lines

use the actual given ip address for 'rtp set debug ip <foo>' instead of the word 'ip'

(closes issue ASTERISK-14648)
Reported by: davidw
Patches:
     2009082800-rtpdebug.diff.txt uploaded by mvanbaak (license 7)
Tested by: davidw

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218107
By: Digium Subversion (svnbot) 2009-09-12 08:11:41

Repository: asterisk
Revision: 218108

U   branches/1.6.0/main/rtp.c

------------------------------------------------------------------------
r218108 | mvanbaak | 2009-09-12 08:11:41 -0500 (Sat, 12 Sep 2009) | 11 lines

Use the ip for the new 'rtp set debug ip <foo>'.

Since 1.6.X still has the deprecated 'rtp debug ip <foo>'
this patch is different from the fix that went into trunk

(closes issue ASTERISK-14648)
Reported by: davidw
Patches:
     2009082800-rtpdebug.diff.txt uploaded by mvanbaak (license 7)
Tested by: davidw

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218108
By: Digium Subversion (svnbot) 2009-09-12 08:13:05

Repository: asterisk
Revision: 218109

_U  branches/1.6.0/

------------------------------------------------------------------------
r218109 | mvanbaak | 2009-09-12 08:13:05 -0500 (Sat, 12 Sep 2009) | 14 lines

Blocked revisions 218107 via svnmerge

........
 r218107 | mvanbaak | 2009-09-12 15:08:16 +0200 (Sat, 12 Sep 2009) | 8 lines
 
 use the actual given ip address for 'rtp set debug ip <foo>' instead of the word 'ip'
 
 (closes issue ASTERISK-14648)
 Reported by: davidw
 Patches:
       2009082800-rtpdebug.diff.txt uploaded by mvanbaak (license 7)
 Tested by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218109
By: Digium Subversion (svnbot) 2009-09-12 08:15:06

Repository: asterisk
Revision: 218110

_U  branches/1.6.1/

------------------------------------------------------------------------
r218110 | mvanbaak | 2009-09-12 08:15:06 -0500 (Sat, 12 Sep 2009) | 14 lines

Blocked revisions 218107 via svnmerge

........
 r218107 | mvanbaak | 2009-09-12 15:08:16 +0200 (Sat, 12 Sep 2009) | 8 lines
 
 use the actual given ip address for 'rtp set debug ip <foo>' instead of the word 'ip'
 
 (closes issue ASTERISK-14648)
 Reported by: davidw
 Patches:
       2009082800-rtpdebug.diff.txt uploaded by mvanbaak (license 7)
 Tested by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218110
By: Digium Subversion (svnbot) 2009-09-12 08:15:49

Repository: asterisk
Revision: 218111

_U  branches/1.6.2/

------------------------------------------------------------------------
r218111 | mvanbaak | 2009-09-12 08:15:48 -0500 (Sat, 12 Sep 2009) | 14 lines

Blocked revisions 218107 via svnmerge

........
 r218107 | mvanbaak | 2009-09-12 15:08:16 +0200 (Sat, 12 Sep 2009) | 8 lines
 
 use the actual given ip address for 'rtp set debug ip <foo>' instead of the word 'ip'
 
 (closes issue ASTERISK-14648)
 Reported by: davidw
 Patches:
       2009082800-rtpdebug.diff.txt uploaded by mvanbaak (license 7)
 Tested by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218111