[Home]

Summary:ASTERISK-14644: [patch] Passing the mute flag to MeetMe() makes the new user have "muted" himself, not an admin mute
Reporter:Heiko Wundram (modelnine)Labels:patch
Date Opened:2009-08-12 15:55:10Date Closed:
Priority:MajorRegression?No
Status:Open/NewComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-1.6.1.1-meetme-mute.patch
( 1) meetme-patched.diff
Description:Generally, in the scenarios I deploy app_meetme in, using a dialplan-flag for muting a joining user means that the respective user is a spectator (who can later be invited to speak), so the listener flag does not apply to this scenario.

The attached patch changes the semantics of the mute flag to mean that the user has been admin muted on joining, not self-muted, which can be reversed by simply going to his menu.

This is a change in semantics of the mute flag, which I find rather more intuitive. But adding a separate flag to make a joining user have been admin muted would similarly be sensible.
Comments:By: Leif Madsen (lmadsen) 2009-08-17 12:06:26

Since this appears to change the existing behaviour, it would probably be best if there was either an option set somewhere that would specify what the mute flag would be doing (with the default being the current behaviour) or a separate flag for this type of muting.

By: Heiko Wundram (modelnine) 2009-08-17 15:56:39

Perfectly sensible to create a new option (or rather option argument) for this, as it changes existing semantics. I'm currently testing the attached patch, which adds an option argument to m, which can either be m(a) or not. In case an 'a' is found in the option argument, an admin mute is given on connect, otherwise a normal mute.

The attached patch also includes a more comprehensive fix for ASTERISK-14641, which I can't set into relation with the patch (and so I've posted the patch there, too).

By: Leif Madsen (lmadsen) 2009-09-22 08:21:46

If you can gather some support to test this issue and have people report back here on what happened, that'll do a lot to move this issue forward. I'd suggest using the asterisk-users and/or asterisk-dev mailing lists. Thanks!