[Home]

Summary:ASTERISK-14640: regression on LAGRQ in chan_iax2 1.6.0.13
Reporter:sohosys (sohosys)Labels:
Date Opened:2009-08-12 14:12:54Date Closed:2009-08-13 08:52:04
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_iax2
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:https://issues.asterisk.org/view.php?id=15007 reports changing LOG_WARNING to LOG_DEBUG for this function, it is still LOG_WARNING in 1.6.0.13, so if it was fixed there is a regression, if not this message probably should not be a WARNING since it appears for all statically defined IAX peers with qualify enabled if they have not registered. The version selected for this report was 1.6.0.12 but the action test is on 1.6.0.13, which is not a bug report option yet.;

static int send_lagrq(const void *data);



static void __send_lagrq(const void *data)

{

       int callno = (long) data;



       ast_mutex_lock(&iaxsl[callno]);



       if (iaxs[callno]) {

               if (iaxs[callno]->peercallno) {

                       send_command(iaxs[callno], AST_FRAME_IAX, IAX_COMMAND_LAGRQ, 0, NULL, 0, -1);

                       iaxs[callno]->lagid = iax2_sched_add(sched, lagrq_time * 1000, send_lagrq, data);

               } else {

                       /* I am the schedule, so I'm allowed to do this */

                       iaxs[callno]->lagid = -1;

               }

       } else {

               ast_log(LOG_WARNING, "I was supposed to send a LAGRQ with callno %d, but no such call exists (and I cannot remove lagid, either).\n", callno);

       }



       ast_mutex_unlock(&iaxsl[callno]);

}



Comments:By: Russell Bryant (russell) 2009-08-13 08:52:03

1.6.0.13 is only a security release.  It is 1.6.0.10 plus a single security patch.  The next release which is specified to include normal bug fixes will contain the change you mentioned.  See the release summary distributed with the release for details about what is included in each release.