Summary:	ASTERISK-14628: [patch] Modify init-scripts for better Fedora compatibility
Reporter:	Itamar Reis Peixoto (itamarjp)	Labels:
Date Opened:	2009-08-10 18:19:23	Date Closed:	2011-06-07 14:08:16
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) Modify-init-scripts-for-better-Fedora-compatibility.patch
Description:	Modify init-scripts for better Fedora compatibility - don't automatic start asterisk in boot process - use /etc/sysconfig/asterisk file.
Comments:	By: Itamar Reis Peixoto (itamarjp) 2009-08-10 18:22:13 it's possible to get this patch commited ? By: Michiel van Baak (mvanbaak) 2009-08-11 03:08:20 Not yet. You're license is in 'PENDING' state so we cant even look at the file yet. We will be able to have a look at it once your license is accepted. By: Itamar Reis Peixoto (itamarjp) 2009-08-11 09:35:00 there are a way to speed up the process ? By: Itamar Reis Peixoto (itamarjp) 2009-08-11 10:25:53 license now OK By: Leif Madsen (lmadsen) 2009-09-17 15:24:19 This is now set to Ready for Testing. To move this along, please contact the asterisk-users mailing list and have a few people test and report back here. Additionally, I'm not quite sure why you don't want Asterisk to startup by default on Fedora. All the other init scripts when installed set Asterisk to start automatically, so I think we shouldn't do anything different there. By: Itamar Reis Peixoto (itamarjp) 2009-09-17 15:45:46 it`s a rule of fedora project, all program`s must not be enabled by default. this patch is already in fedora, I am only sending it to upstream because backporting thousand`s of patch`s across versions is not a easy work. I will send the mail. By: Itamar Reis Peixoto (itamarjp) 2009-09-25 19:38:52 http://cvs.fedoraproject.org/viewvc/devel/asterisk/0001-Modify-init-scripts-for-better-Fedora-compatibility.patch?revision=1.10&view=markup well it's very hard to get something commited with asterisk. :-( By: Leif Madsen (lmadsen) 2009-09-28 14:07:10 I don't understand this last comment. We have nearly 500 issues to deal with, and this is a pretty minor issue, so it will take some time to be committed. By: Paul Belanger (pabelanger) 2010-06-02 13:22:17 You'll need to update the PID file: pidfile: /var/run/asterisk/asterisk.pid By: Tilghman Lesher (tilghman) 2010-06-06 00:18:09 This patch no longer applies to trunk cleanly.  In addition, I would suggest that you conform to the existing options in contrib/init.d/etc_default_asterisk, as this file will be installed to /etc/sysconfig/asterisk on Fedora.  This ensures ease of direction across multiple distributions of Linux.  If you'd like additional options to be specified in this configuration file, we're amenable to those suggestions. By: Digium Subversion (svnbot) 2010-06-06 00:29:50 Repository: asterisk Revision: 268534 U   trunk/contrib/init.d/rc.redhat.asterisk ------------------------------------------------------------------------ r268534 | tilghman | 2010-06-06 00:29:50 -0500 (Sun, 06 Jun 2010) | 8 lines Take advantage of variable substitution already in the Makefile to specify the correct location for files in init.d. (closes issue ASTERISK-15761) Reported by: jw-asterisk (issue ASTERISK-14628) Reported by: itamarjp ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=268534 By: Digium Subversion (svnbot) 2010-06-06 00:31:11 Repository: asterisk Revision: 268535 _U  branches/1.6.2/ U   branches/1.6.2/contrib/init.d/rc.redhat.asterisk ------------------------------------------------------------------------ r268535 | tilghman | 2010-06-06 00:31:11 -0500 (Sun, 06 Jun 2010) | 15 lines Merged revisions 268534 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r268534 | tilghman | 2010-06-06 00:29:50 -0500 (Sun, 06 Jun 2010) | 8 lines    Take advantage of variable substitution already in the Makefile to specify the correct location for files in init.d.    (closes issue ASTERISK-15761)   Reported by: jw-asterisk    (issue ASTERISK-14628)   Reported by: itamarjp ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=268535 By: Paul Belanger (pabelanger) 2010-06-25 09:21:38 ping By: Paul Belanger (pabelanger) 2010-06-30 15:25:32 Suspended; reopen once you have updated your original patch. -- Suspended due to lack of activity. Please request a bug marshal in #asterisk-bugs on the IRC network irc.freenode.net to reopen the issue should you have the additional information requested. Further information can be found at http://www.asterisk.org/developers/bug-guidelines