[Home]

Summary:ASTERISK-14616: [patch] IF ELSE and WHILE braces, plus white space cleanup
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2009-08-08 04:51:18Date Closed:2009-08-14 18:08:49
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sig_analog_mainly_braces.diff.txt
Description:Other clean up was <pre>

 if (a)
   return 1;
 else
   return 2;

generally became;
 if (a) {
   return 1;
 }
 return 2;</pre>
Comments:By: Alec Davis (alecdavis) 2009-08-08 05:04:38

Testing done:

Equipment:
SIP phone and TDM800P with FXO and FXS

Calls from SIP to FXS ports, succesful, with callerid passed.
Calls into FXO from PSTN, sucessful (callerid unavailable here).
Calls from FXS port to PSTN (through FXO) succesful.
Calls from SIP to PSTN (through FXO) succesful.
By: Jeff Peeler (jpeeler) 2009-08-11 14:21:22

I said I would merge this, but actually I'm going to hold off until I can do a line by line comparison in sig_analog to make sure nothing has been forgotten. (Has already been mostly done in sig_pri.) Merging this now would just make that comparison harder.
By: Digium Subversion (svnbot) 2009-08-14 18:08:18

Repository: asterisk
Revision: 212291

U   trunk/channels/sig_analog.c

------------------------------------------------------------------------
r212291 | jpeeler | 2009-08-14 18:08:18 -0500 (Fri, 14 Aug 2009) | 8 lines

Add braces where missing and a few whitespace fixes in sig_analog

(closes issue ASTERISK-14616)
Reported by: alecdavis
Patches:
     sig_analog_mainly_braces.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=212291
By: Digium Subversion (svnbot) 2009-08-14 18:08:49

Repository: asterisk
Revision: 212292

_U  branches/1.6.2/

------------------------------------------------------------------------
r212292 | jpeeler | 2009-08-14 18:08:48 -0500 (Fri, 14 Aug 2009) | 14 lines

Blocked revisions 212291 via svnmerge

........
 r212291 | jpeeler | 2009-08-14 18:07:51 -0500 (Fri, 14 Aug 2009) | 8 lines
 
 Add braces where missing and a few whitespace fixes in sig_analog
 
 (closes issue ASTERISK-14616)
 Reported by: alecdavis
 Patches:
       sig_analog_mainly_braces.diff.txt uploaded by alecdavis (license 585)
 Tested by: alecdavis
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=212292