| Summary: | ASTERISK-14615: [patch] ringt formatting cleanup, possible bug in distintive ring | ||
| Reporter: | Alec Davis (alecdavis) | Labels: | |
| Date Opened: | 2009-08-07 21:24:28 | Date Closed: | 2011-06-07 14:10:47 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_dahdi |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) ringt-cleanup.diff.txt | |
| Description: | While cleaning up 'ringt' I came across indentation issue in distinctive ring detection. formatting changes only. diff highlights potential issue if (p->ringt) { /* should this be outside of DAHDI_IOMUX_READ */ | ||
| Comments: | By: Alec Davis (alecdavis) 2009-08-07 23:14:35 After checking with chan_zap.c from 1.2 disregard the possible bug. The ringt decrement should be within the DAHDI_IOMUX_READ section. patch needs comment '/* should this be outside of DAHDI_IOMUX_READ */ 'taken out of it, otherwise it's fine. This patch also fixes up the indentation issue. By: Jeff Peeler (jpeeler) 2009-10-07 15:14:38 Issue 15684 supersedes this one and is now closed. | ||