[Home]

Summary:ASTERISK-14608: AGENTACCEPTDTMF is incorrectly spelled as AGENTACCEPTDMTF in code to recognize channel variables.
Reporter:David Woolley (davidw)Labels:
Date Opened:2009-08-06 09:01:36Date Closed:2009-08-17 13:56:59
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_agent
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:In chan_agent.c, the spelling of the channel variable name doesn't match that used in the trace message.  The latter is more obviously correct:

tmpoptions = pbx_builtin_getvar_helper(chan, "AGENTACCEPTDMTF");
if (!ast_strlen_zero(tmpoptions)) {
p->acceptdtmf = *tmpoptions;
ast_verb(3, "Saw variable AGENTACCEPTDTMF=%s, setting acceptdtmf to: %c for Agent '%s'.\n", tmpoptions, p->acceptdtmf, p->agent);
ast_set_flag(p, AGENT_FLAG_ACCEPTDTMF);


****** ADDITIONAL INFORMATION ******

We are going to put both spellings in our code, as it is easier for us than forking the Asterisk code in anticipation of an official fix.
Comments:By: Digium Subversion (svnbot) 2009-08-17 13:50:53

Repository: asterisk
Revision: 212581

U   trunk/channels/chan_agent.c

------------------------------------------------------------------------
r212581 | seanbright | 2009-08-17 13:50:52 -0500 (Mon, 17 Aug 2009) | 5 lines

Correct spelling of AGENTACCEPTDTMF in chan_agent.

(closes issue ASTERISK-14608)
Reported by: davidw

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=212581
By: Digium Subversion (svnbot) 2009-08-17 13:51:57

Repository: asterisk
Revision: 212582

_U  branches/1.6.0/

------------------------------------------------------------------------
r212582 | seanbright | 2009-08-17 13:51:57 -0500 (Mon, 17 Aug 2009) | 11 lines

Blocked revisions 212581 via svnmerge

........
 r212581 | seanbright | 2009-08-17 14:50:24 -0400 (Mon, 17 Aug 2009) | 5 lines
 
 Correct spelling of AGENTACCEPTDTMF in chan_agent.
 
 (closes issue ASTERISK-14608)
 Reported by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=212582
By: Digium Subversion (svnbot) 2009-08-17 13:56:01

Repository: asterisk
Revision: 212583

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_agent.c

------------------------------------------------------------------------
r212583 | seanbright | 2009-08-17 13:56:01 -0500 (Mon, 17 Aug 2009) | 12 lines

Merged revisions 212581 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r212581 | seanbright | 2009-08-17 14:50:24 -0400 (Mon, 17 Aug 2009) | 5 lines
 
 Correct spelling of AGENTACCEPTDTMF in chan_agent.
 
 (closes issue ASTERISK-14608)
 Reported by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=212583
By: Digium Subversion (svnbot) 2009-08-17 13:56:59

Repository: asterisk
Revision: 212584

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_agent.c

------------------------------------------------------------------------
r212584 | seanbright | 2009-08-17 13:56:59 -0500 (Mon, 17 Aug 2009) | 12 lines

Merged revisions 212581 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r212581 | seanbright | 2009-08-17 14:50:24 -0400 (Mon, 17 Aug 2009) | 5 lines
 
 Correct spelling of AGENTACCEPTDTMF in chan_agent.
 
 (closes issue ASTERISK-14608)
 Reported by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=212584