| Summary: | ASTERISK-14602: ChanSpy "whisper" is broken in 1.4.26 | ||
| Reporter: | Andrey Solovyev (corruptor) | Labels: | |
| Date Opened: | 2009-08-05 09:03:15 | Date Closed: | 2009-11-09 15:05:57.000-0600 |
| Priority: | Blocker | Regression? | Yes |
| Status: | Closed/Complete | Components: | Applications/app_chanspy |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | ChanSpy "w" option works fine in 1.4.25 but it doesn't in 1.4.26. Spying channel can't talk to spied-on channel it can only listen. | ||
| Comments: | By: David Vossel (dvossel) 2009-08-19 17:24:59 I can confirm this happens in the latest Trunk code as well. By: David Vossel (dvossel) 2009-08-19 19:04:44 this broke with r200911 in 1.4 By: Matt D (calcop) 2009-08-21 22:33:21 I can confirm that as well. I first experiecned a delayed whisper in 1.6. After updating to the most recent svn, now it doesn't work at all. By: Digium Subversion (svnbot) 2009-08-26 11:37:20 Repository: asterisk Revision: 214194 U branches/1.4/main/channel.c ------------------------------------------------------------------------ r214194 | dvossel | 2009-08-26 11:37:20 -0500 (Wed, 26 Aug 2009) | 19 lines ast_write() ignores ast_audiohook_write() results In ast_write(), if a channel has a list of audiohooks, those lists are written to and the resulting frame is what ast_write() should continue with. The problem was the returned audiohook frame was not being handled at all, and the original frame passed into it did not contain the mixed audio, so essentially audio was being lost. One result of this was chan_spy's whisper mode no longer worked. To complicate the issue, frames passed into ast_write may either be a single frame, or a list of frames. So, as the list of frames is processed in the audiohook_write, the returned frames had to be added to a new list. (closes issue ASTERISK-14602) Reported by: corruptor Tested by: dvossel ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214194 By: Digium Subversion (svnbot) 2009-08-26 11:39:31 Repository: asterisk Revision: 214195 _U trunk/ U trunk/main/channel.c ------------------------------------------------------------------------ r214195 | dvossel | 2009-08-26 11:39:31 -0500 (Wed, 26 Aug 2009) | 25 lines Merged revisions 214194 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214194 | dvossel | 2009-08-26 11:36:42 -0500 (Wed, 26 Aug 2009) | 19 lines ast_write() ignores ast_audiohook_write() results In ast_write(), if a channel has a list of audiohooks, those lists are written to and the resulting frame is what ast_write() should continue with. The problem was the returned audiohook frame was not being handled at all, and the original frame passed into it did not contain the mixed audio, so essentially audio was being lost. One result of this was chan_spy's whisper mode no longer worked. To complicate the issue, frames passed into ast_write may either be a single frame, or a list of frames. So, as the list of frames is processed in the audiohook_write, the returned frames had to be added to a new list. (closes issue ASTERISK-14602) Reported by: corruptor Tested by: dvossel ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214195 By: Digium Subversion (svnbot) 2009-08-26 11:40:18 Repository: asterisk Revision: 214196 _U branches/1.6.2/ U branches/1.6.2/main/channel.c ------------------------------------------------------------------------ r214196 | dvossel | 2009-08-26 11:40:18 -0500 (Wed, 26 Aug 2009) | 32 lines Merged revisions 214195 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214195 | dvossel | 2009-08-26 11:38:53 -0500 (Wed, 26 Aug 2009) | 25 lines Merged revisions 214194 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214194 | dvossel | 2009-08-26 11:36:42 -0500 (Wed, 26 Aug 2009) | 19 lines ast_write() ignores ast_audiohook_write() results In ast_write(), if a channel has a list of audiohooks, those lists are written to and the resulting frame is what ast_write() should continue with. The problem was the returned audiohook frame was not being handled at all, and the original frame passed into it did not contain the mixed audio, so essentially audio was being lost. One result of this was chan_spy's whisper mode no longer worked. To complicate the issue, frames passed into ast_write may either be a single frame, or a list of frames. So, as the list of frames is processed in the audiohook_write, the returned frames had to be added to a new list. (closes issue ASTERISK-14602) Reported by: corruptor Tested by: dvossel ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214196 By: Digium Subversion (svnbot) 2009-08-26 11:40:56 Repository: asterisk Revision: 214197 _U branches/1.6.1/ U branches/1.6.1/main/channel.c ------------------------------------------------------------------------ r214197 | dvossel | 2009-08-26 11:40:56 -0500 (Wed, 26 Aug 2009) | 32 lines Merged revisions 214195 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214195 | dvossel | 2009-08-26 11:38:53 -0500 (Wed, 26 Aug 2009) | 25 lines Merged revisions 214194 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214194 | dvossel | 2009-08-26 11:36:42 -0500 (Wed, 26 Aug 2009) | 19 lines ast_write() ignores ast_audiohook_write() results In ast_write(), if a channel has a list of audiohooks, those lists are written to and the resulting frame is what ast_write() should continue with. The problem was the returned audiohook frame was not being handled at all, and the original frame passed into it did not contain the mixed audio, so essentially audio was being lost. One result of this was chan_spy's whisper mode no longer worked. To complicate the issue, frames passed into ast_write may either be a single frame, or a list of frames. So, as the list of frames is processed in the audiohook_write, the returned frames had to be added to a new list. (closes issue ASTERISK-14602) Reported by: corruptor Tested by: dvossel ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214197 By: Digium Subversion (svnbot) 2009-08-26 11:41:28 Repository: asterisk Revision: 214198 _U branches/1.6.0/ U branches/1.6.0/main/channel.c ------------------------------------------------------------------------ r214198 | dvossel | 2009-08-26 11:41:28 -0500 (Wed, 26 Aug 2009) | 32 lines Merged revisions 214195 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214195 | dvossel | 2009-08-26 11:38:53 -0500 (Wed, 26 Aug 2009) | 25 lines Merged revisions 214194 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214194 | dvossel | 2009-08-26 11:36:42 -0500 (Wed, 26 Aug 2009) | 19 lines ast_write() ignores ast_audiohook_write() results In ast_write(), if a channel has a list of audiohooks, those lists are written to and the resulting frame is what ast_write() should continue with. The problem was the returned audiohook frame was not being handled at all, and the original frame passed into it did not contain the mixed audio, so essentially audio was being lost. One result of this was chan_spy's whisper mode no longer worked. To complicate the issue, frames passed into ast_write may either be a single frame, or a list of frames. So, as the list of frames is processed in the audiohook_write, the returned frames had to be added to a new list. (closes issue ASTERISK-14602) Reported by: corruptor Tested by: dvossel ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214198 | ||