[Home]

Summary:ASTERISK-14575: [patch] Vietnamese support for SayNumber() function.
Reporter:Nguyen Dinh Trung (dinhtrung)Labels:
Date Opened:2009-07-31 15:31:11Date Closed:2009-12-30 16:41:25.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) say.c.diff
( 1) say.c.patch
Description:Hi, I have successfully add another function for Vietnamese : SayNumber().
There are some minor changes in the way we Vietnamese speak numbers.
For examples:
- 1050 = 1 + thousand + 0 + hundred + 50 (in English : 1 + thousand + 50). I used the file 0-hundred.wav for this.
- 1007 = 1 + thousand + 0 + hundred + odd + 7 (the file odd.wav can have another meaning, not only on the contrary with "even". We usually add "odd" if the number has 2 "0" in the middle, like 2008, 3004... I used the file 0-hundred-odd.wav for this.
- For the last number, if it's a 5, then if the number before it is not a 0, we will use another word for it. E.g, 25 is not 20 + 5, but 20 + 5l. So is 15, 35, 45, 55... But 05 is 5. So I add another sound file named 5l.wav here to separate this.

I hope this will help Asterisk better support Vietnamese.

Sorry for my bad English.
Comments:By: Nguyen Dinh Trung (dinhtrung) 2009-11-23 09:52:32.000-0600

Update the patch for Asterisk 1.6.2rc6

By: Jason Parker (jparker) 2009-12-07 16:51:55.000-0600

The patch needs to be against svn trunk.

Also, can you take a look at the OpenDocument files in doc/lang/?  It would be very useful to document the prompts that are used, like those do (the third column is what the sound files say in the appropriate language - in your case, Vietnamese).

By: Jason Parker (jparker) 2009-12-07 16:55:10.000-0600

My apologies - I didn't see the .ods file in 15053.  That should satisfy my second sentence above.

By: Digium Subversion (svnbot) 2009-12-30 16:30:25.000-0600

Repository: asterisk
Revision: 237050

U   trunk/apps/app_voicemail.c
A   trunk/doc/lang/vietnamese.ods
U   trunk/main/say.c

------------------------------------------------------------------------
r237050 | qwell | 2009-12-30 16:30:22 -0600 (Wed, 30 Dec 2009) | 17 lines

Add app_voicemail and say.c support for Vietnamese.

Also add an XXX comment that I'm baffled nobody has ever complained about.  We
say "first message", and then we go into language-specific stuff where we
proceed to say..."first message".

(closes issue ASTERISK-14086)
Reported by: dinhtrung
Patches:
     vietnamese.ods uploaded by dinhtrung (license 776)
     app_voicemail.c.diff uploaded by dinhtrung (license 776)

(closes issue ASTERISK-14575)
Reported by: dinhtrung
Patches:
     say.c.diff uploaded by dinhtrung (license 776)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237050

By: Digium Subversion (svnbot) 2009-12-30 16:40:56.000-0600

Repository: asterisk
Revision: 237060

_U  branches/1.6.0/

------------------------------------------------------------------------
r237060 | qwell | 2009-12-30 16:40:54 -0600 (Wed, 30 Dec 2009) | 23 lines

Blocked revisions 237050 via svnmerge

........
 r237050 | qwell | 2009-12-30 16:30:21 -0600 (Wed, 30 Dec 2009) | 17 lines
 
 Add app_voicemail and say.c support for Vietnamese.
 
 Also add an XXX comment that I'm baffled nobody has ever complained about.  We
 say "first message", and then we go into language-specific stuff where we
 proceed to say..."first message".
 
 (closes issue ASTERISK-14086)
 Reported by: dinhtrung
 Patches:
       vietnamese.ods uploaded by dinhtrung (license 776)
       app_voicemail.c.diff uploaded by dinhtrung (license 776)
 
 (closes issue ASTERISK-14575)
 Reported by: dinhtrung
 Patches:
       say.c.diff uploaded by dinhtrung (license 776)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237060

By: Digium Subversion (svnbot) 2009-12-30 16:41:12.000-0600

Repository: asterisk
Revision: 237061

_U  branches/1.6.1/

------------------------------------------------------------------------
r237061 | qwell | 2009-12-30 16:41:10 -0600 (Wed, 30 Dec 2009) | 23 lines

Blocked revisions 237050 via svnmerge

........
 r237050 | qwell | 2009-12-30 16:30:21 -0600 (Wed, 30 Dec 2009) | 17 lines
 
 Add app_voicemail and say.c support for Vietnamese.
 
 Also add an XXX comment that I'm baffled nobody has ever complained about.  We
 say "first message", and then we go into language-specific stuff where we
 proceed to say..."first message".
 
 (closes issue ASTERISK-14086)
 Reported by: dinhtrung
 Patches:
       vietnamese.ods uploaded by dinhtrung (license 776)
       app_voicemail.c.diff uploaded by dinhtrung (license 776)
 
 (closes issue ASTERISK-14575)
 Reported by: dinhtrung
 Patches:
       say.c.diff uploaded by dinhtrung (license 776)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237061

By: Digium Subversion (svnbot) 2009-12-30 16:41:24.000-0600

Repository: asterisk
Revision: 237062

_U  branches/1.6.2/

------------------------------------------------------------------------
r237062 | qwell | 2009-12-30 16:41:23 -0600 (Wed, 30 Dec 2009) | 23 lines

Blocked revisions 237050 via svnmerge

........
 r237050 | qwell | 2009-12-30 16:30:21 -0600 (Wed, 30 Dec 2009) | 17 lines
 
 Add app_voicemail and say.c support for Vietnamese.
 
 Also add an XXX comment that I'm baffled nobody has ever complained about.  We
 say "first message", and then we go into language-specific stuff where we
 proceed to say..."first message".
 
 (closes issue ASTERISK-14086)
 Reported by: dinhtrung
 Patches:
       vietnamese.ods uploaded by dinhtrung (license 776)
       app_voicemail.c.diff uploaded by dinhtrung (license 776)
 
 (closes issue ASTERISK-14575)
 Reported by: dinhtrung
 Patches:
       say.c.diff uploaded by dinhtrung (license 776)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237062