[Home]

Summary:ASTERISK-14574: [patch] Prepending to a voicemail on forward causes locked sip channel and large file filling disk space
Reporter:Shaggy63 (shagg63)Labels:
Date Opened:2009-07-31 14:24:53Date Closed:2009-11-30 15:44:50.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app-voicemail-format-fix2.diff
Description:Tested on mutiple 1.4.X systems

In voicemailMain a user presses 8 to forward a voicemail then option 1 to prepend a message. After recording a message they hangup or press # the sip channel stays open and never hangs up.  The voicemail file that it prepends to fills the hard drive.  The only way to clear the channel is to restart asterisk. softhangup will not hangup the channel.

****** ADDITIONAL INFORMATION ******

[Jul 31 13:40:05] VERBOSE[11180] logger.c:   == Parsing '/var/spool/asterisk/voicemail/default/245/INBOX/msg0000.txt': [Jul 31 13:40:05] VERBOSE[11180] logger.c: Found
[Jul 31 13:40:05] DEBUG[11180] app.c: play_and_record: <None>, /var/spool/asterisk/voicemail/default/245/INBOX/msg0000, 'WAV|wav49|gsm'
[Jul 31 13:40:05] DEBUG[11180] app.c: Recording Formats: sfmts=WAV
[Jul 31 13:40:05] VERBOSE[11180] logger.c:     -- x=0, open writing:  /var/spool/asterisk/voicemail/default/245/INBOX/msg0000-prepend format: WAV, 0x86427d8
[Jul 31 13:40:05] VERBOSE[11180] logger.c:     -- x=1, open writing:  /var/spool/asterisk/voicemail/default/245/INBOX/msg0000-prepend format: wav49, 0x85ffe00
[Jul 31 13:40:05] VERBOSE[11180] logger.c:     -- x=2, open writing:  /var/spool/asterisk/voicemail/default/245/INBOX/msg0000-prepend format: gsm, 0x8613a38
[Jul 31 13:40:07] VERBOSE[11180] logger.c:     -- User ended message by pressing #
[Jul 31 13:40:07] VERBOSE[11180] logger.c:        > Recording Format: sfmts=WAV, prependfile /var/spool/asterisk/voicemail/default/245/INBOX/msg0000-prepend, recordfile /var/spool/asterisk/voicemail/default/
245/INBOX/msg0000

asterisk*CLI> core show channels
Channel              Location             State   Application(Data)
SIP/PHILLIP-b6514648 8500@default:1       Up      VoiceMailMain()

asterisk:/var/spool/asterisk/voicemail/default/245/INBOX# ls -aslh
4.0K drwxr-xr-x 2 root root 4.0K 2009-07-31 13:40 .
4.0K drwxr-xr-x 5 root root 4.0K 2008-12-23 15:45 ..
4.0K -rwx------ 1 root root 2.9K 2009-07-31 13:39 msg0000.gsm
  0 -rwx------ 1 root root    0 2009-07-31 13:40 msg0000-prepend.gsm
4.0K -rw------- 1 root root  261 2009-07-31 13:39 msg0000.txt
362M -rwx------ 1 root root 362M 2009-07-31 13:43 msg0000.WAV
Comments:By: Shaggy63 (shagg63) 2009-07-31 16:05:09

I believe I found a solution to this.  Change format=WAV to format=wav in voicemail.conf


By: Leif Madsen (lmadsen) 2009-09-18 07:34:32

I'm changing this to Acknowledged, as changing the formats may be the correct(?) work around, but is certainly not a fix. Thanks for the report!
By: Matthew Nicholson (mnicholson) 2009-11-13 08:34:36.000-0600

This is breaking because WAV and wav49 are the same format.  Your workaround should work, as wav is a different format.  I don't yet know why specifying the same format twice causes this to drop into an infinite loop.
By: Matthew Nicholson (mnicholson) 2009-11-16 11:31:26.000-0600

The patch I uploaded should fix this issue by removing duplicate formats from a format list.
By: Digium Subversion (svnbot) 2009-11-30 15:19:11.000-0600

Repository: asterisk
Revision: 231614

U   branches/1.4/apps/app_voicemail.c
U   branches/1.4/include/asterisk/file.h
U   branches/1.4/main/app.c
U   branches/1.4/main/file.c

------------------------------------------------------------------------
r231614 | mnicholson | 2009-11-30 15:19:11 -0600 (Mon, 30 Nov 2009) | 8 lines

Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.

(closes issue ASTERISK-14574)
Reported by: Shagg63
Tested by: mnicholson

Review: https://reviewboard.asterisk.org/r/429/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231614
By: Digium Subversion (svnbot) 2009-11-30 15:21:10.000-0600

Repository: asterisk
Revision: 231616

_U  trunk/
U   trunk/apps/app_voicemail.c
U   trunk/include/asterisk/file.h
U   trunk/main/app.c

------------------------------------------------------------------------
r231616 | mnicholson | 2009-11-30 15:21:09 -0600 (Mon, 30 Nov 2009) | 15 lines

Merged revisions 231614 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines
 
 Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.
 
 (closes issue ASTERISK-14574)
 Reported by: Shagg63
 Tested by: mnicholson
 
 Review: https://reviewboard.asterisk.org/r/429/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231616
By: Digium Subversion (svnbot) 2009-11-30 15:39:25.000-0600

Repository: asterisk
Revision: 231688

_U  trunk/
U   trunk/apps/app_voicemail.c
U   trunk/include/asterisk/file.h
U   trunk/main/app.c
U   trunk/main/file.c

------------------------------------------------------------------------
r231688 | mnicholson | 2009-11-30 15:39:24 -0600 (Mon, 30 Nov 2009) | 15 lines

Merged revisions 231614 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines
 
 Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.
 
 (closes issue ASTERISK-14574)
 Reported by: Shagg63
 Tested by: mnicholson
 
 Review: https://reviewboard.asterisk.org/r/429/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231688
By: Digium Subversion (svnbot) 2009-11-30 15:43:34.000-0600

Repository: asterisk
Revision: 231689

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c
U   branches/1.6.2/include/asterisk/file.h
U   branches/1.6.2/main/app.c
U   branches/1.6.2/main/file.c

------------------------------------------------------------------------
r231689 | mnicholson | 2009-11-30 15:43:33 -0600 (Mon, 30 Nov 2009) | 22 lines

Merged revisions 231688 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r231688 | mnicholson | 2009-11-30 15:31:55 -0600 (Mon, 30 Nov 2009) | 15 lines
 
 Merged revisions 231614 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines
   
   Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.
   
   (closes issue ASTERISK-14574)
   Reported by: Shagg63
   Tested by: mnicholson
   
   Review: https://reviewboard.asterisk.org/r/429/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231689
By: Digium Subversion (svnbot) 2009-11-30 15:44:21.000-0600

Repository: asterisk
Revision: 231690

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_voicemail.c
U   branches/1.6.1/include/asterisk/file.h
U   branches/1.6.1/main/app.c
U   branches/1.6.1/main/file.c

------------------------------------------------------------------------
r231690 | mnicholson | 2009-11-30 15:44:20 -0600 (Mon, 30 Nov 2009) | 22 lines

Merged revisions 231688 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r231688 | mnicholson | 2009-11-30 15:31:55 -0600 (Mon, 30 Nov 2009) | 15 lines
 
 Merged revisions 231614 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines
   
   Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.
   
   (closes issue ASTERISK-14574)
   Reported by: Shagg63
   Tested by: mnicholson
   
   Review: https://reviewboard.asterisk.org/r/429/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231690
By: Digium Subversion (svnbot) 2009-11-30 15:44:49.000-0600

Repository: asterisk
Revision: 231691

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_voicemail.c
U   branches/1.6.0/include/asterisk/file.h
U   branches/1.6.0/main/app.c
U   branches/1.6.0/main/file.c

------------------------------------------------------------------------
r231691 | mnicholson | 2009-11-30 15:44:48 -0600 (Mon, 30 Nov 2009) | 22 lines

Merged revisions 231688 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r231688 | mnicholson | 2009-11-30 15:31:55 -0600 (Mon, 30 Nov 2009) | 15 lines
 
 Merged revisions 231614 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r231614 | mnicholson | 2009-11-30 15:11:44 -0600 (Mon, 30 Nov 2009) | 8 lines
   
   Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.
   
   (closes issue ASTERISK-14574)
   Reported by: Shagg63
   Tested by: mnicholson
   
   Review: https://reviewboard.asterisk.org/r/429/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=231691