Summary:	ASTERISK-14556: [patch] set NOISY_BUILD to yes when compiling under devmode
Reporter:	Michiel van Baak (mvanbaak)	Labels:
Date Opened:	2009-07-29 03:32:01	Date Closed:	2009-07-30 18:39:07
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 2009072900-devmodenoisybuild.diff.txt ( 1) 20090730_issue15607.patch
Description:	When you configure asterisk with --enable-dev-mode it will make warnings fatal etc. To help spot things it would be nice if the buildsystem shows the full build commands. This patch enables NOISY_BUILD when you configured it with --enable-dev-mode
Comments:	By: Russell Bryant (russell) 2009-07-29 10:20:24 I vote 'no' on this one.  This would annoy the heck out of me.  :-) It's not too difficult to run "make NOISY_BUILD=yes" when needed ... By: Michiel van Baak (mvanbaak) 2009-07-29 12:45:34 well, that, (and the fact I always forget it, have to look in the makefile what the varname was again, and start over) annoys the heck out of me ;) but if the general feeling is in line with yours, feel free to close this one. By: Sean Bright (seanbright) 2009-07-29 16:25:48 I'm in the "no" camp as well. By: Tilghman Lesher (tilghman) 2009-07-29 16:37:29 I'm also in the "no" camp.  It's easy enough to enable. By: Richard Mudgett (rmudgett) 2009-07-29 18:26:08 What about if the NOISY_BUILD were enabled with another flag on the ./configure command? ./configure --enable-dev-mode --enable-noisy-build By: Michiel van Baak (mvanbaak) 2009-07-30 00:20:30 Kevin stated he's in the no camp as well with some text to back his opinion on the -dev list. That makes it: "4 nee, 1 jee. not passed" By: Sean Bright (seanbright) 2009-07-30 08:49:43 @rmudgett, that's not a bad idea.  We could just have --enable-dev-mode and --enable-noisy-dev-mode.  Done and done. By: Sean Bright (seanbright) 2009-07-30 10:34:56 How about this?  Instead of defaulting NOISY_BUILD to yes under dev mode, you can do this:    ./configure --enable-dev-mode=noisy Which will both enable dev mode and verbose build output.  Meh? By: Michiel van Baak (mvanbaak) 2009-07-30 12:59:02 Thank you. Works for me! By: Russell Bryant (russell) 2009-07-30 17:59:03 I have no problems with that. By: Digium Subversion (svnbot) 2009-07-30 18:37:43 Repository: asterisk Revision: 209623 U   trunk/configure U   trunk/configure.ac U   trunk/makeopts.in ------------------------------------------------------------------------ r209623 | seanbright | 2009-07-30 18:37:42 -0500 (Thu, 30 Jul 2009) | 8 lines Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose builds. (closes issue ASTERISK-14556) Reported by: mvanbaak Patches:      20090730_issue15607.patch uploaded by seanbright (license 71) Tested by: seanbright ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=209623 By: Digium Subversion (svnbot) 2009-07-30 18:38:59 Repository: asterisk Revision: 209624 _U  branches/1.6.0/ ------------------------------------------------------------------------ r209624 | seanbright | 2009-07-30 18:38:58 -0500 (Thu, 30 Jul 2009) | 14 lines Blocked revisions 209623 via svnmerge ........  r209623 | seanbright | 2009-07-30 19:37:31 -0400 (Thu, 30 Jul 2009) | 8 lines    Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose builds.    (closes issue ASTERISK-14556)  Reported by: mvanbaak  Patches:        20090730_issue15607.patch uploaded by seanbright (license 71)  Tested by: seanbright ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=209624 By: Digium Subversion (svnbot) 2009-07-30 18:39:03 Repository: asterisk Revision: 209625 _U  branches/1.6.1/ ------------------------------------------------------------------------ r209625 | seanbright | 2009-07-30 18:39:02 -0500 (Thu, 30 Jul 2009) | 14 lines Blocked revisions 209623 via svnmerge ........  r209623 | seanbright | 2009-07-30 19:37:31 -0400 (Thu, 30 Jul 2009) | 8 lines    Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose builds.    (closes issue ASTERISK-14556)  Reported by: mvanbaak  Patches:        20090730_issue15607.patch uploaded by seanbright (license 71)  Tested by: seanbright ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=209625 By: Digium Subversion (svnbot) 2009-07-30 18:39:06 Repository: asterisk Revision: 209626 _U  branches/1.6.2/ ------------------------------------------------------------------------ r209626 | seanbright | 2009-07-30 18:39:05 -0500 (Thu, 30 Jul 2009) | 14 lines Blocked revisions 209623 via svnmerge ........  r209623 | seanbright | 2009-07-30 19:37:31 -0400 (Thu, 30 Jul 2009) | 8 lines    Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose builds.    (closes issue ASTERISK-14556)  Reported by: mvanbaak  Patches:        20090730_issue15607.patch uploaded by seanbright (license 71)  Tested by: seanbright ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=209626