| Summary: | ASTERISK-14548: [patch] all codecs allowed, but textsupport=no crashes on T140RED enabled call | ||
| Reporter: | Timo Teräs (fabled) | Labels: | |
| Date Opened: | 2009-07-28 06:49:50 | Date Closed: | 2009-07-30 09:40:45 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) sip-red.patch | |
| Description: | Asterisk crashes when a call when a T.140 RED enabled client places a call and the server configuration allows the codec, but text support is disabled. ****** STEPS TO REPRODUCE ****** Configure SIP with: allow=all textsupport=no Place a call from SIP client that has T.140 RED support. ****** ADDITIONAL INFORMATION ****** Bug present in trunk. Also I remember seeing similar crashes in 1.6.1 and 1.6.2 branches, but did not verify it is the same cause. 1.6.0 seems not effected. (gdb) where #0 0x130f71dc in ast_rtp_red_init (instance=0x0, buffer_time=300, payloads=0x49f7dd70, generations=2) at rtp_engine.c:1443 #1 0x4accf552 in process_sdp (p=0x13363d18, req=0x49f817bc, t38action=1) at chan_sip.c:8620 #2 0x4ad0eefb in handle_request_invite (p=0x13363d18, req=0x49f817bc, debug=0, seqno=2, sin=0x49f81a00, recount=0x49f81764, e=0x1336101b "sip:440@10.252.5.49", nounlock=0x49f81760) at chan_sip.c:20242 #3 0x4ad17e2c in handle_incoming (p=0x13363d18, req=0x49f817bc, sin=0x49f81a00, recount=0x49f81764, nounlock=0x49f81760) at chan_sip.c:21991 #4 0x4ad18f74 in handle_request_do (req=0x49f817bc, sin=0x49f81a00) at chan_sip.c:22296 ASTERISK-1 0x4ad18862 in sipsock_read (id=0x1335e020, fd=14, events=1, ignore=0x0) at chan_sip.c:22190 ASTERISK-2 0x130b798d in ast_io_wait (ioc=0x13357758, howlong=1000) at io.c:288 ASTERISK-3 0x4ad1a48e in do_monitor (data=0x0) at chan_sip.c:22688 ASTERISK-4 0x13135220 in dummy_start (data=0x1335d9d8) at utils.c:968 ASTERISK-5 0x4b113d2b in pthread_start_thread () from /lib/libpthread.so.0 ASTERISK-6 0x4b081e0e in clone () from /lib/libc.so.0 In chan_sip.c:process_sdp() one should likely check p->trtp != NULL before together with jointcapability. Or just force T140RED codec off when textsupport=no. | ||
| Comments: | By: Mark Michelson (mmichelson) 2009-07-30 09:37:43 Your patch seems like exactly the correct fix. Thank you very much. By: Digium Subversion (svnbot) 2009-07-30 09:38:35 Repository: asterisk Revision: 209516 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r209516 | mmichelson | 2009-07-30 09:38:34 -0500 (Thu, 30 Jul 2009) | 8 lines Fix a crash that can result if text codecs are allowed but textsupport is disabled. (closes issue ASTERISK-14548) Reported by: fabled Patches: sip-red.patch uploaded by fabled (license 448) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=209516 By: Digium Subversion (svnbot) 2009-07-30 09:40:27 Repository: asterisk Revision: 209517 _U branches/1.6.1/ U branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r209517 | mmichelson | 2009-07-30 09:40:27 -0500 (Thu, 30 Jul 2009) | 14 lines Merged revisions 209516 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r209516 | mmichelson | 2009-07-30 09:38:21 -0500 (Thu, 30 Jul 2009) | 8 lines Fix a crash that can result if text codecs are allowed but textsupport is disabled. (closes issue ASTERISK-14548) Reported by: fabled Patches: sip-red.patch uploaded by fabled (license 448) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=209517 By: Digium Subversion (svnbot) 2009-07-30 09:40:44 Repository: asterisk Revision: 209518 _U branches/1.6.2/ U branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r209518 | mmichelson | 2009-07-30 09:40:44 -0500 (Thu, 30 Jul 2009) | 14 lines Merged revisions 209516 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r209516 | mmichelson | 2009-07-30 09:38:21 -0500 (Thu, 30 Jul 2009) | 8 lines Fix a crash that can result if text codecs are allowed but textsupport is disabled. (closes issue ASTERISK-14548) Reported by: fabled Patches: sip-red.patch uploaded by fabled (license 448) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=209518 | ||