|Summary:||ASTERISK-14527: [patch] Add busy detection|
|Reporter:||Artem Makhutov (artem)||Labels:|
|Date Opened:||2009-07-25 09:51:48||Date Closed:||2013-01-15 17:55:45.000-0600|
|Environment:||Attachments:||( 0) busy-full3.patch|
( 1) busy-full4.patch
( 2) busy-full5.patch
( 3) busy-part1.patch
( 4) busy-part2.patch
this two patches add busy detection to chan_mobile.
Before applying this patches you need to apply the cusd patch (Bug 15278).
The first patch adds general support for busy detection. The second patch adds support for the ECAM command at Sony Ericsson phones and also signals busy when only early media was received but the call got not answered.
|Comments:||By: Matthew Nicholson (mnicholson) 2009-07-28 11:10:51|
These patches look good, but I have a few comments. Please post them on reviewboard.
By: Artem Makhutov (artem) 2009-07-31 19:08:32
I have posted the patch as one single patch:
By: Matthew Nicholson (mnicholson) 2009-08-20 11:01:48
I have updated the review. It is waiting for your feedback.
By: Leif Madsen (lmadsen) 2009-09-22 08:19:00
Pinging the reporter for feedback here after mnicholson did a review. Is the reporter still interested in moving this issue forward? Thanks!
By: Artem Makhutov (artem) 2009-09-23 04:19:57
I have also updated the patch.
By: Leif Madsen (lmadsen) 2009-09-23 09:47:07
By: Matthew Nicholson (mnicholson) 2009-11-13 08:39:18.000-0600
I have updated the review with my comments.
By: Leif Madsen (lmadsen) 2010-01-07 10:56:27.000-0600
Pinging reporter for feedback?
By: Artem Makhutov (artem) 2010-01-21 17:30:58.000-0600
I have updated the patch. Please review it.
As I don't have the hardware I have no possiblity to fully test the patch again. I have just updated the hfp_parse_ecav function and did a functionality test on it.
So in theory it should work well.
By: Artem Makhutov (artem) 2010-02-26 12:35:59.000-0600
By: Leif Madsen (lmadsen) 2010-04-15 10:22:42
If I get a chance to test this, I will. Assigning to myself so I don't forget about it.
By: Matt Jordan (mjordan) 2013-01-15 17:54:25.654-0600
So, while trolling through patches and old issues, I stumbled across this and noticed that Matt Nicholson gave the patch a ship it quite some time ago.
SO... I shipped it. Ping me in #asterisk-dev if there's anything that needs to be discussed regarding this patch.