Summary:	ASTERISK-14523: [patch] p->peerauth is always empty in transmit_register()
Reporter:	Elazar Broad (ebroad)	Labels:
Date Opened:	2009-09-24 10:29:03	Date Closed:	2009-10-09 11:07:21
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) regauthfix.patch
Description:	When we call build_reply_digest() later on, the peers 'auth=' setting will never get used because p->peerauth is empty, and the registration will fail. ****** ADDITIONAL INFORMATION ****** The auth setting works fine for transmit_invite(), a quick look at the code shows that sip_request_call() calls create_addr() with newdialog set to 1(true), which causes create_addr() to call create_addr_from_peer() which ultimately sets p->peerauth. Should we be setting newdialog to 1 in transmit_register() as well?
Comments:	By: Digium Subversion (svnbot) 2009-10-09 10:52:58 Repository: asterisk Revision: 223088 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r223088 | dvossel | 2009-10-09 10:52:57 -0500 (Fri, 09 Oct 2009) | 14 lines p->peerauth is always empty in transmit_register() When using callbackextension or specifing the peer name in a registration string, the peer's specific auth settings set by the "auth=" strings within the peer definition are not used by the registration.  Thanks to ebroad for reporting the issue and providing the patch. (closes issue ASTERISK-14523) Reported by: ebroad Patches:      regauthfix.patch uploaded by ebroad (license 878) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=223088 By: Digium Subversion (svnbot) 2009-10-09 10:57:19 Repository: asterisk Revision: 223089 _U  branches/1.6.2/ U   branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r223089 | dvossel | 2009-10-09 10:57:19 -0500 (Fri, 09 Oct 2009) | 20 lines Merged revisions 223088 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r223088 | dvossel | 2009-10-09 10:49:30 -0500 (Fri, 09 Oct 2009) | 14 lines    p->peerauth is always empty in transmit_register()    When using callbackextension or specifing the peer name  in a registration string, the peer's specific auth settings  set by the "auth=" strings within the peer definition are not  used by the registration.  Thanks to ebroad for reporting the  issue and providing the patch.    (closes issue ASTERISK-14523)  Reported by: ebroad  Patches:        regauthfix.patch uploaded by ebroad (license 878) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=223089 By: Digium Subversion (svnbot) 2009-10-09 11:04:23 Repository: asterisk Revision: 223090 _U  branches/1.6.1/ U   branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r223090 | dvossel | 2009-10-09 11:04:23 -0500 (Fri, 09 Oct 2009) | 20 lines Merged revisions 223088 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r223088 | dvossel | 2009-10-09 10:49:30 -0500 (Fri, 09 Oct 2009) | 14 lines    p->peerauth is always empty in transmit_register()    When using callbackextension or specifing the peer name  in a registration string, the peer's specific auth settings  set by the "auth=" strings within the peer definition are not  used by the registration.  Thanks to ebroad for reporting the  issue and providing the patch.    (closes issue ASTERISK-14523)  Reported by: ebroad  Patches:        regauthfix.patch uploaded by ebroad (license 878) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=223090 By: Digium Subversion (svnbot) 2009-10-09 11:07:20 Repository: asterisk Revision: 223091 _U  branches/1.6.0/ U   branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r223091 | dvossel | 2009-10-09 11:07:20 -0500 (Fri, 09 Oct 2009) | 20 lines Merged revisions 223088 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r223088 | dvossel | 2009-10-09 10:49:30 -0500 (Fri, 09 Oct 2009) | 14 lines    p->peerauth is always empty in transmit_register()    When using callbackextension or specifing the peer name  in a registration string, the peer's specific auth settings  set by the "auth=" strings within the peer definition are not  used by the registration.  Thanks to ebroad for reporting the  issue and providing the patch.    (closes issue ASTERISK-14523)  Reported by: ebroad  Patches:        regauthfix.patch uploaded by ebroad (license 878) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=223091