Summary:	ASTERISK-14446: [patch] Not all fixes from #14849 are committed
Reporter:	Dmitry Andrianov (dimas)	Labels:
Date Opened:	2009-07-09 18:01:34	Date Closed:	2009-07-10 10:36:40
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_fax
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) test1-15480.patch ( 1) test2-15480.patch ( 2) v1-15480.patch
Description:	As I see in the commit 205696 kpfleming fixes the main bug reported in ASTERISK-13915 but there is a small issue still left. The patch I was proposing for ASTERISK-13915 was actually contained the fix but Kevin probably overlooked it. This is about transmit_t38 aborts the loop and reports error when T38 is down. Actually while the loop must be finished, it is not error condition so no error should be reported.
Comments:	By: Dmitry Andrianov (dimas) 2009-07-09 18:10:27 The patch also fixes wording a bit - it looks like the "T38 switchover completed" comment was just copied from AST_T38_NEGOTIATED branch to the NEGOTIATE branch where it is not 100% correct because switchover is not completed yet and we are going to actually complete it. By: Andrew Lindh (andrew) 2009-07-10 07:04:40 T38 send fax still fails for me. [Jul 10 07:59:25] WARNING[24583]: res_rtp_asterisk.c:1881 ast_rtp_read: RTP Read too short [Jul 10 07:59:25] WARNING[24583]: res_rtp_asterisk.c:1881 ast_rtp_read: RTP Read too short [Jul 10 07:59:26] WARNING[24583]: res_rtp_asterisk.c:1881 ast_rtp_read: RTP Read too short [Jul 10 07:59:26] WARNING[24583]: res_rtp_asterisk.c:1881 ast_rtp_read: RTP Read too short [Jul 10 08:00:02] WARNING[24583]: app_fax.c:223 phase_e_handler: Error transmitting fax. result=3: Timed out waiting for the first message. [Jul 10 08:00:02] WARNING[24583]: app_fax.c:728 transmit: Transmission failed     -- Executing [h@txfax:1] NoOp("SIP/as5300-082c02e8", ""Finish with TxFax -  Timed out waiting for the first message T38"") in new stack By: Dmitry Andrianov (dimas) 2009-07-10 07:27:37 hm... it seems your issue is no related to what my patch fixes. Are you saying that my patch from ASTERISK-13915 worked fine but when you updated it does not work anymore? By: Dmitry Andrianov (dimas) 2009-07-10 07:36:36 Andrew, please try test1-15480.patch By: Andrew Lindh (andrew) 2009-07-10 08:34:56 still fails.... By: Dmitry Andrianov (dimas) 2009-07-10 09:09:25 Again, did it work with patch from ASTERISK-13915 ? Please provide log with sip debug and core set debug 3. PS: no need to test test2 patch - it is just cleaned up and commented version of test1. By: Digium Subversion (svnbot) 2009-07-10 10:28:12 Repository: asterisk Revision: 205770 U   trunk/apps/app_fax.c ------------------------------------------------------------------------ r205770 | kpfleming | 2009-07-10 10:28:11 -0500 (Fri, 10 Jul 2009) | 12 lines Fix some remaining T.38 negotiation problems in app_fax. Revision 205696 did not quite fix all the issues with the T.38 negotiation changes and app_fax; this patch corrects them, along with a couple of other minor issues. (closes issue ASTERISK-14446) Reported by: dimas Patches:      test2-15480.patch uploaded by dimas (license 88) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=205770 By: Digium Subversion (svnbot) 2009-07-10 10:35:51 Repository: asterisk Revision: 205771 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_fax.c ------------------------------------------------------------------------ r205771 | kpfleming | 2009-07-10 10:35:51 -0500 (Fri, 10 Jul 2009) | 18 lines Merged revisions 205770 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r205770 | kpfleming | 2009-07-10 10:28:11 -0500 (Fri, 10 Jul 2009) | 12 lines    Fix some remaining T.38 negotiation problems in app_fax.    Revision 205696 did not quite fix all the issues with the T.38 negotiation  changes and app_fax; this patch corrects them, along with a couple of other  minor issues.    (closes issue ASTERISK-14446)  Reported by: dimas  Patches:        test2-15480.patch uploaded by dimas (license 88) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=205771 By: Digium Subversion (svnbot) 2009-07-10 10:36:21 Repository: asterisk Revision: 205772 _U  branches/1.6.1/ U   branches/1.6.1/apps/app_fax.c ------------------------------------------------------------------------ r205772 | kpfleming | 2009-07-10 10:36:20 -0500 (Fri, 10 Jul 2009) | 18 lines Merged revisions 205770 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r205770 | kpfleming | 2009-07-10 10:28:11 -0500 (Fri, 10 Jul 2009) | 12 lines    Fix some remaining T.38 negotiation problems in app_fax.    Revision 205696 did not quite fix all the issues with the T.38 negotiation  changes and app_fax; this patch corrects them, along with a couple of other  minor issues.    (closes issue ASTERISK-14446)  Reported by: dimas  Patches:        test2-15480.patch uploaded by dimas (license 88) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=205772 By: Digium Subversion (svnbot) 2009-07-10 10:36:40 Repository: asterisk Revision: 205773 _U  branches/1.6.2/ U   branches/1.6.2/apps/app_fax.c ------------------------------------------------------------------------ r205773 | kpfleming | 2009-07-10 10:36:39 -0500 (Fri, 10 Jul 2009) | 18 lines Merged revisions 205770 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r205770 | kpfleming | 2009-07-10 10:28:11 -0500 (Fri, 10 Jul 2009) | 12 lines    Fix some remaining T.38 negotiation problems in app_fax.    Revision 205696 did not quite fix all the issues with the T.38 negotiation  changes and app_fax; this patch corrects them, along with a couple of other  minor issues.    (closes issue ASTERISK-14446)  Reported by: dimas  Patches:        test2-15480.patch uploaded by dimas (license 88) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=205773