Summary:	ASTERISK-14361: Park() application options not working as documented
Reporter:	dlnoah (dlnoah)	Labels:
Date Opened:	2009-06-22 14:20:56	Date Closed:	2009-07-08 13:19:00
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_parkandannounce
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	I recently updated one of my Asterisk servers to 1.6.1.1 and was trying to make use of the new options available in the Park() dialplan application.  I found the following two issues with these options: 1) The "timeout" option is expecting its argument in milliseconds.  This is not documented in the CLI documentation for the function and is contrary to the behavior of several other dialplan applications (such as Dial and WaitExten), which take their timeout argument in seconds. 2) The "returncontext", "returnextension", and "returnpriority" options are being ignored.  In my specific case, I have comebacktoorigin = no set within features config.  If I park the call such as Park(180000,incoming-general,s,1), the following console output will occur on timeout:  == Timeout for IAX2/dundi-directlink-7325 parked on 1071 (default). Returning to parkedcallstimeout,IAX20dundi-directlink,1  == Starting IAX2/dundi-directlink-7325 at parkedcallstimeout,IAX20dundi-directlink,1 failed so falling back to exten 's'
Comments:	By: dlnoah (dlnoah) 2009-06-22 14:24:52 Full console outputs:    -- Executing [1@parkedcallstimeout:3] Park("IAX2/dundi-directlink-7325", ",incoming-general,s,1,s") in new stack  == Parked IAX2/dundi-directlink-7325 on 1071 (lot default). Will timeout back to extension [incoming-general] s, 1 in 180 seconds    -- Added extension '1071' priority 1 to bryan-parked (0xb7483cd0)    -- Started music on hold, class 'default', on IAX2/dundi-directlink-7325    -- Stopped music on hold on IAX2/dundi-directlink-7325 [Jun 22 10:32:18] WARNING[322]: features.c:2975 manage_parkinglot: Dialfeatures not found on IAX2/dundi-directlink-7325, using default!    -- Added extension 'IAX20dundi-directlink' priority 1 to park-dial (0xb7409258) [Jun 22 10:32:18] WARNING[322]: features.c:2984 manage_parkinglot: now going to parkedcallstimeout,s,1 | ps is 1071  == Timeout for IAX2/dundi-directlink-7325 parked on 1071 (default). Returning to parkedcallstimeout,IAX20dundi-directlink,1  == Starting IAX2/dundi-directlink-7325 at parkedcallstimeout,IAX20dundi-directlink,1 failed so falling back to exten 's'    -- Executing [s@parkedcallstimeout:1] NoOp("IAX2/dundi-directlink-7325", ""Parked call timed out - 1071 - CID: ""Noah" <100>") in new stack    -- Executing [s@parkedcallstimeout:2] Set("IAX2/dundi-directlink-7325", "DEVICE_STATE(Custom:park1071)=INUSE") in new stack The incoming-general context does exist, but never gets called by the timed out parked call.  Also, as I noted in my note on ticket ASTERISK-1458741, 1.6.0.9 and 1.6.1.1 are both trying to ring the extension that parked the call before falling through to parkedcallstimeout, even though I have comebacktoorigin = no in my features.conf.  Regardless of whether comebacktoorigin = no is set, the returns to the extension that parked the call are failing for SIP or IAX channels, because instead of dialing SIP/1010, the server is trying to dial SIP01010 (which does not exist).  If comebacktoorigin = no is set, the parked call will then fall through to parkedcallstimeout,s,1.  If comebacktoorigin = no is not set, the parked call will then fall through to park-dial,t,1. By: Digium Subversion (svnbot) 2009-07-08 12:26:27 Repository: asterisk Revision: 205254 U   trunk/main/features.c ------------------------------------------------------------------------ r205254 | dbrooks | 2009-07-08 12:26:27 -0500 (Wed, 08 Jul 2009) | 8 lines Fixes Park() argument handling Park() was not respecting the arguments passed to it. Any extension/context/priority given to it was being ignored. This patch remedies this. (closes issue ASTERISK-14361) Reported by: DLNoah ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=205254 By: Digium Subversion (svnbot) 2009-07-08 13:07:54 Repository: asterisk Revision: 205279 _U  branches/1.6.1/ U   branches/1.6.1/main/features.c ------------------------------------------------------------------------ r205279 | dbrooks | 2009-07-08 13:07:53 -0500 (Wed, 08 Jul 2009) | 15 lines Merged revisions 205254 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r205254 | dbrooks | 2009-07-08 12:26:26 -0500 (Wed, 08 Jul 2009) | 8 lines    Fixes Park() argument handling    Park() was not respecting the arguments passed to it. Any extension/context/priority  given to it was being ignored. This patch remedies this.    (closes issue ASTERISK-14361)  Reported by: DLNoah ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=205279 By: Digium Subversion (svnbot) 2009-07-08 13:19:00 Repository: asterisk Revision: 205287 _U  branches/1.6.2/ U   branches/1.6.2/main/features.c ------------------------------------------------------------------------ r205287 | dbrooks | 2009-07-08 13:18:59 -0500 (Wed, 08 Jul 2009) | 15 lines Merged revisions 205254 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r205254 | dbrooks | 2009-07-08 12:26:26 -0500 (Wed, 08 Jul 2009) | 8 lines    Fixes Park() argument handling    Park() was not respecting the arguments passed to it. Any extension/context/priority  given to it was being ignored. This patch remedies this.    (closes issue ASTERISK-14361)  Reported by: DLNoah ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=205287