[Home]

Summary:ASTERISK-14357: SIP option (SIP_OPT_ flag) is not handled correctly
Reporter:Takehiko Ooshima (takehiko ooshima)Labels:
Date Opened:2009-06-22 07:52:05Date Closed:2009-07-20 12:44:50
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:chan_sip.c
SIP Options (required_profile, p->sipoptions, and so on) compare must bit-field.
But 1.6.1.0 or 1.6.1.1 source compare entire flag value.

for example
1.6.1.1/channels/chan_sip.c: 18202
-  if (p->sipoptions == SIP_OPT_TIMER) {
+  if (p->sipoptions & SIP_OPT_TIMER) {

So, our PBX: SIP_OPT_TIMER & SIP_OPT_REPLACE (== 5) not much SIP_OPT_TIMER routine.
Comments:By: David Vossel (dvossel) 2009-07-15 17:11:21

this was resolved with issue ASTERISK-14382
By: Takehiko Ooshima (takehiko ooshima) 2009-07-17 00:01:46

-->  this was resolved with issue 0015403

I found the following.

'required_profile' flag is the same.


if (required_profile && required_profile != SIP_OPT_REPLACES && required_profile != SIP_OPT_TIMER) {

if (required_profile && (required_profile & !(SIP_OPT_REPLACES | SIP_OPT_TIMER))) {


By: David Vossel (dvossel) 2009-07-17 12:33:44

shouldn't it be

if (required_profile && !(required_profile & (SIP_OPT_REPLACES | SIP_OPT_TIMER)))
By: Digium Subversion (svnbot) 2009-07-17 12:51:45

Repository: asterisk
Revision: 207029

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r207029 | dvossel | 2009-07-17 12:51:45 -0500 (Fri, 17 Jul 2009) | 6 lines

sip option flags handled incorrectly

(closes issue ASTERISK-14357)
Reported by: Takehiko Ooshima
Tested by: dvossel, Takehiko_Ooshima

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207029
By: Digium Subversion (svnbot) 2009-07-17 12:52:34

Repository: asterisk
Revision: 207030

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r207030 | dvossel | 2009-07-17 12:52:34 -0500 (Fri, 17 Jul 2009) | 13 lines

Merged revisions 207029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r207029 | dvossel | 2009-07-17 12:51:44 -0500 (Fri, 17 Jul 2009) | 6 lines
 
 sip option flags handled incorrectly
 
 (closes issue ASTERISK-14357)
 Reported by: Takehiko Ooshima
 Tested by: dvossel, Takehiko_Ooshima
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207030
By: Digium Subversion (svnbot) 2009-07-17 12:53:04

Repository: asterisk
Revision: 207031

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r207031 | dvossel | 2009-07-17 12:53:04 -0500 (Fri, 17 Jul 2009) | 13 lines

Merged revisions 207029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r207029 | dvossel | 2009-07-17 12:51:44 -0500 (Fri, 17 Jul 2009) | 6 lines
 
 sip option flags handled incorrectly
 
 (closes issue ASTERISK-14357)
 Reported by: Takehiko Ooshima
 Tested by: dvossel, Takehiko_Ooshima
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207031
By: Digium Subversion (svnbot) 2009-07-17 12:53:51

Repository: asterisk
Revision: 207032

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r207032 | dvossel | 2009-07-17 12:53:51 -0500 (Fri, 17 Jul 2009) | 13 lines

Merged revisions 207029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r207029 | dvossel | 2009-07-17 12:51:44 -0500 (Fri, 17 Jul 2009) | 6 lines
 
 sip option flags handled incorrectly
 
 (closes issue ASTERISK-14357)
 Reported by: Takehiko Ooshima
 Tested by: dvossel, Takehiko_Ooshima
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207032
By: Digium Subversion (svnbot) 2009-07-17 13:00:39

Repository: asterisk
Revision: 207033

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r207033 | dvossel | 2009-07-17 13:00:39 -0500 (Fri, 17 Jul 2009) | 4 lines

sip option flags handled incorrectly

(issue ASTERISK-14357)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207033
By: Digium Subversion (svnbot) 2009-07-17 13:01:04

Repository: asterisk
Revision: 207034

_U  trunk/

------------------------------------------------------------------------
r207034 | dvossel | 2009-07-17 13:01:04 -0500 (Fri, 17 Jul 2009) | 10 lines

Blocked revisions 207033 via svnmerge

........
 r207033 | dvossel | 2009-07-17 13:00:38 -0500 (Fri, 17 Jul 2009) | 4 lines
 
 sip option flags handled incorrectly
 
 (issue ASTERISK-14357)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=207034