[Home]

Summary:ASTERISK-14353: [patch] app_followme does not set correct language/inherit from calling channel for Local/xxxxx channels it creates
Reporter:Romik_g (romik)Labels:
Date Opened:2009-06-22 04:31:26Date Closed:2010-07-20 10:20:20
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_followme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090828__issue15372.diff.txt
( 1) app_followme1.6.patch
Description:app_followme does not set correct language for Local/xxxxx channels it creates, that causes prompts that are played to the called party (Local/xxxxx channel) are `en` prompts like "press one to accept this call, press two to..." rather than `xx` language prompts which are played to the calling party, assuming that channel's language is set from channel's config file (chan_dahdi.conf, sip.conf, etc.).
chan_local doesn't have it's config file, thus that might be usefull to inherit parent channel's language in this case.
Similar to https://issues.asterisk.org/view.php?id=9213 , we may reopen it.


****** STEPS TO REPRODUCE ******

1) language=xx <- any lang. you have in chan_dahdi.conf, sip.conf, etc.
2) incoming call to FollowMe() app to exten which is not available, localized sounds are played to the caller
3) FollowMe calls the callee via Local/xxx and prompts him in English
Comments:By: Clod Patry (junky) 2009-06-23 22:46:13

I might have a better solution:
I've created a new option called language, so you can add it to your followme profile (context).


So if phone A has chan->language=en, he will hear everything in english, you will be able to FollowMe(junky), which has language=fr and on junky's channel, all his prompts will be french.

Whatcha think?
By: Romik_g (romik) 2009-06-24 00:19:04

Sounds good.
Except that your soultion is a feature and probably will not be implemented for 1.4.x but for 1.6.x. And my suggestion is considered to be a bug thus should be fixed for both 1.4.x and 1.6.x =)
My other thoughts are that we already have language=xx in users.conf, sip.conf, chan_dahdi.conf, etc. for the extensions - think of devices described there as of extensions, if they have HINT in the dialplan in extensions.conf. Thus if we call for an example "303" and by the hint we know that this is a "SIP/phone-303" and has language=fr in it's configuration, then why not to use "fr" prompts for channels that are created when FollowMe tries to reach the user? That seems to be reasonable to use "fr" prompts, because first user's phone "SIP/303" is french.
By: Marek Cervenka (cervajs) 2009-09-14 10:12:23

i have this problem too.

tested on 1.6.0.15. with patch works ok

patch for 1.6 attached


By: Digium Subversion (svnbot) 2009-09-15 11:02:54

Repository: asterisk
Revision: 218577

U   branches/1.4/apps/app_followme.c

------------------------------------------------------------------------
r218577 | tilghman | 2009-09-15 11:02:54 -0500 (Tue, 15 Sep 2009) | 9 lines

Ensure FollowMe sets language in channels it creates.
Also, not in the original bug report, but related fields are accountcode and
musicclass, and the inheritance of datastores.
(closes issue ASTERISK-14353)
Reported by: Romik
Patches:
      20090828__issue15372.diff.txt uploaded by tilghman (license 14)
Tested by: cervajs

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218577
By: Digium Subversion (svnbot) 2009-09-15 11:06:18

Repository: asterisk
Revision: 218579

_U  trunk/
U   trunk/apps/app_followme.c

------------------------------------------------------------------------
r218579 | tilghman | 2009-09-15 11:06:18 -0500 (Tue, 15 Sep 2009) | 16 lines

Merged revisions 218577 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r218577 | tilghman | 2009-09-15 11:01:17 -0500 (Tue, 15 Sep 2009) | 9 lines
 
 Ensure FollowMe sets language in channels it creates.
 Also, not in the original bug report, but related fields are accountcode and
 musicclass, and the inheritance of datastores.
 (closes issue ASTERISK-14353)
  Reported by: Romik
  Patches:
        20090828__issue15372.diff.txt uploaded by tilghman (license 14)
  Tested by: cervajs
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218579
By: Digium Subversion (svnbot) 2009-09-15 11:07:02

Repository: asterisk
Revision: 218580

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_followme.c

------------------------------------------------------------------------
r218580 | tilghman | 2009-09-15 11:07:02 -0500 (Tue, 15 Sep 2009) | 23 lines

Merged revisions 218579 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218579 | tilghman | 2009-09-15 11:04:41 -0500 (Tue, 15 Sep 2009) | 16 lines
 
 Merged revisions 218577 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218577 | tilghman | 2009-09-15 11:01:17 -0500 (Tue, 15 Sep 2009) | 9 lines
   
   Ensure FollowMe sets language in channels it creates.
   Also, not in the original bug report, but related fields are accountcode and
   musicclass, and the inheritance of datastores.
   (closes issue ASTERISK-14353)
    Reported by: Romik
    Patches:
          20090828__issue15372.diff.txt uploaded by tilghman (license 14)
    Tested by: cervajs
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218580
By: Digium Subversion (svnbot) 2009-09-15 11:07:12

Repository: asterisk
Revision: 218581

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_followme.c

------------------------------------------------------------------------
r218581 | tilghman | 2009-09-15 11:07:12 -0500 (Tue, 15 Sep 2009) | 23 lines

Merged revisions 218579 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218579 | tilghman | 2009-09-15 11:04:41 -0500 (Tue, 15 Sep 2009) | 16 lines
 
 Merged revisions 218577 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218577 | tilghman | 2009-09-15 11:01:17 -0500 (Tue, 15 Sep 2009) | 9 lines
   
   Ensure FollowMe sets language in channels it creates.
   Also, not in the original bug report, but related fields are accountcode and
   musicclass, and the inheritance of datastores.
   (closes issue ASTERISK-14353)
    Reported by: Romik
    Patches:
          20090828__issue15372.diff.txt uploaded by tilghman (license 14)
    Tested by: cervajs
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218581
By: Digium Subversion (svnbot) 2009-09-15 11:08:01

Repository: asterisk
Revision: 218582

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_followme.c

------------------------------------------------------------------------
r218582 | tilghman | 2009-09-15 11:08:01 -0500 (Tue, 15 Sep 2009) | 23 lines

Merged revisions 218579 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218579 | tilghman | 2009-09-15 11:04:41 -0500 (Tue, 15 Sep 2009) | 16 lines
 
 Merged revisions 218577 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218577 | tilghman | 2009-09-15 11:01:17 -0500 (Tue, 15 Sep 2009) | 9 lines
   
   Ensure FollowMe sets language in channels it creates.
   Also, not in the original bug report, but related fields are accountcode and
   musicclass, and the inheritance of datastores.
   (closes issue ASTERISK-14353)
    Reported by: Romik
    Patches:
          20090828__issue15372.diff.txt uploaded by tilghman (license 14)
    Tested by: cervajs
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218582